[m145] Add metrics for glic summarize button [chromium/src : refs/branch-heads/7632]

0 views
Skip to first unread message

Erik Chen (Gerrit)

unread,
Feb 19, 2026, 11:28:34 PM (5 hours ago) Feb 19
to Sophie Chang, Lei Zhang, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
Attention needed from Sophie Chang

Erik Chen voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Sophie Chang
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7632
Gerrit-Change-Id: I2d0f02fee97bad3da94999f51d762c1b999c0af3
Gerrit-Change-Number: 7596086
Gerrit-PatchSet: 1
Gerrit-Owner: Erik Chen <erik...@chromium.org>
Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Sophie Chang <sophi...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 04:28:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Sophie Chang (Gerrit)

unread,
Feb 19, 2026, 11:30:16 PM (5 hours ago) Feb 19
to Erik Chen, Chromium LUCI CQ, Lei Zhang, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
Attention needed from Erik Chen

Sophie Chang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Erik Chen
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedLint
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: refs/branch-heads/7632
    Gerrit-Change-Id: I2d0f02fee97bad3da94999f51d762c1b999c0af3
    Gerrit-Change-Number: 7596086
    Gerrit-PatchSet: 1
    Gerrit-Owner: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
    Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Lei Zhang <the...@chromium.org>
    Gerrit-Attention: Erik Chen <erik...@chromium.org>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 04:30:07 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Erik Chen (Gerrit)

    unread,
    12:37 AM (4 hours ago) 12:37 AM
    to Sophie Chang, Chromium LUCI CQ, Lei Zhang, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org

    Erik Chen voted Commit-Queue+1

    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedLint
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: refs/branch-heads/7632
      Gerrit-Change-Id: I2d0f02fee97bad3da94999f51d762c1b999c0af3
      Gerrit-Change-Number: 7596086
      Gerrit-PatchSet: 3
      Gerrit-Owner: Erik Chen <erik...@chromium.org>
      Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
      Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Lei Zhang <the...@chromium.org>
      Gerrit-Comment-Date: Fri, 20 Feb 2026 05:37:17 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Erik Chen (Gerrit)

      unread,
      3:04 AM (2 hours ago) 3:04 AM
      to Sophie Chang, Chromium LUCI CQ, Lei Zhang, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
      Attention needed from Sophie Chang

      Erik Chen voted

      Code-Review+1
      Commit-Queue+2
      Owners-Override+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Sophie Chang
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement satisfiedLint
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: refs/branch-heads/7632
      Gerrit-Change-Id: I2d0f02fee97bad3da94999f51d762c1b999c0af3
      Gerrit-Change-Number: 7596086
      Gerrit-PatchSet: 6
      Gerrit-Owner: Erik Chen <erik...@chromium.org>
      Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
      Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Lei Zhang <the...@chromium.org>
      Gerrit-Attention: Sophie Chang <sophi...@chromium.org>
      Gerrit-Comment-Date: Fri, 20 Feb 2026 08:04:32 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Erik Chen (Gerrit)

      unread,
      3:10 AM (2 hours ago) 3:10 AM
      to Sophie Chang, Chromium LUCI CQ, Lei Zhang, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
      Attention needed from Sophie Chang

      Erik Chen voted

      Code-Review+1
      Commit-Queue+1
      Owners-Override+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Sophie Chang
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement satisfiedLint
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: refs/branch-heads/7632
      Gerrit-Change-Id: I2d0f02fee97bad3da94999f51d762c1b999c0af3
      Gerrit-Change-Number: 7596086
      Gerrit-PatchSet: 7
      Gerrit-Owner: Erik Chen <erik...@chromium.org>
      Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
      Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Lei Zhang <the...@chromium.org>
      Gerrit-Attention: Sophie Chang <sophi...@chromium.org>
      Gerrit-Comment-Date: Fri, 20 Feb 2026 08:10:15 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Lei Zhang (Gerrit)

      unread,
      3:25 AM (1 hour ago) 3:25 AM
      to Erik Chen, Lei Zhang, Sophie Chang, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
      Attention needed from Erik Chen and Sophie Chang

      Lei Zhang voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Erik Chen
      • Sophie Chang
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedLint
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: refs/branch-heads/7632
      Gerrit-Change-Id: I2d0f02fee97bad3da94999f51d762c1b999c0af3
      Gerrit-Change-Number: 7596086
      Gerrit-PatchSet: 7
      Gerrit-Owner: Erik Chen <erik...@chromium.org>
      Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
      Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
      Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Erik Chen <erik...@chromium.org>
      Gerrit-Attention: Sophie Chang <sophi...@chromium.org>
      Gerrit-Comment-Date: Fri, 20 Feb 2026 08:25:01 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Lei Zhang (Gerrit)

      unread,
      3:26 AM (1 hour ago) 3:26 AM
      to Erik Chen, Lei Zhang, Sophie Chang, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
      Attention needed from Erik Chen and Sophie Chang

      Lei Zhang voted Commit-Queue+2

      Commit-Queue+2
      Gerrit-Comment-Date: Fri, 20 Feb 2026 08:26:00 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Erik Chen (Gerrit)

      unread,
      3:29 AM (1 hour ago) 3:29 AM
      to Lei Zhang, Sophie Chang, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
      Attention needed from Sophie Chang

      Erik Chen voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Sophie Chang
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedLint
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: refs/branch-heads/7632
      Gerrit-Change-Id: I2d0f02fee97bad3da94999f51d762c1b999c0af3
      Gerrit-Change-Number: 7596086
      Gerrit-PatchSet: 7
      Gerrit-Owner: Erik Chen <erik...@chromium.org>
      Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
      Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
      Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Sophie Chang <sophi...@chromium.org>
      Gerrit-Comment-Date: Fri, 20 Feb 2026 08:29:34 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Tarun Bansal (Gerrit)

      unread,
      3:45 AM (1 hour ago) 3:45 AM
      to Erik Chen, Lei Zhang, Sophie Chang, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
      Attention needed from Erik Chen and Sophie Chang

      Tarun Bansal voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Erik Chen
      • Sophie Chang
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedLint
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: refs/branch-heads/7632
      Gerrit-Change-Id: I2d0f02fee97bad3da94999f51d762c1b999c0af3
      Gerrit-Change-Number: 7596086
      Gerrit-PatchSet: 7
      Gerrit-Owner: Erik Chen <erik...@chromium.org>
      Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
      Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
      Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
      Gerrit-Reviewer: Tarun Bansal <tba...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Erik Chen <erik...@chromium.org>
      Gerrit-Attention: Sophie Chang <sophi...@chromium.org>
      Gerrit-Comment-Date: Fri, 20 Feb 2026 08:44:47 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Erik Chen (Gerrit)

      unread,
      3:55 AM (1 hour ago) 3:55 AM
      to Tarun Bansal, Lei Zhang, Sophie Chang, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org

      Erik Chen submitted the change

      Change information

      Commit message:
      [m145] Add metrics for glic summarize button

      Delete chrome/browser/extensions/api/pdf_viewer_private/pdf_viewer_private_browsertest.cc
      which was already commented out of the build files
      in a previous merge

      > Add metrics for glic summarize button
      >
      > Bug: 483727155
      > Change-Id: Ida9e15217ae25c040cfcb66b9c38ccf643ceb23d
      > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7586460
      > Commit-Queue: Erik Chen <erik...@chromium.org>
      > Reviewed-by: Lei Zhang <the...@chromium.org>
      > Reviewed-by: Steven Holte <ho...@chromium.org>
      > Reviewed-by: Tarun Bansal <tba...@chromium.org>
      > Cr-Commit-Position: refs/heads/main@{#1586789}
      Bug: 483727155
      Change-Id: I2d0f02fee97bad3da94999f51d762c1b999c0af3
      Fixed: 485983723
      Commit-Queue: Lei Zhang <the...@chromium.org>
      Reviewed-by: Tarun Bansal <tba...@chromium.org>
      Owners-Override: Erik Chen <erik...@chromium.org>
      Commit-Queue: Erik Chen <erik...@chromium.org>
      Reviewed-by: Erik Chen <erik...@chromium.org>
      Reviewed-by: Lei Zhang <the...@chromium.org>
      Cr-Commit-Position: refs/branch-heads/7632@{#3065}
      Cr-Branched-From: 0bbdf2913883391365383b0a5dfe7bf9fd1a5213-refs/heads/main@{#1568190}
      Files:
      • M chrome/browser/extensions/api/pdf_viewer_private/pdf_viewer_private_api.cc
      • D chrome/browser/extensions/api/pdf_viewer_private/pdf_viewer_private_browsertest.cc
      • M chrome/browser/ui/pdf/BUILD.gn
      • M chrome/browser/ui/pdf/chrome_pdf_document_helper_client.cc
      • M tools/metrics/histograms/metadata/pdf/histograms.xml
      Change size: M
      Delta: 5 files changed, 72 insertions(+), 60 deletions(-)
      Branch: refs/branch-heads/7632
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Erik Chen, +1 by Tarun Bansal, +1 by Lei Zhang
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: refs/branch-heads/7632
      Gerrit-Change-Id: I2d0f02fee97bad3da94999f51d762c1b999c0af3
      Gerrit-Change-Number: 7596086
      Gerrit-PatchSet: 8
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages