[Extensions] Convert fileSystemProvider to WebIDL [chromium/src : main]

0 views

Skip to first unread message

Tim (Gerrit)

unread,

3:36 PM (6 hours ago) 3:36 PM

to Devlin Cronin, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org

Attention needed from Devlin Cronin

Tim added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Tim . resolved

Back to the schema conversions. I actually uploaded this one a while back but it got put on the back-burner with other stuff going on. Can you take a look?

Open in Gerrit

Related details

Attention is currently required from:

Devlin Cronin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Devlin Cronin (Gerrit)

unread,

5:32 PM (4 hours ago) 5:32 PM

to Tim, Devlin Cronin, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org

Attention needed from Tim

Devlin Cronin voted and added 2 comments

Votes added by Devlin Cronin

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Devlin Cronin . resolved

LGTM; thanks, Tim!

File chrome/common/extensions/api/file_system_provider.webidl

Line 819, Patchset 4 (Latest): MountOptions options);

Devlin Cronin . unresolved

nit: wrapping?