[UNO] Preserve state for users with bookmarks and extensions enabled [chromium/src : main]

[Monica Salama (Gerrit)]

Attention needed from David Roger and Monica Salama

Monica Salama voted and added 1 comment

Votes added by Monica Salama

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Monica Salama . resolved

Hi David,

PTAL while I fix tests on Android/ChromeOS, thanks!

Open in Gerrit

Related details

Attention is currently required from:

• David Roger
• Monica Salama

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3d84036d6f09236818a31cd57949ae12cf2cc3fc

Gerrit-Change-Number: 7657744

Gerrit-PatchSet: 3

Gerrit-Owner: Monica Salama <msa...@chromium.org>

Gerrit-Reviewer: David Roger <dro...@chromium.org>

Gerrit-Reviewer: Monica Salama <msa...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: David Roger <dro...@chromium.org>

Gerrit-Attention: Monica Salama <msa...@chromium.org>

Gerrit-Comment-Date: Thu, 12 Mar 2026 13:20:21 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Ankush Singh (Gerrit)]

Attention needed from Monica Salama

Ankush Singh added 4 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Ankush Singh . resolved

Thanks! I haven't yet looked at the tests :(

File components/signin/internal/identity_manager/primary_account_manager.cc

Line 118, Patchset 4 (Latest): // Returns true if extensions should be enabled for users who were already
// signed in when they migrated to Dice.

Ankush Singh . unresolved

`existing signed-in users` makes more sense?

Line 122, Patchset 4 (Latest): // existing sessions during Dice migration. In the new behavior, extensions

Ankush Singh . unresolved

`sync-to-signin migration`

Line 128, Patchset 4 (Latest): !syncer::kExplicitSigninForExtensions.Get();

Ankush Singh . unresolved

What I understand is that now we are saving whether or not extensions and bookmarks sync was previously on. What I'd like to know is what will happen if some pre-M147 user in the original migration group jumps to M150 where our launch plan should already be complete? Or maybe, we plan to keep the experiment ongoing for a long time?

Open in Gerrit

Related details

Attention is currently required from:

• Monica Salama

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3d84036d6f09236818a31cd57949ae12cf2cc3fc

Gerrit-Change-Number: 7657744

Gerrit-PatchSet: 4

Gerrit-Owner: Monica Salama <msa...@chromium.org>

Gerrit-Reviewer: Ankush Singh <ankus...@google.com>

Gerrit-Reviewer: David Roger <dro...@chromium.org>

Gerrit-Reviewer: Monica Salama <msa...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Monica Salama <msa...@chromium.org>

Gerrit-Comment-Date: Thu, 12 Mar 2026 15:17:36 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Monica Salama (Gerrit)]

Attention needed from Ankush Singh

Monica Salama added 1 comment

File components/signin/internal/identity_manager/primary_account_manager.cc

Line 128, Patchset 4 (Latest): !syncer::kExplicitSigninForExtensions.Get();

Ankush Singh . unresolved

What I understand is that now we are saving whether or not extensions and bookmarks sync was previously on. What I'd like to know is what will happen if some pre-M147 user in the original migration group jumps to M150 where our launch plan should already be complete? Or maybe, we plan to keep the experiment ongoing for a long time?

Monica Salama

@dro...@chromium.org to correct if I am wrong.

The plan is to monitor that most of the 25% users in this bucket migrate to M147+ before shuffling groups, it is been discussed in the meeting that it could take around three weeks for like ~95% of the users to have migrated to M147. The threshold is not clear.

Open in Gerrit

Related details

Attention is currently required from:

• Ankush Singh

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3d84036d6f09236818a31cd57949ae12cf2cc3fc

Gerrit-Change-Number: 7657744

Gerrit-PatchSet: 4

Gerrit-Owner: Monica Salama <msa...@chromium.org>

Gerrit-Reviewer: Ankush Singh <ankus...@google.com>

Gerrit-Reviewer: David Roger <dro...@chromium.org>

Gerrit-Reviewer: Monica Salama <msa...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ankush Singh <ankus...@google.com>

Gerrit-Comment-Date: Thu, 12 Mar 2026 15:28:20 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Ankush Singh <ankus...@google.com>