Reland "[UNO] Merge extensions sign in promo code path" [chromium/src : main]

0 views
Skip to first unread message

Kelvin Jiang (Gerrit)

unread,
Oct 30, 2025, 5:47:22 PM (17 hours ago) Oct 30
to Amelie Schneider, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Amelie Schneider

Kelvin Jiang added 2 comments

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Kelvin Jiang . resolved

CL LGTM otherwise

File chrome/browser/ui/signin/promos/bubble_signin_promo_interactive_uitest.cc
Line 248, Patchset 5 (Latest): return extension_loader.LoadExtension(extension_dir.Pack());
Kelvin Jiang . unresolved

As mentioned in chat, this seems to fail on branded builds because the extension is disabled as "the installation cannot be verified", see install_verifier.cc

One way to bypass this in tests is to add a scoped override:
`extensions::ScopedInstallVerifierBypassForTest install_verifier_bypass;`

This is probably enough for this CL though I am curious how this test fails on branded builds without it when others may not...

Open in Gerrit

Related details

Attention is currently required from:
  • Amelie Schneider
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0453f9ff5c4b12c4c8c6bb1fe1b60580f143c4c9
Gerrit-Change-Number: 7079028
Gerrit-PatchSet: 5
Gerrit-Owner: Amelie Schneider <ame...@google.com>
Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
Gerrit-Attention: Amelie Schneider <ame...@google.com>
Gerrit-Comment-Date: Thu, 30 Oct 2025 21:47:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Amelie Schneider (Gerrit)

unread,
6:19 AM (4 hours ago) 6:19 AM
to Chromium LUCI CQ, Kelvin Jiang, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Kelvin Jiang

Amelie Schneider added 2 comments

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Amelie Schneider . resolved

Thanks!

File chrome/browser/ui/signin/promos/bubble_signin_promo_interactive_uitest.cc
Line 248, Patchset 5: return extension_loader.LoadExtension(extension_dir.Pack());
Kelvin Jiang . resolved

As mentioned in chat, this seems to fail on branded builds because the extension is disabled as "the installation cannot be verified", see install_verifier.cc

One way to bypass this in tests is to add a scoped override:
`extensions::ScopedInstallVerifierBypassForTest install_verifier_bypass;`

This is probably enough for this CL though I am curious how this test fails on branded builds without it when others may not...

Amelie Schneider

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Kelvin Jiang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0453f9ff5c4b12c4c8c6bb1fe1b60580f143c4c9
    Gerrit-Change-Number: 7079028
    Gerrit-PatchSet: 6
    Gerrit-Owner: Amelie Schneider <ame...@google.com>
    Gerrit-Reviewer: Amelie Schneider <ame...@google.com>
    Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
    Gerrit-Attention: Kelvin Jiang <kelvi...@chromium.org>
    Gerrit-Comment-Date: Fri, 31 Oct 2025 10:19:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Kelvin Jiang <kelvi...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Amelie Schneider (Gerrit)

    unread,
    8:35 AM (2 hours ago) 8:35 AM
    to Finnur Thorarinsson, Mikel Astiz, Chromium LUCI CQ, Kelvin Jiang, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
    Attention needed from Finnur Thorarinsson, Kelvin Jiang and Mikel Astiz

    Amelie Schneider added 1 comment

    Patchset-level comments
    File-level comment, Patchset 9 (Latest):
    Amelie Schneider . resolved

    Hi Mikel and Finnur, please take another look. Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Finnur Thorarinsson
    • Kelvin Jiang
    • Mikel Astiz
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0453f9ff5c4b12c4c8c6bb1fe1b60580f143c4c9
    Gerrit-Change-Number: 7079028
    Gerrit-PatchSet: 9
    Gerrit-Owner: Amelie Schneider <ame...@google.com>
    Gerrit-Reviewer: Amelie Schneider <ame...@google.com>
    Gerrit-Reviewer: Finnur Thorarinsson <fin...@chromium.org>
    Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
    Gerrit-Reviewer: Mikel Astiz <mas...@chromium.org>
    Gerrit-Attention: Kelvin Jiang <kelvi...@chromium.org>
    Gerrit-Attention: Mikel Astiz <mas...@chromium.org>
    Gerrit-Attention: Finnur Thorarinsson <fin...@chromium.org>
    Gerrit-Comment-Date: Fri, 31 Oct 2025 12:34:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mikel Astiz (Gerrit)

    unread,
    8:50 AM (2 hours ago) 8:50 AM
    to Amelie Schneider, Finnur Thorarinsson, Chromium LUCI CQ, Kelvin Jiang, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
    Attention needed from Amelie Schneider, Finnur Thorarinsson and Kelvin Jiang

    Mikel Astiz voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Amelie Schneider
    • Finnur Thorarinsson
    • Kelvin Jiang
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I0453f9ff5c4b12c4c8c6bb1fe1b60580f143c4c9
      Gerrit-Change-Number: 7079028
      Gerrit-PatchSet: 9
      Gerrit-Owner: Amelie Schneider <ame...@google.com>
      Gerrit-Reviewer: Amelie Schneider <ame...@google.com>
      Gerrit-Reviewer: Finnur Thorarinsson <fin...@chromium.org>
      Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
      Gerrit-Reviewer: Mikel Astiz <mas...@chromium.org>
      Gerrit-Attention: Amelie Schneider <ame...@google.com>
      Gerrit-Attention: Kelvin Jiang <kelvi...@chromium.org>
      Gerrit-Attention: Finnur Thorarinsson <fin...@chromium.org>
      Gerrit-Comment-Date: Fri, 31 Oct 2025 12:50:34 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages