Add scheib as extensions/apps team owner. (issue 23757050)

1 view
Skip to first unread message

sch...@chromium.org

unread,
Sep 16, 2013, 2:25:51 PM9/16/13
to mi...@chromium.org, chromium...@chromium.org, extension...@chromium.org, nkostyl...@chromium.org, oshima...@chromium.org, chromium-a...@chromium.org, stevenj...@chromium.org, davemoo...@chromium.org
Reviewers: miket,

Description:
Add scheib as extensions/apps team owner.

Please review this at https://codereview.chromium.org/23757050/

SVN Base: svn://svn.chromium.org/chrome/trunk/src

Affected files (+6, -0 lines):
M chrome/browser/chromeos/extensions/OWNERS
M chrome/browser/extensions/OWNERS
M chrome/common/extensions/OWNERS
M chrome/renderer/extensions/OWNERS
M chrome/renderer/resources/extensions/OWNERS
M extensions/OWNERS


Index: chrome/browser/chromeos/extensions/OWNERS
diff --git a/chrome/browser/chromeos/extensions/OWNERS
b/chrome/browser/chromeos/extensions/OWNERS
index
6571aa3641293e31174fd277f8526368d9d8efed..6e6bf5aabd977421a7ffba21a9e588680e7a5423
100644
--- a/chrome/browser/chromeos/extensions/OWNERS
+++ b/chrome/browser/chromeos/extensions/OWNERS
@@ -8,6 +8,7 @@ k...@chromium.org
m...@chromium.org
mi...@chromium.org
mpcom...@chromium.org
+sch...@chromium.org
y...@chromium.org

# Additional ChromeOS-specific reviewers
Index: chrome/browser/extensions/OWNERS
diff --git a/chrome/browser/extensions/OWNERS
b/chrome/browser/extensions/OWNERS
index
b4779a602f2e3651c62731c06c3bb3f6131b8315..a7415d631193038dd353612be599d6730b789b3e
100644
--- a/chrome/browser/extensions/OWNERS
+++ b/chrome/browser/extensions/OWNERS
@@ -17,4 +17,5 @@ k...@chromium.org
m...@chromium.org
mi...@chromium.org
mpcom...@chromium.org
+sch...@chromium.org
y...@chromium.org
Index: chrome/common/extensions/OWNERS
diff --git a/chrome/common/extensions/OWNERS
b/chrome/common/extensions/OWNERS
index
c80762a29a2686f11b0b7da079defe35af832555..db593ecee54381dbc783615d0d59b3c6c9124b9b
100644
--- a/chrome/common/extensions/OWNERS
+++ b/chrome/common/extensions/OWNERS
@@ -8,6 +8,7 @@ k...@chromium.org
m...@chromium.org
mi...@chromium.org
mpcom...@chromium.org
+sch...@chromium.org
y...@chromium.org

# For security review of IPC message files.
Index: chrome/renderer/extensions/OWNERS
diff --git a/chrome/renderer/extensions/OWNERS
b/chrome/renderer/extensions/OWNERS
index
a6cd87dfa0d2fc5d0e7e71b09a9e99705fd35d76..a3e72f9a366e0db822c9d3c0cfe17191c91c0233
100644
--- a/chrome/renderer/extensions/OWNERS
+++ b/chrome/renderer/extensions/OWNERS
@@ -8,4 +8,5 @@ k...@chromium.org
m...@chromium.org
mi...@chromium.org
mpcom...@chromium.org
+sch...@chromium.org
y...@chromium.org
Index: chrome/renderer/resources/extensions/OWNERS
diff --git a/chrome/renderer/resources/extensions/OWNERS
b/chrome/renderer/resources/extensions/OWNERS
index
50f29c1d9625611d0e1659c497c10326b804d20f..1ed446f427de58b4c962dc65b50745b71e1ee158
100644
--- a/chrome/renderer/resources/extensions/OWNERS
+++ b/chrome/renderer/resources/extensions/OWNERS
@@ -8,6 +8,7 @@ k...@chromium.org
m...@chromium.org
mi...@chromium.org
mpcom...@chromium.org
+sch...@chromium.org
y...@chromium.org

per-file searchbox_api.js=dcb...@chromium.org
Index: extensions/OWNERS
diff --git a/extensions/OWNERS b/extensions/OWNERS
index
a6cd87dfa0d2fc5d0e7e71b09a9e99705fd35d76..a3e72f9a366e0db822c9d3c0cfe17191c91c0233
100644
--- a/extensions/OWNERS
+++ b/extensions/OWNERS
@@ -8,4 +8,5 @@ k...@chromium.org
m...@chromium.org
mi...@chromium.org
mpcom...@chromium.org
+sch...@chromium.org
y...@chromium.org


mi...@chromium.org

unread,
Sep 16, 2013, 2:38:29 PM9/16/13
to sch...@chromium.org, chromium...@chromium.org, extension...@chromium.org, nkostyl...@chromium.org, oshima...@chromium.org, chromium-a...@chromium.org, stevenj...@chromium.org, davemoo...@chromium.org
On 2013/09/16 18:25:51, scheib wrote:

LGTM but first: after discussion Antony and I are trying an experiment.
asargent
gets a huge number of OWNERS reviews, and we think it's because his account
name
starts with A. So we'd like to switch to a time-ordered list. Will you
please
put your name at the top of each list rather than alphabetically? If the
sort
order is (date added DESC, name ASC), then it's consistent.

Alternatively, if you buy the theory and are afraid of what's about to
happen,
then you can grandfather yourself in *but* please randomize each group.
(sort
-R)

https://codereview.chromium.org/23757050/

commi...@chromium.org

unread,
Sep 16, 2013, 4:51:01 PM9/16/13
to sch...@chromium.org, mi...@chromium.org, chromium...@chromium.org, extension...@chromium.org, nkostyl...@chromium.org, oshima...@chromium.org, chromium-a...@chromium.org, stevenj...@chromium.org, davemoo...@chromium.org

commi...@chromium.org

unread,
Sep 16, 2013, 7:19:12 PM9/16/13
to sch...@chromium.org, mi...@chromium.org, chromium...@chromium.org, extension...@chromium.org, nkostyl...@chromium.org, oshima...@chromium.org, chromium-a...@chromium.org, stevenj...@chromium.org, davemoo...@chromium.org, asar...@chromium.org

kal...@chromium.org

unread,
Sep 17, 2013, 4:15:34 PM9/17/13
to sch...@chromium.org, mi...@chromium.org, chromium...@chromium.org, extension...@chromium.org, nkostyl...@chromium.org, oshima...@chromium.org, chromium-a...@chromium.org, stevenj...@chromium.org, davemoo...@chromium.org, asar...@chromium.org
if it really is the alphabetical thing then perhaps let dpranke@ know, I
think
he wrote the reviewer suggestion stuff.

https://codereview.chromium.org/23757050/

Vincent Scheib

unread,
Sep 17, 2013, 4:21:56 PM9/17/13
to scheib, miket, Benjamin Kalman, chromium...@chromium.org, extension...@chromium.org, nkostyl...@chromium.org, oshima...@chromium.org, chromium-a...@chromium.org, stevenj...@chromium.org, davemoo...@chromium.org, Antony Sargent
Owners suggestion is undergoing iteration, an interactive tool is nearly done: https://codereview.chromium.org/12712002/ 

After that lands, I agree it would be cleaner to randomize the script vs the files.

Mike Tsao

unread,
Sep 17, 2013, 4:25:57 PM9/17/13
to Vincent Scheib, Benjamin Kalman, chromium...@chromium.org, extension...@chromium.org, nkostyl...@chromium.org, oshima...@chromium.org, chromium-a...@chromium.org, stevenj...@chromium.org, davemoo...@chromium.org, Antony Sargent
Oh, neato, so we're not the only ones having this issue. Great, still LGTM.
> --
> You received this message because you are subscribed to the Google Groups
> "Extensions reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to extensions-revi...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/extensions-reviews/CAK-EfXmX6ST_spqm%3DUb2N4h%3DESwN5rv8n1EnNhws%2Bx9O4uZDbw%40mail.gmail.com.
Reply all
Reply to author
Forward
0 new messages