ExtensionUnpublishedAvailability policy should ignore malware extensions [chromium/src : main]
40 views
Skip to first unread message
Anunoy Ghosh (Gerrit)
May 25, 2023, 7:08:49 PM5/25/23
to David Bertoni, chromium-a...@chromium.org, extension...@chromium.org
Attention is currently required from: David Bertoni.
Anunoy Ghosh would like David Bertoni to review this change.
ExtensionUnpublishedAvailability policy should ignore malware extensions
Extensions taken down for malware are already de-activated/unloaded in
Chrome via an existing blocklisting mechanism. A user is not allowed
to re-enable these extensions. So the policy does not add any value here
by trying to disable these extensions. Moreover, making the policy
disable malware extensions has a side-effect of showing the policy
disable string in the extension's Detail view (in chrome://extensions) even when the policy is disabled.
Bug: 1449026
Change-Id: I26866d04fe9534da4b2a97e67b3b0b4424a70a33
---
M chrome/browser/extensions/extension_management.cc
M chrome/browser/extensions/extension_management_unittest.cc
2 files changed, 45 insertions(+), 11 deletions(-)
To view, visit change 4567823. To unsubscribe, or for help writing mail filters, visit settings.
Anunoy Ghosh (Gerrit)
May 25, 2023, 7:08:56 PM5/25/23
to chromium-a...@chromium.org, extension...@chromium.org, David Bertoni, chromium...@chromium.org
Attention is currently required from: David Bertoni.
Anunoy Ghosh (Gerrit)
May 25, 2023, 7:10:15 PM5/25/23
to chromium-a...@chromium.org, extension...@chromium.org
Attention is currently required from: David Bertoni.
Anunoy Ghosh uploaded patch set #5 to this change.
ExtensionUnpublishedAvailability policy should ignore malware extensions
Extensions taken down for malware are already de-activated/unloaded in
Chrome via an existing blocklisting mechanism. A user is not allowed
to re-enable these extensions. So the policy does not add any value here
by trying to disable these extensions. Moreover, making the policy
disable malware extensions has a side-effect of showing the policy
disable string in the extension's Detail view (in chrome://extensions) even when the policy is disabled. See bug description for more details.
Bug: 1449026
Change-Id: I26866d04fe9534da4b2a97e67b3b0b4424a70a33
---
M chrome/browser/extensions/extension_management.cc
M chrome/browser/extensions/extension_management_unittest.cc
2 files changed, 45 insertions(+), 11 deletions(-)
To view, visit change 4567823. To unsubscribe, or for help writing mail filters, visit settings.
David Bertoni (Gerrit)
May 26, 2023, 1:32:51 PM5/26/23
to Anunoy Ghosh, chromium-a...@chromium.org, extension...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org
Attention is currently required from: Anunoy Ghosh.
Patch set 5:Code-Review +1
1 comment:
Patchset:
lgtm, thanks!
To view, visit change 4567823. To unsubscribe, or for help writing mail filters, visit settings.
Anunoy Ghosh (Gerrit)
May 26, 2023, 1:34:01 PM5/26/23
to chromium-a...@chromium.org, extension...@chromium.org, David Bertoni, Chromium LUCI CQ, chromium...@chromium.org
Attention is currently required from: Anunoy Ghosh.
Patch set 5:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
May 26, 2023, 1:39:08 PM5/26/23
to Anunoy Ghosh, chromium-a...@chromium.org, extension...@chromium.org, David Bertoni, chromium...@chromium.org
Chromium LUCI CQ submitted this change.
Approvals:
Anunoy Ghosh: Commit
David Bertoni: Looks good to me
ExtensionUnpublishedAvailability policy should ignore malware extensions
Extensions taken down for malware are already de-activated/unloaded in
Chrome via an existing blocklisting mechanism. A user is not allowed
to re-enable these extensions. So the policy does not add any value here
by trying to disable these extensions. Moreover, making the policy
disable malware extensions has a side-effect of showing the policy
disable string in the extension's Detail view (in chrome://extensions) even when the policy is disabled. See bug description for more details.
Bug: 1449026
Change-Id: I26866d04fe9534da4b2a97e67b3b0b4424a70a33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4567823
Reviewed-by: David Bertoni <dber...@chromium.org>
Commit-Queue: Anunoy Ghosh <anu...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1149789}
---
M chrome/browser/extensions/extension_management.cc
M chrome/browser/extensions/extension_management_unittest.cc
2 files changed, 45 insertions(+), 11 deletions(-)
Reply all
Reply to author
Forward
0 new messages