Use more standard enumerator names in tab enum Part1 [chromium/src : main]

0 views

Skip to first unread message

Jongmok Kim (Gerrit)

unread,

Oct 27, 2025, 9:27:33 AM (2 days ago) Oct 27

to Darryl James, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, jophba...@chromium.org, msrame...@chromium.org

Attention needed from Darryl James

Jongmok Kim added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Jongmok Kim . resolved

Hello, Darryl James.
PTAL.

Could you review this?
Thank you!

Open in Gerrit

Related details

Attention is currently required from:

Darryl James

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Darryl James (Gerrit)

unread,

Oct 27, 2025, 4:10:09 PM (2 days ago) Oct 27

to Jongmok Kim, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, jophba...@chromium.org, msrame...@chromium.org

Attention needed from Jongmok Kim

Darryl James added 1 comment

Commit Message

Line 7, Patchset 1 (Latest):Use more standard enumerator names in tab enum Part1

Darryl James . unresolved

Let's update this commit message to clarify that this CL updates the enum entries for `TabMutedReason`

And then in the proceeding line we can briefly describe why we are making this change. Ex:

Update Enumerator Names to Match the Chromium Style Guide Part 1

Updates the TabMutedReason enum entries in order to follow the Chromium Style Guide naming conventions kFoo instead of FOO.