Devlin Cronin (Gerrit)

unread,

7:12 PM (2 hours ago) 7:12 PM

to Devlin Cronin, Kelvin Jiang, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Kelvin Jiang

Devlin Cronin voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Kelvin Jiang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kelvin Jiang (Gerrit)

unread,

7:13 PM (2 hours ago) 7:13 PM

to Devlin Cronin, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Devlin Cronin

Kelvin Jiang voted and added 1 comment

Votes added by Kelvin Jiang

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Kelvin Jiang . resolved

LGTM thanks!

Open in Gerrit

Related details

Attention is currently required from:

Devlin Cronin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

8:42 PM (1 hour ago) 8:42 PM

to Devlin Cronin, Kelvin Jiang, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[Extensions] Extend a few DNR histograms

Extend the following histograms:
* Extensions.DeclarativeNetRequest.RulesetMatchingBeforeRequestActionTime
* Extensions.DeclarativeNetRequest.RulesetMatchingHeadersReceivedActionTime
* Extensions.WebRequest.BeforeRequestDeclarativeNetRequestEvaluationTimeInMicroseconds
* Extensions.NetworkDelay (conceptually DNR related)

Fixed: 525061819, 525062334

Change-Id: Ia227db6a0e2683ad64d6c172be5661b95b804ef0

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8007783

Commit-Queue: Kelvin Jiang <kelvi...@chromium.org>

Auto-Submit: Devlin Cronin <rdevlin...@chromium.org>

Reviewed-by: Kelvin Jiang <kelvi...@chromium.org>

Commit-Queue: Devlin Cronin <rdevlin...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1652835}

Files:

M tools/metrics/histograms/metadata/extensions/histograms.xml

Change size: XS

Delta: 1 file changed, 4 insertions(+), 4 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Kelvin Jiang

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[Extensions] Extend a few DNR histograms [chromium/src : main]

Devlin Cronin (Gerrit)

Devlin Cronin voted

Related details

Kelvin Jiang (Gerrit)

Kelvin Jiang voted and added 1 comment

Votes added by Kelvin Jiang

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information