[Extensions] Extend a few DNR histograms [chromium/src : main]

0 views
Skip to first unread message

Devlin Cronin (Gerrit)

unread,
7:12 PM (2 hours ago) 7:12 PM
to Devlin Cronin, Kelvin Jiang, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Kelvin Jiang

Devlin Cronin voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kelvin Jiang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia227db6a0e2683ad64d6c172be5661b95b804ef0
Gerrit-Change-Number: 8007783
Gerrit-PatchSet: 1
Gerrit-Owner: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Kelvin Jiang <kelvi...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Jun 2026 23:11:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kelvin Jiang (Gerrit)

unread,
7:13 PM (2 hours ago) 7:13 PM
to Devlin Cronin, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin

Kelvin Jiang voted and added 1 comment

Votes added by Kelvin Jiang

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kelvin Jiang . resolved

LGTM thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Devlin Cronin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia227db6a0e2683ad64d6c172be5661b95b804ef0
Gerrit-Change-Number: 8007783
Gerrit-PatchSet: 1
Gerrit-Owner: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Jun 2026 23:13:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
8:42 PM (1 hour ago) 8:42 PM
to Devlin Cronin, Kelvin Jiang, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[Extensions] Extend a few DNR histograms

Extend the following histograms:
* Extensions.DeclarativeNetRequest.RulesetMatchingBeforeRequestActionTime
* Extensions.DeclarativeNetRequest.RulesetMatchingHeadersReceivedActionTime
* Extensions.WebRequest.BeforeRequestDeclarativeNetRequestEvaluationTimeInMicroseconds
* Extensions.NetworkDelay (conceptually DNR related)
Fixed: 525061819, 525062334
Change-Id: Ia227db6a0e2683ad64d6c172be5661b95b804ef0
Commit-Queue: Kelvin Jiang <kelvi...@chromium.org>
Auto-Submit: Devlin Cronin <rdevlin...@chromium.org>
Reviewed-by: Kelvin Jiang <kelvi...@chromium.org>
Commit-Queue: Devlin Cronin <rdevlin...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1652835}
Files:
  • M tools/metrics/histograms/metadata/extensions/histograms.xml
Change size: XS
Delta: 1 file changed, 4 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kelvin Jiang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia227db6a0e2683ad64d6c172be5661b95b804ef0
Gerrit-Change-Number: 8007783
Gerrit-PatchSet: 2
Gerrit-Owner: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages