Migrate //chrome to base::HexEncodeLower [chromium/src : main]

0 views
Skip to first unread message

David Benjamin (Gerrit)

unread,
Oct 30, 2025, 2:47:46 PM (2 days ago) Oct 30
to Enterprise Policy Reviews, devtools...@chromium.org, Mathias Bynens, chromium...@chromium.org, dibyapal+wa...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, zackha...@chromium.org, jshin...@chromium.org, philli...@chromium.org, cros-ed...@google.com, feature-me...@chromium.org, oshima...@chromium.org, dkrahn...@chromium.org, zelin+watch-we...@chromium.org, print-rev...@chromium.org, mfoltz+wa...@chromium.org, xinghui...@chromium.org, cros-print...@google.com, andysjl...@chromium.org, croissant-...@chromium.org, net-r...@chromium.org, chromium-a...@chromium.org, mgiuca...@chromium.org, druber...@chromium.org, bnc+...@chromium.org, cros-enterpris...@chromium.org, loyso...@chromium.org, dmurph+watc...@chromium.org, filesapp...@chromium.org, kuragin+web-ap...@chromium.org, webap...@microsoft.com, extension...@chromium.org

David Benjamin has uploaded the change for review

Commit message

Migrate //chrome to base::HexEncodeLower
Bug: 456472080
Change-Id: I118a457d0c20eb88644487496d0f401234ca28e8

Change diff


Change information

Files:
  • M chrome/browser/ash/attestation/enrollment_id_upload_manager.cc
  • M chrome/browser/ash/drive/drive_integration_service.cc
  • M chrome/browser/ash/drive/drivefs_test_support.cc
  • M chrome/browser/ash/policy/reporting/install_event_log_util.cc
  • M chrome/browser/ash/printing/enterprise/enterprise_printers_provider.cc
  • M chrome/browser/ash/printing/server_printers_fetcher.cc
  • M chrome/browser/ash/printing/usb_printer_util.cc
  • M chrome/browser/ash/printing/zeroconf_printer_detector.cc
  • M chrome/browser/ash/smb_client/smbfs_share.cc
  • M chrome/browser/component_updater/metadata_table_chromeos.cc
  • M chrome/browser/device_identity/chromeos/token_encryptor.cc
  • M chrome/browser/devtools/devtools_file_helper.cc
  • M chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
  • M chrome/browser/extensions/api/image_writer_private/operation.cc
  • M chrome/browser/extensions/api/image_writer_private/write_from_url_operation_unittest.cc
  • M chrome/browser/extensions/updater/local_extension_cache_unittest.cc
  • M chrome/browser/media/router/discovery/discovery_network_monitor.cc
  • M chrome/browser/profile_resetter/resettable_settings_snapshot.cc
  • M chrome/browser/safe_browsing/threat_details_unittest.cc
  • M chrome/browser/shortcuts/shortcut_creator_linux.cc
  • M chrome/browser/spellchecker/spellcheck_custom_dictionary.cc
  • M chrome/browser/sync/test/integration/single_client_webauthn_credentials_sync_test.cc
  • M chrome/browser/ui/ash/wallpaper/wallpaper_controller_client_impl.cc
  • M chrome/browser/ui/webui/certificate_manager/client_cert_sources_writable_unittest.cc
  • M chrome/browser/ui/webui/certificate_manager/user_cert_sources_unittest.cc
  • M chrome/browser/ui/webui/connectors_internals/device_trust_utils.cc
  • M chrome/browser/ui/webui/net_internals/net_internals_ui.cc
  • M chrome/browser/web_applications/os_integration/web_app_uninstallation_via_os_settings_registration_win.cc
  • M chrome/test/chromedriver/chrome_launcher.cc
Change size: M
Delta: 29 files changed, 60 insertions(+), 69 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I118a457d0c20eb88644487496d0f401234ca28e8
Gerrit-Change-Number: 7103100
Gerrit-PatchSet: 1
Gerrit-Owner: David Benjamin <davi...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

David Benjamin (Gerrit)

unread,
Oct 30, 2025, 6:05:08 PM (2 days ago) Oct 30
to Erik Chen, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Mathias Bynens, andysjl...@chromium.org, bnc+...@chromium.org, chromium-a...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, dibyapal+wa...@chromium.org, dkrahn...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, jshin...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Erik Chen

David Benjamin voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Erik Chen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I118a457d0c20eb88644487496d0f401234ca28e8
Gerrit-Change-Number: 7103100
Gerrit-PatchSet: 1
Gerrit-Owner: David Benjamin <davi...@chromium.org>
Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-Attention: Erik Chen <erik...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Oct 2025 22:05:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Erik Chen (Gerrit)

unread,
Oct 30, 2025, 11:43:57 PM (2 days ago) Oct 30
to David Benjamin, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Mathias Bynens, andysjl...@chromium.org, bnc+...@chromium.org, chromium-a...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, dibyapal+wa...@chromium.org, dkrahn...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, jshin...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from David Benjamin

Erik Chen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Benjamin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I118a457d0c20eb88644487496d0f401234ca28e8
Gerrit-Change-Number: 7103100
Gerrit-PatchSet: 1
Gerrit-Owner: David Benjamin <davi...@chromium.org>
Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-Attention: David Benjamin <davi...@chromium.org>
Gerrit-Comment-Date: Fri, 31 Oct 2025 03:43:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

David Benjamin (Gerrit)

unread,
Oct 31, 2025, 10:00:25 PM (yesterday) Oct 31
to Erik Chen, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Mathias Bynens, andysjl...@chromium.org, bnc+...@chromium.org, chromium-a...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, dibyapal+wa...@chromium.org, dkrahn...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, jshin...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

David Benjamin voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I118a457d0c20eb88644487496d0f401234ca28e8
Gerrit-Change-Number: 7103100
Gerrit-PatchSet: 1
Gerrit-Owner: David Benjamin <davi...@chromium.org>
Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-Comment-Date: Sat, 01 Nov 2025 02:00:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

David Benjamin (Gerrit)

unread,
4:36 PM (7 hours ago) 4:36 PM
to Erik Chen, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Mathias Bynens, andysjl...@chromium.org, bnc+...@chromium.org, chromium-a...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, dibyapal+wa...@chromium.org, dkrahn...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, jshin...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

David Benjamin voted

Auto-Submit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I118a457d0c20eb88644487496d0f401234ca28e8
Gerrit-Change-Number: 7103100
Gerrit-PatchSet: 2
Gerrit-Owner: David Benjamin <davi...@chromium.org>
Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-Comment-Date: Sat, 01 Nov 2025 20:36:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
5:21 PM (6 hours ago) 5:21 PM
to David Benjamin, Erik Chen, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Mathias Bynens, andysjl...@chromium.org, bnc+...@chromium.org, chromium-a...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, dibyapal+wa...@chromium.org, dkrahn...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, jshin...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: chrome/browser/media/router/discovery/discovery_network_monitor.cc
Insertions: 1, Deletions: 2.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:
Migrate //chrome to base::HexEncodeLower
Bug: 456472080
Change-Id: I118a457d0c20eb88644487496d0f401234ca28e8
Auto-Submit: David Benjamin <davi...@chromium.org>
Commit-Queue: David Benjamin <davi...@chromium.org>
Reviewed-by: Erik Chen <erik...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1539048}
Delta: 29 files changed, 60 insertions(+), 70 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Erik Chen
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I118a457d0c20eb88644487496d0f401234ca28e8
Gerrit-Change-Number: 7103100
Gerrit-PatchSet: 3
Gerrit-Owner: David Benjamin <davi...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages