[Extensions] Ensure iterator stability for EventListenerMap [chromium/src : main]

0 views
Skip to first unread message

Andrea Orru (Gerrit)

unread,
Apr 1, 2026, 1:03:53 PM (yesterday) Apr 1
to Dominic Battre, AyeAye, Chromium LUCI CQ, Keishi Hattori, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Dominic Battre

Andrea Orru voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dominic Battre
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I81bd322f69c8628d3d0b3cedcbaaf7e26a6a6964
Gerrit-Change-Number: 7718823
Gerrit-PatchSet: 2
Gerrit-Owner: Dominic Battre <bat...@chromium.org>
Gerrit-Reviewer: Andrea Orru <andre...@chromium.org>
Gerrit-Reviewer: Dominic Battre <bat...@chromium.org>
Gerrit-CC: Keishi Hattori <kei...@chromium.org>
Gerrit-Attention: Dominic Battre <bat...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 17:03:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Dominic Battre (Gerrit)

unread,
Apr 1, 2026, 2:21:49 PM (yesterday) Apr 1
to Andrea Orru, AyeAye, Chromium LUCI CQ, Keishi Hattori, chromium-a...@chromium.org, extension...@chromium.org

Dominic Battre voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I81bd322f69c8628d3d0b3cedcbaaf7e26a6a6964
Gerrit-Change-Number: 7718823
Gerrit-PatchSet: 2
Gerrit-Owner: Dominic Battre <bat...@chromium.org>
Gerrit-Reviewer: Andrea Orru <andre...@chromium.org>
Gerrit-Reviewer: Dominic Battre <bat...@chromium.org>
Gerrit-CC: Keishi Hattori <kei...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 18:21:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Dominic Battre (Gerrit)

unread,
5:28 AM (10 hours ago) 5:28 AM
to Andrea Orru, AyeAye, Chromium LUCI CQ, Keishi Hattori, chromium-a...@chromium.org, extension...@chromium.org
Gerrit-Comment-Date: Thu, 02 Apr 2026 09:27:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
6:03 AM (9 hours ago) 6:03 AM
to Dominic Battre, Andrea Orru, AyeAye, Keishi Hattori, chromium-a...@chromium.org, extension...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[Extensions] Ensure iterator stability for EventListenerMap

By moving from flat_map to std::map, we can guarantee that iterators
remain stable in the presence of modifying the map.
Bug: b:497977591
Change-Id: I81bd322f69c8628d3d0b3cedcbaaf7e26a6a6964
Commit-Queue: Dominic Battre <bat...@chromium.org>
Reviewed-by: Andrea Orru <andre...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1609075}
Files:
  • M extensions/browser/event_listener_map.cc
  • M extensions/browser/event_listener_map.h
Change size: S
Delta: 2 files changed, 17 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Andrea Orru
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I81bd322f69c8628d3d0b3cedcbaaf7e26a6a6964
Gerrit-Change-Number: 7718823
Gerrit-PatchSet: 3
Gerrit-Owner: Dominic Battre <bat...@chromium.org>
Gerrit-Reviewer: Andrea Orru <andre...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Dominic Battre <bat...@chromium.org>
Gerrit-CC: Keishi Hattori <kei...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages