extensions: Remove ToolbarActionViewDelegateViews [chromium/src : main]

0 views
Skip to first unread message

Shuhei Takahashi (Gerrit)

unread,
Oct 17, 2025, 3:37:45 AMOct 17
to Shuhei Takahashi, Emilia Paz, Darryl James, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Darryl James and Emilia Paz

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Darryl James
  • Emilia Paz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I700351cef99c684ac2b7300660d0d3148e746b22
Gerrit-Change-Number: 7052763
Gerrit-PatchSet: 1
Gerrit-Owner: Shuhei Takahashi <n...@chromium.org>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Shuhei Takahashi <n...@chromium.org>
Gerrit-Attention: Darryl James <dlj...@chromium.org>
Gerrit-Attention: Emilia Paz <emil...@chromium.org>
Gerrit-Comment-Date: Fri, 17 Oct 2025 07:37:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Darryl James (Gerrit)

unread,
Oct 17, 2025, 1:14:50 PMOct 17
to Shuhei Takahashi, Emilia Paz, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Emilia Paz and Shuhei Takahashi

Darryl James voted and added 1 comment

Votes added by Darryl James

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Darryl James . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:
  • Emilia Paz
  • Shuhei Takahashi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I700351cef99c684ac2b7300660d0d3148e746b22
Gerrit-Change-Number: 7052763
Gerrit-PatchSet: 1
Gerrit-Owner: Shuhei Takahashi <n...@chromium.org>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Shuhei Takahashi <n...@chromium.org>
Gerrit-Attention: Shuhei Takahashi <n...@chromium.org>
Gerrit-Attention: Emilia Paz <emil...@chromium.org>
Gerrit-Comment-Date: Fri, 17 Oct 2025 17:14:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Emilia Paz (Gerrit)

unread,
Oct 19, 2025, 6:17:20 PMOct 19
to Shuhei Takahashi, Darryl James, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Shuhei Takahashi

Emilia Paz voted and added 1 comment

Votes added by Emilia Paz

Code-Review+1

1 comment

Patchset-level comments
Emilia Paz . resolved

nice!

Open in Gerrit

Related details

Attention is currently required from:
  • Shuhei Takahashi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I700351cef99c684ac2b7300660d0d3148e746b22
Gerrit-Change-Number: 7052763
Gerrit-PatchSet: 1
Gerrit-Owner: Shuhei Takahashi <n...@chromium.org>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Shuhei Takahashi <n...@chromium.org>
Gerrit-Attention: Shuhei Takahashi <n...@chromium.org>
Gerrit-Comment-Date: Sun, 19 Oct 2025 22:17:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Oct 27, 2025, 9:36:06 PM (8 days ago) Oct 27
to Shuhei Takahashi, Emilia Paz, Darryl James, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
extensions: Remove ToolbarActionViewDelegateViews

This is a part of the patch series to move stateful UI logic from
ExtensionActionViewController to ExtensionActionPlatformDelegate.

This patch removes ToolbarActionViewDelegateViews that is no longer
necessary. We should just use ToolbarActionViewDelegate instead.

This is a pure refactor. No functional changes are expected.
Bug: 448199168
Change-Id: I700351cef99c684ac2b7300660d0d3148e746b22
Reviewed-by: Emilia Paz <emil...@chromium.org>
Reviewed-by: Darryl James <dlj...@chromium.org>
Commit-Queue: Shuhei Takahashi <n...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1536385}
Files:
  • M chrome/browser/ui/extensions/extension_action_view_controller.h
  • M chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc
  • M chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.h
  • M chrome/browser/ui/views/extensions/extensions_menu_button.h
  • M chrome/browser/ui/views/toolbar/BUILD.gn
  • M chrome/browser/ui/views/toolbar/toolbar_action_view.h
  • D chrome/browser/ui/views/toolbar/toolbar_action_view_delegate_views.h
  • M chrome/browser/ui/webui_browser/webui_browser_extensions_container.cc
Change size: S
Delta: 8 files changed, 7 insertions(+), 38 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Darryl James, +1 by Emilia Paz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I700351cef99c684ac2b7300660d0d3148e746b22
Gerrit-Change-Number: 7052763
Gerrit-PatchSet: 8
Gerrit-Owner: Shuhei Takahashi <n...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Shuhei Takahashi <n...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages