Add kApiGlicAccessFromGoogleWebpage feature flag [chromium/src : main]

[Yuheng Huang (Gerrit)]

Attention needed from Tommy Nyquist

Yuheng Huang voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Tommy Nyquist

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I6fb34a8544abd0fc8343c092af9ca6c766b55279

Gerrit-Change-Number: 7718860

Gerrit-PatchSet: 7

Gerrit-Owner: Yuheng Huang <yuh...@chromium.org>

Gerrit-Reviewer: Tommy Nyquist <nyq...@chromium.org>

Gerrit-Reviewer: Yuheng Huang <yuh...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Tommy Nyquist <nyq...@chromium.org>

Gerrit-Comment-Date: Tue, 31 Mar 2026 22:21:03 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Emilia Paz (Gerrit)]

Attention needed from Tommy Nyquist and Yuheng Huang

Emilia Paz voted and added 1 comment

Votes added by Emilia Paz

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Emilia Paz . resolved

Have no context about the feature, but adding a flag lgtm. Thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Tommy Nyquist
• Yuheng Huang

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I6fb34a8544abd0fc8343c092af9ca6c766b55279

Gerrit-Change-Number: 7718860

Gerrit-PatchSet: 7

Gerrit-Owner: Yuheng Huang <yuh...@chromium.org>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Tommy Nyquist <nyq...@chromium.org>

Gerrit-Reviewer: Yuheng Huang <yuh...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Yuheng Huang <yuh...@chromium.org>

Gerrit-Attention: Tommy Nyquist <nyq...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Apr 2026 01:34:28 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Tommy Nyquist (Gerrit)]

Attention needed from Yuheng Huang

Tommy Nyquist added 2 comments

File chrome/browser/about_flags.cc

Line 4858, Patchset 7 (Latest): {"api-glic-access-from-google-webpage",

Tommy Nyquist . unresolved

Do we need this in about:flags?

File chrome/browser/flag-metadata.json

Line 488, Patchset 7 (Latest): "tomm...@chromium.org"

Tommy Nyquist . unresolved

Is this intentional?

Open in Gerrit

Related details

Attention is currently required from:

• Yuheng Huang

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I6fb34a8544abd0fc8343c092af9ca6c766b55279

Gerrit-Change-Number: 7718860

Gerrit-PatchSet: 7

Gerrit-Owner: Yuheng Huang <yuh...@chromium.org>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Tommy Nyquist <nyq...@chromium.org>

Gerrit-Reviewer: Yuheng Huang <yuh...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Yuheng Huang <yuh...@chromium.org>

Gerrit-Comment-Date: Thu, 02 Apr 2026 00:57:22 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Yuheng Huang (Gerrit)]

Attention needed from Tommy Nyquist

Yuheng Huang added 2 comments

File chrome/browser/about_flags.cc

Line 4858, Patchset 7: {"api-glic-access-from-google-webpage",

Tommy Nyquist . unresolved

Do we need this in about:flags?

Yuheng Huang

It's easier for non Chrome developer to test it with the flag. But I can remove it if you have concerns.

File chrome/browser/flag-metadata.json

Line 488, Patchset 7: "tomm...@chromium.org"

Tommy Nyquist . resolved

Is this intentional?

Yuheng Huang

Sorry, wrong Tommy:)

Open in Gerrit

Related details

Attention is currently required from:

• Tommy Nyquist

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I6fb34a8544abd0fc8343c092af9ca6c766b55279

Gerrit-Change-Number: 7718860

Gerrit-PatchSet: 8

Gerrit-Owner: Yuheng Huang <yuh...@chromium.org>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Tommy Nyquist <nyq...@chromium.org>

Gerrit-Reviewer: Yuheng Huang <yuh...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Tommy Nyquist <nyq...@chromium.org>

Gerrit-Comment-Date: Thu, 02 Apr 2026 15:50:45 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Tommy Nyquist <nyq...@chromium.org>

[Tommy Nyquist (Gerrit)]

Attention needed from Yuheng Huang

Tommy Nyquist added 1 comment

File chrome/browser/about_flags.cc

Line 4858, Patchset 7: {"api-glic-access-from-google-webpage",

Tommy Nyquist . unresolved

Do we need this in about:flags?

Yuheng Huang

It's easier for non Chrome developer to test it with the flag. But I can remove it if you have concerns.

Tommy Nyquist

Let's remove it for now.

Open in Gerrit

Related details

Attention is currently required from:

• Yuheng Huang

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I6fb34a8544abd0fc8343c092af9ca6c766b55279

Gerrit-Change-Number: 7718860

Gerrit-PatchSet: 8

Gerrit-Owner: Yuheng Huang <yuh...@chromium.org>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Tommy Nyquist <nyq...@chromium.org>

Gerrit-Reviewer: Yuheng Huang <yuh...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Yuheng Huang <yuh...@chromium.org>

Gerrit-Comment-Date: Thu, 02 Apr 2026 17:05:24 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Yuheng Huang <yuh...@chromium.org>

Comment-In-Reply-To: Tommy Nyquist <nyq...@chromium.org>