Tom Sepez (Gerrit)

unread,

Oct 29, 2025, 6:00:48 PM (3 days ago) Oct 29

to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-isola...@chromium.org, chikamu...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, navigation...@chromium.org

Attention needed from Daniel Cheng

Tom Sepez added 1 comment

File extensions/browser/api/web_request/web_request_info.cc

File-level comment, Patchset 4:

Tom Sepez . resolved

Please fix this WARNING reported by ClangTidy: warning: building this file or its dependencies failed; no diagnostics will be i...

warning: building this file or its dependencies failed; no diagnostics will be issued.

(Lint observed on `mac-clang-tidy-rel`, but not on `android-clang-tidy-rel` or `linux-clang-tidy-rel`)

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Oct 29, 2025, 6:54:07 PM (3 days ago) Oct 29

to Tom Sepez, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-isola...@chromium.org, chikamu...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, navigation...@chromium.org

Attention needed from Tom Sepez

Daniel Cheng voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Tom Sepez

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Tom Sepez (Gerrit)

unread,

Oct 29, 2025, 6:55:29 PM (3 days ago) Oct 29

to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-isola...@chromium.org, chikamu...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, navigation...@chromium.org

Tom Sepez added 1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Tom Sepez . resolved

Needs +OO

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Tom Sepez (Gerrit)

unread,

Oct 30, 2025, 2:58:18 PM (2 days ago) Oct 30

to Kartar Singh, Dominic Battre, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-isola...@chromium.org, chikamu...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, navigation...@chromium.org

Attention needed from Dominic Battre and Kartar Singh

Tom Sepez added 1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Tom Sepez . resolved

Or we could get OWNER stamps from Dominic and Kartar.

Open in Gerrit

Related details

Attention is currently required from:

Dominic Battre
Kartar Singh

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kartar Singh (Gerrit)

unread,

Oct 30, 2025, 3:10:54 PM (2 days ago) Oct 30

to Tom Sepez, Dominic Battre, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-isola...@chromium.org, chikamu...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, navigation...@chromium.org

Attention needed from Dominic Battre and Tom Sepez

Kartar Singh voted and added 1 comment

Votes added by Kartar Singh

Code-Review

+1

1 comment

Commit Message

Line 14, Patchset 7 (Latest):

Kartar Singh . unresolved

Do we want to link a tracking bug?

Open in Gerrit

Related details

Attention is currently required from:

Dominic Battre
Tom Sepez

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Tom Sepez (Gerrit)

unread,

Oct 30, 2025, 5:09:18 PM (2 days ago) Oct 30

to Kartar Singh, Dominic Battre, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-isola...@chromium.org, chikamu...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, navigation...@chromium.org

Attention needed from Dominic Battre

Tom Sepez added 1 comment

Commit Message

Line 14, Patchset 7:

Kartar Singh . resolved

Do we want to link a tracking bug?

Tom Sepez

Marked as resolved.

Open in Gerrit

Related details

Attention is currently required from:

Dominic Battre

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dominic Battre (Gerrit)

unread,

Oct 30, 2025, 5:13:00 PM (2 days ago) Oct 30

to Tom Sepez, Kartar Singh, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-isola...@chromium.org, chikamu...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, navigation...@chromium.org

Attention needed from Tom Sepez

Dominic Battre voted and added 1 comment

Votes added by Dominic Battre

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Dominic Battre . resolved

extensions/browser/api/web_request/web_request_info.cc RSLGTM

Open in Gerrit

Related details

Attention is currently required from:

Tom Sepez

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Tom Sepez (Gerrit)

unread,

Oct 30, 2025, 5:13:24 PM (2 days ago) Oct 30

to Dominic Battre, Kartar Singh, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-isola...@chromium.org, chikamu...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, navigation...@chromium.org

Tom Sepez voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Tom Sepez (Gerrit)

unread,

Oct 30, 2025, 5:27:49 PM (2 days ago) Oct 30

to Dominic Battre, Kartar Singh, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-isola...@chromium.org, chikamu...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, navigation...@chromium.org

satisfied_requirement

open

diffy

Tom Sepez (Gerrit)

unread,

Oct 30, 2025, 7:29:37 PM (2 days ago) Oct 30

to Dominic Battre, Kartar Singh, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-isola...@chromium.org, chikamu...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, navigation...@chromium.org

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Oct 30, 2025, 7:37:58 PM (2 days ago) Oct 30

to Tom Sepez, Dominic Battre, Kartar Singh, Daniel Cheng, chromium...@chromium.org, alexmo...@chromium.org, blink-isola...@chromium.org, chikamu...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, navigation...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Remove MSG_ROUTING_* constants from ipc_message.h

Use the constants.mojom replacements instead. This is part of the
effort to minimize and remove IPC messages.

-- remove unused enum *_MESSAGE_TYPE from ipc_message.h
-- remove unused message size constants from ipc_channel.h

Bug: 40621529

Change-Id: I52a898715997dcee0a6211083db26093654cd695

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7097498

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Reviewed-by: Kartar Singh <karta...@google.com>

Commit-Queue: Tom Sepez <tse...@chromium.org>

Reviewed-by: Dominic Battre <bat...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1538281}

Files:

M base/test/launcher/test_launcher_unittest.cc
M content/browser/renderer_host/agent_scheduling_group_host.cc
M extensions/browser/api/web_request/web_request_info.cc
M ipc/constants.mojom
M ipc/ipc_channel.cc
M ipc/ipc_channel.h
M ipc/ipc_message.h

Change size: M

Delta: 7 files changed, 10 insertions(+), 51 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Kartar Singh, +1 by Dominic Battre, +1 by Daniel Cheng

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Remove MSG_ROUTING_* constants from ipc_message.h [chromium/src : main]

Tom Sepez (Gerrit)

Tom Sepez added 1 comment

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted Code-Review+1

Related details

Tom Sepez (Gerrit)

Tom Sepez added 1 comment

Related details

Tom Sepez (Gerrit)

Tom Sepez added 1 comment

Related details

Kartar Singh (Gerrit)

Kartar Singh voted and added 1 comment

Votes added by Kartar Singh

1 comment

Related details

Tom Sepez (Gerrit)

Tom Sepez added 1 comment

Related details

Dominic Battre (Gerrit)

Dominic Battre voted and added 1 comment

Votes added by Dominic Battre

1 comment

Related details

Tom Sepez (Gerrit)

Tom Sepez voted Commit-Queue+2

Related details

Tom Sepez (Gerrit)

Tom Sepez (Gerrit)

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information