Reland "actions revamp: Add checks for profile during shutdown" [chromium/src : main]
0 views
Skip to first unread message
Masa Fujita (Gerrit)
Feb 11, 2026, 1:27:31 PM (9 days ago) Feb 11
to AyeAye, Chromium LUCI CQ, Linyu He, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Linyu He
Masa Fujita voted and added 1 comment![]( "Open in Gerrit")
Votes added by Masa Fujita
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Masa Fujita . resolved
Sorry reland - hopefully this doesn't break other tests
Related details
Attention is currently required from:
- Linyu He
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Linyu He (Gerrit)
Feb 11, 2026, 1:28:50 PM (9 days ago) Feb 11
to Masa Fujita, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Masa Fujita
Linyu He voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Masa Fujita
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Masa Fujita (Gerrit)
Feb 11, 2026, 1:32:02 PM (9 days ago) Feb 11
to Linyu He, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org
Masa Fujita added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 19, 2026, 9:02:59 PM (8 hours ago) Feb 19
to Masa Fujita, Linyu He, AyeAye, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: chrome/browser/ui/android/extensions/java/src/org/chromium/chrome/browser/ui/extensions/ExtensionsToolbarBridge.java
Insertions: 8, Deletions: 19.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Reland "actions revamp: Add checks for profile during shutdown"
This is a reland of commit b34f815f254c1b79d5bf692eec2506cb24a806e3
Original change's description:
> actions revamp: Add checks for profile during shutdown
>
> This CL adds temporary checks to `ExtensionsToolbarBridge` for whether
> profile is in the midst of shutdown to prevent tests from breaking in
> the next CL. This is needed because `ExtensionToolbarCoordinator` that
> owns `ExtensionsToolbarBridge `is not destroyed when profile is
> destroyed, as its lifecycle is tied with Activity. This is currently
> being worked on, and `ExtensionToolbarCoordinator` will be destroyed
> when profile is destroyed.
>
> Bug: 459079170
> Change-Id: Icf6f749d4302ec5375b7fa94faf37322180fb349
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7559093
> Commit-Queue: Masa Fujita <mas...@google.com>
> Reviewed-by: Linyu He <lin...@google.com>
> Cr-Commit-Position: refs/heads/main@{#1582306}
Bug: 459079170
Change-Id: Ib4b0ef90b3175d85ead262b3254ee1cb3797dece
Reviewed-by: Linyu He <lin...@google.com>
Commit-Queue: Masa Fujita <mas...@google.com>
Cr-Commit-Position: refs/heads/main@{#1587569}
Files:
- M chrome/browser/ui/android/extensions/java/src/org/chromium/chrome/browser/ui/extensions/ExtensionsToolbarBridge.java
Change size: S
Delta: 1 file changed, 38 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Linyu He
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages