Sophie Chang (Gerrit)

unread,

Oct 21, 2025, 9:10:42 PM (10 days ago) Oct 21

to Howard Chang, Devlin Cronin, Caitlin Fischer, Robert Kaplow, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Caitlin Fischer, Devlin Cronin, Howard Chang and Robert Kaplow

Sophie Chang added 1 comment

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Sophie Chang . resolved

taking myself off since this should be reviewed by a c/b/extensions reviewer

Open in Gerrit

Related details

Attention is currently required from:

Caitlin Fischer
Devlin Cronin
Howard Chang
Robert Kaplow

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Caitlin Fischer (Gerrit)

unread,

Oct 22, 2025, 9:26:22 AM (9 days ago) Oct 22

to Howard Chang, Devlin Cronin, Robert Kaplow, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Devlin Cronin, Howard Chang and Robert Kaplow

Caitlin Fischer added 1 comment

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Caitlin Fischer . resolved

Rob and I needn't both review this, and he's a UKM expert.

Open in Gerrit

Related details

Attention is currently required from:

Devlin Cronin
Howard Chang
Robert Kaplow

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Howard Chang (Gerrit)

unread,

Oct 23, 2025, 2:14:57 PM (8 days ago) Oct 23

to Devlin Cronin, Robert Kaplow, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Devlin Cronin and Robert Kaplow

Howard Chang added 1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Howard Chang . unresolved

Friendly ping on reviewing this cl @rdevlin...@chromium.org @rka...@chromium.org

Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Devlin Cronin
Robert Kaplow

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Robert Kaplow (Gerrit)

unread,

Oct 24, 2025, 11:00:30 AM (7 days ago) Oct 24

to Howard Chang, Devlin Cronin, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Devlin Cronin and Howard Chang

Robert Kaplow voted and added 3 comments

Votes added by Robert Kaplow

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Robert Kaplow . resolved

thanks for the patience here

File services/metrics/public/cpp/ukm_recorder.cc

Line 112, Patchset 15 (Latest):ukm::SourceId UkmRecorder::GetSourceIdForExtensionUrl(

Robert Kaplow . unresolved

is this in error, this is already exists

File tools/metrics/ukm/ukm.xml

Line 8988, Patchset 15 (Latest): Recorded the extension related action metrics that reflects the extension

Robert Kaplow . unresolved

can you expand here exactly how and when this is triggered

Open in Gerrit

Related details

Attention is currently required from:

Devlin Cronin
Howard Chang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Howard Chang (Gerrit)

unread,

Oct 24, 2025, 1:39:12 PM (7 days ago) Oct 24

to Robert Kaplow, Devlin Cronin, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Devlin Cronin and Robert Kaplow

Howard Chang added 3 comments

Patchset-level comments

File-level comment, Patchset 15:

Howard Chang . resolved

Friendly ping on reviewing this cl @rdevlin...@chromium.org @rka...@chromium.org
Thanks!

Howard Chang

Done

File services/metrics/public/cpp/ukm_recorder.cc

Line 112, Patchset 15:ukm::SourceId UkmRecorder::GetSourceIdForExtensionUrl(

Robert Kaplow . resolved

is this in error, this is already exists

Howard Chang

This is needed as the PassKey type is different than the one on line 103.

File tools/metrics/ukm/ukm.xml

Line 8988, Patchset 15: Recorded the extension related action metrics that reflects the extension

Robert Kaplow . resolved

can you expand here exactly how and when this is triggered

Howard Chang

Done

Open in Gerrit

Related details

Attention is currently required from:

Devlin Cronin
Robert Kaplow

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Robert Kaplow (Gerrit)

unread,

Oct 27, 2025, 10:28:17 AM (4 days ago) Oct 27

to Howard Chang, Devlin Cronin, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Devlin Cronin and Howard Chang

Robert Kaplow voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Devlin Cronin
Howard Chang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Emilia Paz (Gerrit)

unread,

Oct 29, 2025, 6:31:50 PM (2 days ago) Oct 29

to Howard Chang, Robert Kaplow, Devlin Cronin, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Devlin Cronin and Howard Chang

Emilia Paz added 4 comments

Patchset-level comments

File-level comment, Patchset 17 (Latest):

Emilia Paz . resolved

Thanks Howard! Implementation lgtm, would like to look at the design doc before approving since it's not clear to me why various actions with different entry points will be wrapped on the same ukm

Commit Message

Line 9, Patchset 17 (Latest):

Following https://chromium-review.googlesource.com/c/chromium/src/+/5731681 to add UKM for tracking extension pin/unpin action

Emilia Paz . unresolved

nit: break line

Line 12, Patchset 17 (Latest):b/451675689

Emilia Paz . unresolved

Please fix this WARNING reported by No short links in OSS: Do not use b/<number> in OSS code. Prefer crbug.com/<number> instead. While bugs...

Do not use b/<number> in OSS code. Prefer crbug.com/<number> instead. While bugs should be public by default, bugs that must remain internal may use b/<number>, ignoring this warning; see https://www.chromium.org/issue-tracking/googler-guidelines/.

File tools/metrics/ukm/ukm.xml

Line 8988, Patchset 17 (Latest):

    Recorded the extension related action metrics that reflects the extension
    usage for the Chrome Web Store. Action such as pinning/unpinning extensions,
    enable/disable extensions, initiate context menu (right click) on extensions
    and left click on extension icon from toolbar will be recorded.

Emilia Paz . unresolved

Is the same UKM going to be used for pin/unpin, enable/disabled, clicks? They are different actions, wouldn't that make the metrics different?

Open in Gerrit

Related details

Attention is currently required from:

Devlin Cronin
Howard Chang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Howard Chang (Gerrit)

unread,

Oct 29, 2025, 7:11:25 PM (2 days ago) Oct 29

to Emilia Paz, Robert Kaplow, Devlin Cronin, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Devlin Cronin and Emilia Paz

Howard Chang added 4 comments

Patchset-level comments

File-level comment, Patchset 17:

Emilia Paz . resolved

Thanks Howard! Implementation lgtm, would like to look at the design doc before approving since it's not clear to me why various actions with different entry points will be wrapped on the same ukm

Howard Chang

Thanks, I don't have a specific design doc but I already shared the approval doc with you.

Commit Message

Line 9, Patchset 17:

Following https://chromium-review.googlesource.com/c/chromium/src/+/5731681 to add UKM for tracking extension pin/unpin action

Emilia Paz . resolved

nit: break line

Howard Chang

Done

Line 12, Patchset 17:b/451675689

Emilia Paz . resolved

Please fix this WARNING reported by No short links in OSS: Do not use b/<number> in OSS code. Prefer crbug.com/<number> instead. While bugs...
Do not use b/<number> in OSS code. Prefer crbug.com/<number> instead. While bugs should be public by default, bugs that must remain internal may use b/<number>, ignoring this warning; see https://www.chromium.org/issue-tracking/googler-guidelines/.

Howard Chang

Done

File tools/metrics/ukm/ukm.xml

Line 8988, Patchset 17: Recorded the extension related action metrics that reflects the extension


    usage for the Chrome Web Store. Action such as pinning/unpinning extensions,
    enable/disable extensions, initiate context menu (right click) on extensions
    and left click on extension icon from toolbar will be recorded.

Emilia Paz . resolved

Is the same UKM going to be used for pin/unpin, enable/disabled, clicks? They are different actions, wouldn't that make the metrics different?

Howard Chang

There will be different metric values but all these actions are keyed by the item id so we can have an overall idea on how users interact with a specific extension.

Open in Gerrit

Related details

Attention is currently required from:

Devlin Cronin
Emilia Paz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Emilia Paz (Gerrit)

unread,

Oct 30, 2025, 11:51:15 AM (yesterday) Oct 30

to Howard Chang, Justin Lulejian, Devlin Cronin, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Devlin Cronin and Justin Lulejian

Emilia Paz added 1 comment

Patchset-level comments

File-level comment, Patchset 18 (Latest):

Emilia Paz . resolved

Adding Justin to take a look because I'm gardening today and falling behind on CL reviews :')

Open in Gerrit

Related details

Attention is currently required from:

Devlin Cronin
Justin Lulejian

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Howard Chang (Gerrit)

unread,

Oct 30, 2025, 1:20:02 PM (24 hours ago) Oct 30

to Robert Kaplow, Justin Lulejian, Devlin Cronin, Emilia Paz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Devlin Cronin, Justin Lulejian and Robert Kaplow

Howard Chang added 1 comment

Patchset-level comments

File-level comment, Patchset 18 (Latest):

Howard Chang . resolved

Hi Robert, I think you got removed from reviewer accidentally. Can I get your approval again? Thank you.

Open in Gerrit

Related details

Attention is currently required from:

Devlin Cronin
Justin Lulejian
Robert Kaplow

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Justin Lulejian (Gerrit)

unread,

Oct 30, 2025, 7:38:25 PM (17 hours ago) Oct 30

to Howard Chang, Robert Kaplow, Devlin Cronin, Emilia Paz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Howard Chang and Robert Kaplow

Justin Lulejian voted and added 4 comments

Votes added by Justin Lulejian

Code-Review

+1

4 comments

Patchset-level comments

File-level comment, Patchset 19 (Latest):

Justin Lulejian . resolved

lgtm enums.xml

Hi Howard! A couple small changes otherwise it's looking good.

File tools/metrics/histograms/metadata/extensions/enums.xml

Line 3332, Patchset 19 (Latest): <int value="1" label="Extension UnPinned"/>

Justin Lulejian . unresolved

```suggestion
  <int value="1" label="Extension Unpinned"/>
```

File tools/metrics/ukm/ukm.xml

Line 8986, Patchset 19 (Latest): <owner>howa...@google.com</owner>

Justin Lulejian . unresolved

Is there a team group we could add as an owner too?

Line 8988, Patchset 19 (Latest): Recorded the extension related action metrics that reflects the extension


    usage for the Chrome Web Store. Action such as pinning/unpinning extensions,
    enable/disable extensions, initiate context menu (right click) on extensions
    and left click on extension icon from toolbar will be recorded.

Justin Lulejian . unresolved

nit: perhaps slightly more concise wording? (I don't think clicks will change, but in the future perhaps taps so best to leave that part out)?

```suggestion
    Records user actions related to an extension, providing usage metrics for the
    Chrome Web Store. Tracked actions include pinning, unpinning, enabling,
    disabling, context menu access, and toolbar icon clicks.
```

Open in Gerrit

Related details

Attention is currently required from:

Howard Chang
Robert Kaplow

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Robert Kaplow (Gerrit)

unread,

10:53 AM (2 hours ago) 10:53 AM

to Howard Chang, Justin Lulejian, Devlin Cronin, Emilia Paz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Howard Chang

Robert Kaplow voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Howard Chang

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Justin Lulejian (Gerrit)

unread,

11:03 AM (2 hours ago) 11:03 AM

to Howard Chang, Robert Kaplow, Devlin Cronin, Emilia Paz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Emilia Paz and Howard Chang

Justin Lulejian added 1 comment

Commit Message

Line 7, Patchset 19 (Latest):Add pin/unpin ukm for cws

Justin Lulejian . unresolved

```suggestion
Add extension pin/unpin ukm for cws
```

Open in Gerrit

Related details

Attention is currently required from:

Emilia Paz
Howard Chang

satisfied_requirement

unsatisfied_requirement

open

diffy

Howard Chang (Gerrit)

unread,

12:39 PM (26 minutes ago) 12:39 PM

to Robert Kaplow, Justin Lulejian, Devlin Cronin, Emilia Paz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Emilia Paz, Justin Lulejian and Robert Kaplow

Howard Chang voted and added 4 comments

Votes added by Howard Chang

Commit-Queue

+1

4 comments

Commit Message

Line 7, Patchset 19:Add pin/unpin ukm for cws

Justin Lulejian . resolved

```suggestion
Add extension pin/unpin ukm for cws
```

Howard Chang

Done

File tools/metrics/histograms/metadata/extensions/enums.xml

Line 3332, Patchset 19: <int value="1" label="Extension UnPinned"/>

Justin Lulejian . resolved

```suggestion
  <int value="1" label="Extension Unpinned"/>
```

Howard Chang

Done

File tools/metrics/ukm/ukm.xml

Line 8986, Patchset 19: <owner>howa...@google.com</owner>

Justin Lulejian . resolved

Is there a team group we could add as an owner too?

Howard Chang

added websto...@google.com as owner

Line 8988, Patchset 19: Recorded the extension related action metrics that reflects the extension


    usage for the Chrome Web Store. Action such as pinning/unpinning extensions,
    enable/disable extensions, initiate context menu (right click) on extensions
    and left click on extension icon from toolbar will be recorded.

Justin Lulejian . resolved

nit: perhaps slightly more concise wording? (I don't think clicks will change, but in the future perhaps taps so best to leave that part out)?
```suggestion
    Records user actions related to an extension, providing usage metrics for the
    Chrome Web Store. Tracked actions include pinning, unpinning, enabling,
    disabling, context menu access, and toolbar icon clicks.
```

Howard Chang

Done

Open in Gerrit

Related details

Attention is currently required from:

Emilia Paz
Justin Lulejian
Robert Kaplow

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Add pin/unpin ukm for cws [chromium/src : main]

Sophie Chang (Gerrit)

Sophie Chang added 1 comment

Related details

Caitlin Fischer (Gerrit)

Caitlin Fischer added 1 comment

Related details

Howard Chang (Gerrit)

Howard Chang added 1 comment

Related details

Robert Kaplow (Gerrit)

Robert Kaplow voted and added 3 comments

Votes added by Robert Kaplow

3 comments

Related details

Howard Chang (Gerrit)

Howard Chang added 3 comments

Related details

Robert Kaplow (Gerrit)

Robert Kaplow voted Code-Review+1

Related details

Emilia Paz (Gerrit)

Emilia Paz added 4 comments

Related details

Howard Chang (Gerrit)

Howard Chang added 4 comments

Related details

Emilia Paz (Gerrit)

Emilia Paz added 1 comment

Related details

Howard Chang (Gerrit)

Howard Chang added 1 comment

Related details

Justin Lulejian (Gerrit)

Justin Lulejian voted and added 4 comments

Votes added by Justin Lulejian

4 comments

Related details

Robert Kaplow (Gerrit)

Robert Kaplow voted Code-Review+1

Related details

Justin Lulejian (Gerrit)

Justin Lulejian added 1 comment

Related details

Howard Chang (Gerrit)

Howard Chang voted and added 4 comments

Votes added by Howard Chang

4 comments

Related details