Issue 1005102 in chromium: ExtensionPageCaptureApiTest.PublicSessionRequestAllowed failing on chromium.chromiumos/linux-chromeos-rel

[sidereal via monorail]

Updates:
Cc: tba...@chromium.org extensi...@chromium.org
Components: Platform>Extensions
Owner: isa...@chromium.org

Comment #1 on issue 1005102 by side...@google.com: ExtensionPageCaptureApiTest.PublicSessionRequestAllowed failing on chromium.chromiumos/linux-chromeos-rel
https://bugs.chromium.org/p/chromium/issues/detail?id=1005102#c1

(No comment was entered for this change.)

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[mastiz via monorail]

Updates:
Cc: isa...@chromium.org
Owner: laz...@chromium.org
Status: Assigned

Comment #2 on issue 1005102 by mas...@chromium.org: ExtensionPageCaptureApiTest.PublicSessionRequestAllowed failing on chromium.chromiumos/linux-chromeos-rel
https://bugs.chromium.org/p/chromium/issues/detail?id=1005102#c2

Over to lazyboy@ in case it rings a bell, and due to (the old) https://chromium-review.googlesource.com/604932

The test expects that the temporary file is deleted. However, the relevant waiting mechanism seems to be:
content::RunAllPendingInMessageLoop(content::BrowserThread::IO);

From https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/page_capture/page_capture_apitest.cc?l=123&rcl=8632023ae672e44495a5903c10c977b1eea2567e

I don't think that guarantees the completion of the task, does it?

One option I can think of is to create the task runner in the constructor, and expose it for tests to wait. I hope there's a better option to wait, though.

[treib via monorail]

Updates:
Labels: -Sheriff-Chromium

Comment #3 on issue 1005102 by tr...@chromium.org: ExtensionPageCaptureApiTest.PublicSessionRequestAllowed failing on chromium.chromiumos/linux-chromeos-rel
https://bugs.chromium.org/p/chromium/issues/detail?id=1005102#c3

(No comment was entered for this change.)

[dbertoni via monorail]

Updates:
Mergedinto: 942499
Status: Duplicate

Comment #4 on issue 1005102 by dber...@chromium.org: ExtensionPageCaptureApiTest.PublicSessionRequestAllowed failing on chromium.chromiumos/linux-chromeos-rel
https://bugs.chromium.org/p/chromium/issues/detail?id=1005102#c4

These flakes were fixed in a general cleanup of the ExtensionPageCaptureApiTest tests.