Review request for adding a cryptotokenPrivate method

[Martin Kreichgauer]

Hi Extensions API reviewers,

I'm adding a method to the cryptotokenPrivate extension API that shows a permission prompt for U2F API requests (similar to the existing canAppIdGetAttestation()). karandeepb@ pointed out to me on the CL that it's a medium-size change and requires API review. Hence, I'd like to formally request permission to add the following method to cryptotokenPrivate: 

  dictionary U2fApiRequestOptions {
    DOMString appId;
    DOMString origin;
    long tabId;
  };

  // Checks whether a site may issue a U2F register or sign request. Chrome
  // displays a permission prompt to determine a result.
  static void canMakeU2fApiRequest(U2fApiRequestOptions options,
                                   BooleanCallback callback);

More context on what the prompt looks like and why we're adding it here. (The prompt will go through the regular Chrome feature launch process.)

Thanks,
Martin

[Martin Kreichgauer]

Friendly ping

[Devlin Cronin]

Thanks for reaching out!

Given this is a reasonably small change in a very restricted API that's only used by component extensions, and will also go through Chrome launch review, this LGTM.

Cheers,

- Devlin

--
You received this message because you are subscribed to the Google Groups "extension-api-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email to extension-api-re...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/extension-api-reviews/CAB%3DfcEa1i04655PYyDmUgJMH_r7dqBejas4RoGCWUJUQr4i62w%40mail.gmail.com.