Updating passwords_private.idl

[Viktor Semeniuk]

Hi, I would like to receive an early feedback on the proposed changes to the passwords_private.idl. The current state of the API is too convoluted and bug prone which makes introducing new features extremely difficult. I would like to fix this.  

Quick overview of the proposed changes:

• Unify Passwords and Insecure credentials into a single structure. This will allow using the same API to edit/remove passwords from settings/passwords and settings/password/check.
• Move deduplicating of password entries from JS to C++. 
• Add REUSED as possible CompromiseType so that we're future proof

Thanks in advance! 

[Viktor Semeniuk]

Friendly ping. 

[Devlin Cronin]

Hi Viktor!

Sorry for the delay!  This didn't have an associated bug with the Needs-API-Review label, and so slipped from the radar.  (I'll update the proposal doc to call out that a bug is useful for tracking purposes.)

Overall, the direction here looks good - I like the unification of the credential type and simplification of the API surface.  Since this is a private API, there shouldn't be any backwards compatibility concerns.  I've dropped a few additional comments in the doc.

Cheers,

- Devlin

--
You received this message because you are subscribed to the Google Groups "extension-api-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email to extension-api-re...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/extension-api-reviews/CAN6SAFm%3DORVM5F2H5fGQy3exuxh0KgmsRH-eF5Q3PgeNM2cD4w%40mail.gmail.com.