Re: Nested flags

[Jason Chase]

Hi Olivier,

(+experimentation-dev for posterity)

Yes, you've run into an existing bug in the support for OT-linked runtime enabled features. On your CL, I see you've commented out the |depends_on| relationship as a workaround.

The comment mentions crbug.com/1000486. I think you might actually have run into a different bug: crbug.com/954679#c11. The first bug results in a compile error (in some scenarios). From your description, it sounds like it didn't work when running the test (i.e. not a compile error)?

Either way, there's bug(s) we should fix. I just wanted to make sure I understood your scenario, and whether we should add detail to one of the bugs.

Thanks,

Jason

On Tue, Oct 20, 2020 at 8:49 PM Olivier Yiptong <oyip...@google.com> wrote:

Hi Jason,

I have an issue with a nested flag situation.

I'm building out a new feature under a flag. That feature is dependent on another one that's under Origin Trial.

Here's a sample CL:

In this file, I declare the runtime enabled features and its dependency: https://chromium-review.googlesource.com/c/chromium/src/+/2488602/4/third_party/blink/renderer/platform/runtime_enabled_features.json5

In this IDL, I declare the method and gate it: https://chromium-review.googlesource.com/c/chromium/src/+/2488602/4/third_party/blink/renderer/modules/font_access/font_manager.idl

I set the flags for the test here: https://chromium-review.googlesource.com/c/chromium/src/+/2488602/4/third_party/blink/web_tests/VirtualTestSuites

That said, what I get is that the feature does not get enabled. If I remove the gating or I switch it to the top-level flag, everything works fine.

What's the best way to approach this?

Thanks,

--

Olivier

+1 (415) 755-0454