bind-gen: Reimplement V8DOMConfiguration as IDLMemberInstaller [chromium/src : master]

Ian Clelland (Gerrit)

unread,

Oct 9, 2020, 3:04:28 PM10/9/20

to experimen...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, Yuki Shiino, Kentaro Hara, Hitoshi Yoshida

Yuki Shiino has uploaded this change for review.

View Change

bind-gen: Reimplement V8DOMConfiguration as IDLMemberInstaller

Implements the same features of V8DOMConfiguration as a new
class IDLMemberInstaller with refactoring and clean-up.

V8DOMConfiguration remains unchanged in order to make the old
bindings generator workable as much as possible.

IDLMemberInstaller gets rid of old and unnecessary burden, and
the APK size will be reduced by 32 KBytes.

IDL constants of origin trial features are removed because
1) It's not used in production, it's used only in testing.
2) IDL constants themselves are (a sort of) obsolete.
Overall, it's unlikely that we'll need IDL constants of origin
trial features.

Bug: 839389
Change-Id: I7bd876c779542c4889edbec6d9f6d4150e0bfec3
---
M third_party/blink/renderer/bindings/scripts/bind_gen/interface.py
M third_party/blink/renderer/core/testing/origin_trials_test.idl
M third_party/blink/renderer/core/testing/origin_trials_test_partial.idl
M third_party/blink/renderer/platform/BUILD.gn
A third_party/blink/renderer/platform/bindings/idl_member_installer.cc
A third_party/blink/renderer/platform/bindings/idl_member_installer.h
M third_party/blink/web_tests/http/tests/origin_trials/resources/origintrials-worker.js
M third_party/blink/web_tests/http/tests/origin_trials/resources/origintrials.js
8 files changed, 852 insertions(+), 235 deletions(-)

To view, visit change 2448570. To unsubscribe, or for help writing mail filters, visit settings.

Ian Clelland (Gerrit)

unread,

Oct 9, 2020, 3:04:35 PM10/9/20

to Yuki Shiino, experimen...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, Kentaro Hara, Hitoshi Yoshida, chromium...@chromium.org

View Change

1 comment:

Patchset:
- Patch Set #7:
  +experimentation-dev as CC/FYI

To view, visit change 2448570. To unsubscribe, or for help writing mail filters, visit settings.

Yuki Shiino (Gerrit)

unread,

Oct 11, 2020, 2:59:35 PM10/11/20

to Yuki Shiino, Kentaro Hara, Ian Clelland, Hitoshi Yoshida, experimen...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, chromium...@chromium.org

Yuki Shiino uploaded patch set #11 to this change.

View Change

bind-gen: Reimplement V8DOMConfiguration as IDLMemberInstaller

Implements the same features of V8DOMConfiguration as a new
class IDLMemberInstaller with refactoring and clean-up.

V8DOMConfiguration remains unchanged in order to make the old
bindings generator workable as much as possible.

IDLMemberInstaller gets rid of old and unnecessary burden, and

the APK size will be reduced by 30 KBytes.



IDL constants of origin trial features are removed because
1) It's not used in production, it's used only in testing.
2) IDL constants themselves are (a sort of) obsolete.
Overall, it's unlikely that we'll need IDL constants of origin
trial features.

Bug: 839389
Change-Id: I7bd876c779542c4889edbec6d9f6d4150e0bfec3
---

M third_party/blink/renderer/bindings/scripts/bind_gen/callback_interface.py


M third_party/blink/renderer/bindings/scripts/bind_gen/interface.py
M third_party/blink/renderer/core/testing/origin_trials_test.idl
M third_party/blink/renderer/core/testing/origin_trials_test_partial.idl
M third_party/blink/renderer/platform/BUILD.gn
A third_party/blink/renderer/platform/bindings/idl_member_installer.cc
A third_party/blink/renderer/platform/bindings/idl_member_installer.h
M third_party/blink/web_tests/http/tests/origin_trials/resources/origintrials-worker.js
M third_party/blink/web_tests/http/tests/origin_trials/resources/origintrials.js

9 files changed, 864 insertions(+), 236 deletions(-)

To view, visit change 2448570. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Oct 13, 2020, 3:46:40 AM10/13/20

to Yuki Shiino, experimen...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, Ian Clelland, Kentaro Hara, Hitoshi Yoshida, chromium...@chromium.org

CQ is trying the patch.

Note: The patchset #12 "." sent to CQ was uploaded after this CL was CR+1-ed.
Reviewer, please verify there is nothing unexpected https://chromium-review.googlesource.com/c/2448570/12

Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/2448570/12

Bot data: {"action": "start", "triggered_at": "2020-10-13T07:46:31.0Z", "revision": "cd3dc273818b567cf40c0bb8cb861ff3fe7e45d0"}

View Change

To view, visit change 2448570. To unsubscribe, or for help writing mail filters, visit settings.

Yuki Shiino (Gerrit)

unread,

Oct 13, 2020, 3:46:49 AM10/13/20

to Yuki Shiino, experimen...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, Ian Clelland, Kentaro Hara, Hitoshi Yoshida, chromium...@chromium.org

Patch set 12:Commit-Queue +2

View Change

To view, visit change 2448570. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Oct 13, 2020, 3:50:31 AM10/13/20

to Yuki Shiino, experimen...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, Ian Clelland, Kentaro Hara, Hitoshi Yoshida, chromium...@chromium.org

Commit Bot submitted this change.

View Change

Approvals:
  Hitoshi Yoshida: Looks good to me
  Kentaro Hara: Looks good to me
  Ian Clelland: Looks good to me
  Yuki Shiino: Commit

bind-gen: Reimplement V8DOMConfiguration as IDLMemberInstaller

Implements the same features of V8DOMConfiguration as a new
class IDLMemberInstaller with refactoring and clean-up.

V8DOMConfiguration remains unchanged in order to make the old
bindings generator workable as much as possible.

IDLMemberInstaller gets rid of old and unnecessary burden, and
the APK size will be reduced by 30 KBytes.

IDL constants of origin trial features are removed because
1) It's not used in production, it's used only in testing.
2) IDL constants themselves are (a sort of) obsolete.
Overall, it's unlikely that we'll need IDL constants of origin
trial features.

Bug: 839389
Change-Id: I7bd876c779542c4889edbec6d9f6d4150e0bfec3

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448570
Commit-Queue: Yuki Shiino <yukis...@chromium.org>
Reviewed-by: Hitoshi Yoshida <pe...@chromium.org>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Reviewed-by: Ian Clelland <icle...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816470}


---
M third_party/blink/renderer/bindings/scripts/bind_gen/callback_interface.py
M third_party/blink/renderer/bindings/scripts/bind_gen/interface.py
M third_party/blink/renderer/core/testing/origin_trials_test.idl
M third_party/blink/renderer/core/testing/origin_trials_test_partial.idl
M third_party/blink/renderer/platform/BUILD.gn
A third_party/blink/renderer/platform/bindings/idl_member_installer.cc
A third_party/blink/renderer/platform/bindings/idl_member_installer.h
M third_party/blink/web_tests/http/tests/origin_trials/resources/origintrials-worker.js
M third_party/blink/web_tests/http/tests/origin_trials/resources/origintrials.js

9 files changed, 869 insertions(+), 236 deletions(-)

To view, visit change 2448570. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward