Introducing OS_MAC and OS_APPLE

27 views
Skip to first unread message

Avi Drissman

unread,
Jul 25, 2020, 10:49:18 AM7/25/20
to Chromium-dev, Chromium Embedders
There has been a problem with the OS_MACOSX #define for a while. OS_MACOSX means "Mac or iOS", which is inherently confusing. Given that Apple moved away from the "Mac OS X" appellation a while ago and is now moving away from the 10.x version number, the Mac team is happy to announce that we are migrating away from the OS_MACOSX macro.

It is replaced by two macros: OS_MAC, which is defined only on the Mac (not iOS), and OS_APPLE, which is a direct replacement for OS_MACOSX as it is defined for both Mac and iOS.

I will be migrating the existing macros over the next few days.

Avi

Lei Zhang

unread,
Jul 27, 2020, 3:25:58 PM7/27/20
to Avi Drissman, Chromium-dev, Chromium Embedders
Is there a tracking bug for this work? What's the expectation for
related projects like PDFium and Crashpad?
> --
> --
> Chromium Developers mailing list: chromi...@chromium.org
> View archives, change email options, or unsubscribe:
> http://groups.google.com/a/chromium.org/group/chromium-dev
> ---
> You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
> To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CACWgwAYTH0NJ8tNOALh3Wfx4DE6%3Dc6XEeKvYoAKTr5NBc%2BVrCg%40mail.gmail.com.

Avi Drissman

unread,
Jul 27, 2020, 3:32:03 PM7/27/20
to Lei Zhang, Chromium-dev, Chromium Embedders
https://crbug.com/1105907

It's a find-and-replace that I'm planning on committing in the next few days. Does PDFium rely directly on build/build_config.h?

Lei Zhang

unread,
Jul 27, 2020, 3:36:35 PM7/27/20
to Avi Drissman, Chromium-dev, Chromium Embedders
Standalone PDFium pulls in //build via DEPS. I can roll DEPS there to
make the new macros available. PDFium in Chromium uses Chromium's
build/build_config.h, so we should update PDFium around the same time.

Avi Drissman

unread,
Jul 27, 2020, 3:42:32 PM7/27/20
to Lei Zhang, Chromium-dev, Chromium Embedders
The old macros are still there while we move to the new ones; any assistance migrating would be appreciated.

Avi

Lei Zhang

unread,
Jul 27, 2020, 5:31:09 PM7/27/20
to Avi Drissman, Chromium-dev, Chromium Embedders
I filed https://crbug.com/pdfium/1570 for this.

Avi Drissman

unread,
Aug 1, 2020, 1:48:34 PM8/1/20
to Chromium-dev, Chromium Embedders
This work is complete. Thank you for your assistance, understanding, and cooperation.

Avi
Reply all
Reply to author
Forward
0 new messages