PSA: Removing content::kAboutSrcDocURL - please use GURL::IsAboutSrcdoc() for comparisons

12 views
Skip to first unread message

Łukasz Anforowicz

unread,
Jun 18, 2019, 7:30:46 PM6/18/19
to Chromium Embedders
Hello //content embedders!

I just wanted to drop a note that https://crrev.com/c/1659195 removes content::kAboutSrcDocURL.  Going forward, please use |url.IsAboutSrcdoc()| instead of |url == GURL(content::kAboutSrcDocURL)| (similarily for about:blank - please use the IsAboutBlank method).  Unlike the constant-based / strict-equality comparisons, the GURL methods correctly account for things like about:blank#ref-tag.

Thanks,

Lukasz
Reply all
Reply to author
Forward
0 new messages