Issue 959500 in chromium: CHECK failure: PrimaryDirectionOf(*position.GetPosition().ComputeContainerNode()) == PrimaryDir

[ClusterFuzz via monorail]

Updates:
Components: Blink>Editing
Labels: Test-Predator-Auto-Components

Comment #1 on issue 959500 by ClusterFuzz: CHECK failure: PrimaryDirectionOf(*position.GetPosition().ComputeContainerNode()) == PrimaryDir
https://bugs.chromium.org/p/chromium/issues/detail?id=959500#c1

Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.

--
You received this message because:
1. A rule CC'd you on the issue
2. You are auto-CC'd on all issues in component Blink>Editing

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[ClusterFuzz via monorail]

Updates:
Labels: Test-Predator-Auto-Owner
Owner: xiaoc...@chromium.org
Status: Assigned

Comment #2 on issue 959500 by ClusterFuzz: CHECK failure: PrimaryDirectionOf(*position.GetPosition().ComputeContainerNode()) == PrimaryDir
https://bugs.chromium.org/p/chromium/issues/detail?id=959500#c2

Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/7aeceb41754fa0ff6d577a72463bbe5a6a978b8e (Fix regression that ComputeInlineBoxPosition no longer enters inline blocks).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

[xiaochengh via monorail]

Comment #3 on issue 959500 by xiaoc...@chromium.org: CHECK failure: PrimaryDirectionOf(*position.GetPosition().ComputeContainerNode()) == PrimaryDir
https://bugs.chromium.org/p/chromium/issues/detail?id=959500#c3

The DCHECK will no longer make sense after we remove visual left/right caret movement.

I'll remove it after crrev.com/c/1593632 lands.

[bugdroid via monorail]

Comment #4 on issue 959500 by bugdroid: CHECK failure: PrimaryDirectionOf(*position.GetPosition().ComputeContainerNode()) == PrimaryDir
https://bugs.chromium.org/p/chromium/issues/detail?id=959500#c4

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/e225021df17107cd2ec3344e2ee268d5c66e7fc1

commit e225021df17107cd2ec3344e2ee268d5c66e7fc1
Author: Xiaocheng Hu <xiaoc...@chromium.org>
Date: Tue May 14 16:27:18 2019

[Editing] Remove some obsolete DCHECKs

The DCHECKs were added to verify correctness in visual left/right
caret movements. Now that the visual movements are removed, the
DCHECKs are stale, and hitting them doesn't mean any harm. So this
patch removes the DCHECKs.

Bug: 959500
Change-Id: I3bf975ef89b53f700c3957b64fa898df03d7cf5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611138
Auto-Submit: Xiaocheng Hu <xiaoc...@chromium.org>
Reviewed-by: Yoshifumi Inoue <yo...@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaoc...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659527}

[modify] https://crrev.com/e225021df17107cd2ec3344e2ee268d5c66e7fc1/third_party/blink/renderer/core/editing/local_caret_rect.cc

[xiaochengh via monorail]

Updates:
Status: Fixed

Comment #5 on issue 959500 by xiaoc...@chromium.org: CHECK failure: PrimaryDirectionOf(*position.GetPosition().ComputeContainerNode()) == PrimaryDir
https://bugs.chromium.org/p/chromium/issues/detail?id=959500#c5

(No comment was entered for this change.)