Issue 870555 in chromium: Hit testing should not handle editing features

[xiaochengh via monorail]

Updates:
Blocking: 950728

Comment #2 on issue 870555 by xiaoc...@chromium.org: Hit testing should not handle editing features
https://bugs.chromium.org/p/chromium/issues/detail?id=870555#c2

This blocks hit test based up and down caret movements, as we don't want to move to horizontal boundary when crossing block boundaries

--
You received this message because:
1. A rule CC'd you on the issue
2. You are auto-CC'd on all issues in component Blink>Editing>Selection

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[bugdroid via monorail]

Comment #3 on issue 870555 by bugdroid: Hit testing should not handle editing features
https://bugs.chromium.org/p/chromium/issues/detail?id=870555#c3

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/4c75ec3e66a16ac1a239857c2c1df714f3b52a3d

commit 4c75ec3e66a16ac1a239857c2c1df714f3b52a3d
Author: Xiaocheng Hu <xiaoc...@chromium.org>
Date: Wed May 08 07:18:10 2019

[Editing] Add a new web test for up/down caret movement

This patch adds a new web test for up/down caret movement crossing blocks
with large margin and padding. This is preparation for implementing hit
test based up/down caret movements.

Bug: 870555
Change-Id: If35dc36cede007a7b2da58a03c24b7008a6364fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600952
Auto-Submit: Xiaocheng Hu <xiaoc...@chromium.org>
Commit-Queue: Yoshifumi Inoue <yo...@chromium.org>
Reviewed-by: Yoshifumi Inoue <yo...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657623}

[add] https://crrev.com/4c75ec3e66a16ac1a239857c2c1df714f3b52a3d/third_party/blink/web_tests/editing/selection/modify_move/move_line_block_padding.html

[xiaochengh via monorail]

Updates:
Blocking: -950728

Comment #4 on issue 870555 by xiaoc...@chromium.org: Hit testing should not handle editing features
https://bugs.chromium.org/p/chromium/issues/detail?id=870555#c4

It seems very hard to pull editing behavior handling from hit test to call sites.

The biggest blocker is multicol, which does its custom ancestor-to-local point conversion in PositionForPoint(). It's very hard to recover the same conversion at call site, unless we make PositionForPoint() return a lot more of auxiliary information besides the result Position.

Anyway, I found a way not to mess with editing behavior in hit-test based up and down.