Issue 946323 in chromium: editing/caret/caret-painting-low-dpi.html failing on Mac10.13 Tests (dbg)

[pkasting via monorail]

Updates:
Components: Blink>Editing>Selection
Labels: OS-Mac

Comment #1 on issue 946323 by pkas...@chromium.org: editing/caret/caret-painting-low-dpi.html failing on Mac10.13 Tests (dbg)
https://bugs.chromium.org/p/chromium/issues/detail?id=946323#c1

Image diff looks like there was a fractional change in horizontal scaling?:

https://test-results.appspot.com/data/layout_results/Mac10_13_Tests__dbg_/results/layout-test-results/editing/caret/caret-painting-low-dpi-diff.png

--
You received this message because:
1. A rule CC'd you on the issue
2. You are auto-CC'd on all issues in component Blink>Editing>Selection

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[bcwhite via monorail]

Updates:
Components: Internals>Skia
Owner: brian...@chromium.org

Comment #2 on issue 946323 by bcw...@chromium.org: editing/caret/caret-painting-low-dpi.html failing on Mac10.13 Tests (dbg)
https://bugs.chromium.org/p/chromium/issues/detail?id=946323#c2

I was able to find it back to 10208:
https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/10208

This bot been failing constantly since 10148 (2019-03-20 11:40 AM EDT) and was flaky before that.

Looking at the diff from b1b50a7b2939aeb51d1abc94ba99d3b996d7f3e3
to 3271f2035ade8c1cb6ed2e2897a01e45667667b0...

This would be my guess:
https://chromium.googlesource.com/chromium/src/+/a58972ea9783d6571f624cf58e03c168e66f4899
"Roll src/third_party/skia b4d9c43d1ba6..03fa5d408359"

CL says:
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

But there's no CC in the commit message. There's a TBR, though, so assigning it there.

[brianosman via monorail]

Updates:
Cc: bsal...@google.com

Comment #3 on issue 946323 by brian...@google.com: editing/caret/caret-painting-low-dpi.html failing on Mac10.13 Tests (dbg)
https://bugs.chromium.org/p/chromium/issues/detail?id=946323#c3

Any chance it happened earlier? All but one of the CLs in that Skia roll were changes to testing or infrastructure code (that won't affect Chrome at all).

bsalomon@, any chance your TexStorage change caused rendering diffs? Doesn't seem like it should - it's just altering which API we use to get (otherwise identical) data to the GPU, right?

[bsalomon via monorail]

Comment #4 on issue 946323 by bsal...@google.com: editing/caret/caret-painting-low-dpi.html failing on Mac10.13 Tests (dbg)
https://bugs.chromium.org/p/chromium/issues/detail?id=946323#c4

In theory it shouldn't change anything but with GL drivers, who knows. In any event when I use the "Animated View" here on editing/caret/caret-painting-low-dpi.html, the image difference is imperceptible:

https://test-results.appspot.com/data/layout_results/Mac10_13_Tests__dbg_/10214/webkit_layout_tests/layout-test-results/results.html

I'd say we just rebaseline the image and move on.

[bugdroid via monorail]

Comment #5 on issue 946323 by bugdroid: editing/caret/caret-painting-low-dpi.html failing on Mac10.13 Tests (dbg)
https://bugs.chromium.org/p/chromium/issues/detail?id=946323#c5

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/bdc55e891c203cb9b3b8d8bbb7dc1470f85b6b5a

commit bdc55e891c203cb9b3b8d8bbb7dc1470f85b6b5a
Author: Ella Ge <eir...@chromium.org>
Date: Wed Mar 27 16:41:02 2019

Disable editing/caret/caret-painting-low-dpi.html

Flaky on mac

Tbr: brian...@chromium.org
Bug: 946323
Change-Id: I227f55a682480ee0bfb431211d3a52ee31035d6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541938
Reviewed-by: Ella Ge <eir...@chromium.org>
Commit-Queue: Ella Ge <eir...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644847}
[modify] https://crrev.com/bdc55e891c203cb9b3b8d8bbb7dc1470f85b6b5a/third_party/blink/web_tests/TestExpectations

[eirage via monorail]

Updates:
Labels: -Sheriff-Chromium
Status: Assigned

Comment #6 on issue 946323 by eir...@chromium.org: editing/caret/caret-painting-low-dpi.html failing on Mac10.13 Tests (dbg)
https://bugs.chromium.org/p/chromium/issues/detail?id=946323#c6

Test disabled. removing sheriff label

[eae via monorail]

Updates:
Labels: -Pri-2 Pri-3
Owner: ----
Status: Available

Comment #7 on issue 946323 by e...@chromium.org: editing/caret/caret-painting-low-dpi.html failing on Mac10.13 Tests (dbg)
https://bugs.chromium.org/p/chromium/issues/detail?id=946323#c7

(No comment was entered for this change.)

[bugdroid via monorail]

Comment #8 on issue 946323 by bugdroid: editing/caret/caret-painting-low-dpi.html failing on Mac10.13 Tests (dbg)
https://bugs.chromium.org/p/chromium/issues/detail?id=946323#c8

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/77e0e65148d448ecf2c225b87baa527e09142075

commit 77e0e65148d448ecf2c225b87baa527e09142075
Author: Robert Ma <robe...@chromium.org>
Date: Fri May 10 19:39:06 2019

Remove TestExpectations which are not failing in the specified way

This change was made by the update_expectations.py script
third_party/blink/tools/update_expectations.py .

Bug: 404597, 543110, 545140, 591099, 619427, 626703, 636424, 658304, 678346, 696407, 751952, 752449, 757955, 761798, 763975, 766357, 767091, 773122, 774688, 787615, 788110, 789921, 798592, 800745, 810009, 810254, 818154, 818324, 818426, 828506, 829938, 831249, 831482, 831685, 831993, 849284, 853360, 853852, 859169, 862806, 865432, 867376, 867532, 871105, 871445, 872025, 875884, 878315, 886566, 891155, 891510, 893869, 898050, 899710, 900326, 900730, 905694, 911634, 914782, 922508, 925325, 927454, 929435, 931349, 934768, 936479, 937170, 937312, 937546, 937639, 937991, 938591, 942411, 946323, 946700, 946701, 947670, 950222, 951811, 953725
Change-Id: I367beed110b42493185ff664590e1014a765094a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604334
Auto-Submit: Robert Ma <robe...@chromium.org>
Reviewed-by: Xianzhu Wang <wangx...@chromium.org>
Commit-Queue: Xianzhu Wang <wangx...@chromium.org>
Commit-Queue: Robert Ma <robe...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658702}

[modify] https://crrev.com/77e0e65148d448ecf2c225b87baa527e09142075/third_party/blink/web_tests/TestExpectations