Issue 962243 in chromium: We should convert legacy LayoutBlockFlow to LayoutNGFlow for ::first-letter by document.designMode

1 view
Skip to first unread message

yosin via monorail

unread,
May 13, 2019, 4:32:59 AM5/13/19
to editi...@chromium.org
Updates:
Cc: mste...@chromium.org
Summary: We should convert legacy LayoutBlockFlow to LayoutNGFlow for ::first-letter by document.designMode

Comment #4 on issue 962243 by yo...@chromium.org: We should convert legacy LayoutBlockFlow to LayoutNGFlow for ::first-letter by document.designMode
https://bugs.chromium.org/p/chromium/issues/detail?id=962243#c4

The root cause is we still have legacy LayoutBlockFlow first-letter part which is "a" with float:right after document.designMode = 'off';

Note: following test script works as expected. So, document.designMode doesn't kick

<!doctype html>
<style>.x:first-letter { float: left; }</style>
<div id="target" class="x" contnteditable><i>ab</i>cd</div>
<script>
const target = document.getElementById('target');
window.getSelection().selectAllChildren(target);
document.execCommand('italic');
target.setAttribute('contnteditable', 'false');
</script>

--
You received this message because:
1. A rule CC'd you on the issue
2. You are auto-CC'd on all issues in component Blink>Editing

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

mstensho via monorail

unread,
May 13, 2019, 4:36:47 AM5/13/19
to editi...@chromium.org
Updates:
Owner: mste...@chromium.org
Status: Assigned

Comment #5 on issue 962243 by mste...@chromium.org: We should convert legacy LayoutBlockFlow to LayoutNGFlow for ::first-letter by document.designMode
https://bugs.chromium.org/p/chromium/issues/detail?id=962243#c5

(No comment was entered for this change.)

mstensho via monorail

unread,
May 14, 2019, 8:26:59 AM5/14/19
to editi...@chromium.org
Updates:
Mergedinto: 962090
Status: Duplicate

Comment #7 on issue 962243 by mste...@chromium.org: We should convert legacy LayoutBlockFlow to LayoutNGFlow for ::first-letter by document.designMode
https://bugs.chromium.org/p/chromium/issues/detail?id=962243#c7
Reply all
Reply to author
Forward
0 new messages