Re: [blink-dev] Owners missing for web platform tests

[Rick Byers]

+ecosystem-infra, a new team which owns our WPT infrastructure.

Getting more owners for WPT directions is definitely great.  But IMHO we should resist the temptation to try to find owners for ALL directories.  Anyone can create a new spec and corresponding WPT directory even without any browser implementation support (IMHO that's a very good thing), so there's no expectation that we'd ever want to try to pass EVERYTHING in wpt.  There's also some legacy cruft that probably has a low signal-to-noise ratio.  But perhaps we should start by trying to make sure we have owners for directories where we already pass some fraction of the tests?

On Mon, Aug 7, 2017 at 1:52 PM, Chris Harrelson <chri...@chromium.org> wrote:

I think we should have owners for them.css-transforms-2 in particular can be owned by paint-dev, though we haven't been paying attention to them as yet. If there are any currently failing, we can help to fix them. Could you file bugs for the ones that are failing?

Chris

On Mon, Aug 7, 2017 at 10:47 AM, Eric Willigers <ericwi...@chromium.org> wrote:

Various web platform tests are being skipped as NeverFixTests because they don't have owners.

There are also more web platform tests that don't have owners. Presumably they aren't yet being skipped because they haven't been failing.

Should we find owners for all the tests?

I'd like to submit some additional css-transforms-2 tests, and would like them to be run.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/2ce8ffae-52db-4261-afa5-f11fd810e47f%40chromium.org.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-qAYo_z8VxSym6%2BqVhgiqdbss4LTGxxddRjaTFUdCmDw%40mail.gmail.com.

[Stephen Chenney]

The paint team could certainly own external/wpt/css/css-transforms-2/

There are 106 tests in there now and we pass all but 21 of them. Those 21 are failing ref tests. Some of the failures are anti-aliasing, some seem to be color space differences, some are broken image references, and some are flat-out wrong behavior or wrong reference images.

I suppose we should also accept ownership and track the failing SVG tests and any others we would typically handle.

Cheers,

Stephen.

--

Stephen Chenney | Software Engineer | sche...@google.com | 404-314-1809

[Philip Jägenstedt]

I stumbled upon this thread last week as I was poking at the OWNERS files in web-platform-tests, and the discussion in this review is related. Quinten summarized very well:

• We want to import all directories that somebody in Chromium will be working on.
  
• We still want to have OWNERS for directories we import.
  
• It's OK to have tests skipped in NeverFixTests in order to make it easier to initially import them, but there is an expectation that they'll be unskipped.
  

In addition to "will be working on", I think it'd also be useful to import test suites that are already mostly passing, just for the regression testing value.

And, I've gone around adding OWNERS files almost everywhere, I think ecosystem infra can own the problem of deciding what to do about new directories in web-platform-tests that nobody has claimed as theirs.

On Mon, Aug 7, 2017 at 3:08 PM 'Stephen Chenney' via ecosystem-infra <ecosyst...@chromium.org> wrote:

The paint team could certainly own external/wpt/css/css-transforms-2/

There are 106 tests in there now and we pass all but 21 of them. Those 21 are failing ref tests. Some of the failures are anti-aliasing, some seem to be color space differences, some are broken image references, and some are flat-out wrong behavior or wrong reference images.

I suppose we should also accept ownership and track the failing SVG tests and any others we would typically handle.

Cheers,

Stephen.

On Mon, Aug 7, 2017 at 2:08 PM, Rick Byers <rby...@chromium.org> wrote:

+ecosystem-infra, a new team which owns our WPT infrastructure.

Getting more owners for WPT directions is definitely great.  But IMHO we should resist the temptation to try to find owners for ALL directories.  Anyone can create a new spec and corresponding WPT directory even without any browser implementation support (IMHO that's a very good thing), so there's no expectation that we'd ever want to try to pass EVERYTHING in wpt.  There's also some legacy cruft that probably has a low signal-to-noise ratio.  But perhaps we should start by trying to make sure we have owners for directories where we already pass some fraction of the tests?

On Mon, Aug 7, 2017 at 1:52 PM, Chris Harrelson <chri...@chromium.org> wrote:

I think we should have owners for them.css-transforms-2 in particular can be owned by paint-dev, though we haven't been paying attention to them as yet. If there are any currently failing, we can help to fix them. Could you file bugs for the ones that are failing?

Chris

On Mon, Aug 7, 2017 at 10:47 AM, Eric Willigers <ericwi...@chromium.org> wrote:

Various web platform tests are being skipped as NeverFixTests because they don't have owners.

There are also more web platform tests that don't have owners. Presumably they aren't yet being skipped because they haven't been failing.

Should we find owners for all the tests?

I'd like to submit some additional css-transforms-2 tests, and would like them to be run.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/2ce8ffae-52db-4261-afa5-f11fd810e47f%40chromium.org.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-qAYo_z8VxSym6%2BqVhgiqdbss4LTGxxddRjaTFUdCmDw%40mail.gmail.com.

--

Stephen Chenney | Software Engineer | sche...@google.com | 404-314-1809

--
You received this message because you are subscribed to the Google Groups "ecosystem-infra" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ecosystem-inf...@chromium.org.
To post to this group, send email to ecosyst...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/ecosystem-infra/CAObCcUqfSBj%3Du1DXA%3DKbz0bGQEU0k4d3wEnmC2augbTbv3C_5Q%40mail.gmail.com.