CSS-COLLIDING-TEST-NAME

[Morten Stenshorne]

Hello! I suddenly got this:

https://chromium-review.googlesource.com/c/chromium/src/+/2846507/3#message-e2b442c3ba71c0db4511ef67fdafb4b759f44a39

It's complaining about colliding test names for intrinsic-size-005.html,
which I added in the latest patchset. I've never seen this before (and
wasn't even aware of the rule), but fair enough. What's puzzling me is
that I had added intrinsic-size-004.html (and others) in the previous
patchset, but no complaints then, even if that name is also
"colliding". Maybe it was because I didn't run the trybots with that
patchset. But maybe this means that colliding tests may be snuck in that
way?

--
Morten Stenshorne, Software developer,
Blink/Layout, Google, Oslo, Norway

[Jason Chase]

Hi,

I'm also not familiar with the CSS-COLLIDING-TEST-NAME lint rule. Poking at the source for that rule, it appears that it's definition of "colliding" also depends on which specs the test is linked to, not just the file name.

Looking at intrinsic-size-005.html, I see it has multiple spec links, where the other tests (added in earlier patchsets) only have one spec link. Specifically, this test has a link to:

<link rel="help" href="https://www.w3.org/TR/css-sizing-4/#aspect-ratio">

That same spec link is found in the colliding test: /css-sizing/aspect-ratio/intrinsic-size-005.html

That seems like the most likely explanation for what you're seeing. Hope that helps, and let us know if you have any other questions.

Thanks,

Jason

--
You received this message because you are subscribed to the Google Groups "ecosystem-infra" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ecosystem-inf...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/ecosystem-infra/8735vhtc45.fsf%40bud.servebeer.com.

[Morten Stenshorne]

Hi Jason, and thank you very much for investigating!

That seems to have been the problem. I just removed the link, and I
never heard back from the lint thing. This rule doesn't make a lot of
sense to me, but whatever. :)

Thanks again!
Morten