Tal Pressman has uploaded this change for review.
Update test expectations for fast/forms time-suggestion-picker-appearance on Win7.
Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
BUG: 1160594
---
M third_party/blink/web_tests/TestExpectations
1 file changed, 4 insertions(+), 0 deletions(-)
diff --git a/third_party/blink/web_tests/TestExpectations b/third_party/blink/web_tests/TestExpectations
index abf5507..fbb500ad 100644
--- a/third_party/blink/web_tests/TestExpectations
+++ b/third_party/blink/web_tests/TestExpectations
@@ -5881,6 +5881,10 @@
crbug.com/681468 fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom125.html [ Failure Pass ]
crbug.com/681468 fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom200.html [ Failure Pass ]
+# Other fast/forms/suggestion-picker/time-suggestion-picker-appearance.html
+# failures on Win7 caused by focus appearing on the wrong element.
+crbug.com/1160594 [Win7] fast/forms/suggestion-picker/time-suggestion-picker-appearance.html [ Failure ]
+
# These tests will only run in the virtual test suite where the frequency
# capping for overlay popup detection is disabled. This eliminates the need
# for waitings in web tests to trigger a detection event.
To view, visit change 2596946. To unsubscribe, or for help writing mail filters, visit settings.
Patch set 2:Commit-Queue +1
Tal Pressman uploaded patch set #3 to this change.
Update test expectations for fast/forms time-suggestion-picker-appearance on Win7.
Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
Bug: 1160594
---
M third_party/blink/web_tests/TestExpectations
1 file changed, 4 insertions(+), 0 deletions(-)
To view, visit change 2596946. To unsubscribe, or for help writing mail filters, visit settings.
Tal Pressman uploaded patch set #4 to this change.
Update test expectations for fast/forms time-suggestion-picker-appearance on Win7.
Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
BUG: 1160594
---
M third_party/blink/web_tests/TestExpectations
1 file changed, 4 insertions(+), 0 deletions(-)
To view, visit change 2596946. To unsubscribe, or for help writing mail filters, visit settings.
Patch set 4:Commit-Queue +2
CL chromium-review.googlesource.com/2596946 must be approved before triggering CQ
CL is missing the approving vote on Code-Review label.
Tal Pressman uploaded patch set #5 to this change.
Update test expectations for fast/forms time-suggestion-picker-appearance on Win7.
Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
Bug: 1160594
---
M third_party/blink/web_tests/TestExpectations
1 file changed, 4 insertions(+), 0 deletions(-)
To view, visit change 2596946. To unsubscribe, or for help writing mail filters, visit settings.
Tal Pressman uploaded patch set #6 to this change.
Update test expectations for fast/forms time-suggestion-picker-appearance on Win7.
Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
Bug: 1160594
Tbr: dom...@chromium.org
---
M third_party/blink/web_tests/TestExpectations
1 file changed, 4 insertions(+), 0 deletions(-)
To view, visit change 2596946. To unsubscribe, or for help writing mail filters, visit settings.
Patch set 6:Code-Review +1
Patch set 6:Commit-Queue +2
Chromium LUCI CQ submitted this change.
Update test expectations for fast/forms time-suggestion-picker-appearance on Win7.
Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
Bug: 1160594
Tbr: dom...@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596946
Reviewed-by: Tal Pressman <ta...@google.com>
Commit-Queue: Tal Pressman <ta...@google.com>
Cr-Commit-Position: refs/heads/master@{#838586}
---
M third_party/blink/web_tests/TestExpectations
1 file changed, 4 insertions(+), 0 deletions(-)
diff --git a/third_party/blink/web_tests/TestExpectations b/third_party/blink/web_tests/TestExpectations
index abf5507..ede3feeb 100644
--- a/third_party/blink/web_tests/TestExpectations
+++ b/third_party/blink/web_tests/TestExpectations
@@ -5881,6 +5881,10 @@
crbug.com/681468 fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom125.html [ Failure Pass ]
crbug.com/681468 fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom200.html [ Failure Pass ]
+# Other fast/forms/suggestion-picker/time-suggestion-picker-appearance.html
+# failures on Win7 caused by focus appearing on the wrong element.
+crbug.com/1160594 [ Win7 ] fast/forms/suggestion-picker/time-suggestion-picker-appearance.html [ Failure ]
+
# These tests will only run in the virtual test suite where the frequency
# capping for overlay popup detection is disabled. This eliminates the need
# for waitings in web tests to trigger a detection event.
To view, visit change 2596946. To unsubscribe, or for help writing mail filters, visit settings.
Patch set 7:Code-Review +1
1 comment:
Patchset:
Thanks for taking care of this, I'll be looking into it in crbug.com/1160594
To view, visit change 2596946. To unsubscribe, or for help writing mail filters, visit settings.