Update test expectations for fast/forms time-suggestion-picker-appearance on Win7. [chromium/src : master]

3 views
Skip to first unread message

Tal Pressman (Gerrit)

unread,
Dec 20, 2020, 7:43:16 PM12/20/20
to dom...@chromium.org

Tal Pressman has uploaded this change for review.

View Change

Update test expectations for fast/forms time-suggestion-picker-appearance on Win7.

Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
BUG: 1160594
---
M third_party/blink/web_tests/TestExpectations
1 file changed, 4 insertions(+), 0 deletions(-)

diff --git a/third_party/blink/web_tests/TestExpectations b/third_party/blink/web_tests/TestExpectations
index abf5507..fbb500ad 100644
--- a/third_party/blink/web_tests/TestExpectations
+++ b/third_party/blink/web_tests/TestExpectations
@@ -5881,6 +5881,10 @@
crbug.com/681468 fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom125.html [ Failure Pass ]
crbug.com/681468 fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom200.html [ Failure Pass ]

+# Other fast/forms/suggestion-picker/time-suggestion-picker-appearance.html
+# failures on Win7 caused by focus appearing on the wrong element.
+crbug.com/1160594 [Win7] fast/forms/suggestion-picker/time-suggestion-picker-appearance.html [ Failure ]
+
# These tests will only run in the virtual test suite where the frequency
# capping for overlay popup detection is disabled. This eliminates the need
# for waitings in web tests to trigger a detection event.

To view, visit change 2596946. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: master
Gerrit-Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
Gerrit-Change-Number: 2596946
Gerrit-PatchSet: 2
Gerrit-Owner: Tal Pressman <ta...@google.com>
Gerrit-Reviewer: Tal Pressman <ta...@google.com>
Gerrit-MessageType: newchange

Tal Pressman (Gerrit)

unread,
Dec 20, 2020, 7:43:22 PM12/20/20
to dom...@chromium.org

Patch set 2:Commit-Queue +1

View Change

    To view, visit change 2596946. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: master
    Gerrit-Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
    Gerrit-Change-Number: 2596946
    Gerrit-PatchSet: 2
    Gerrit-Owner: Tal Pressman <ta...@google.com>
    Gerrit-Reviewer: Tal Pressman <ta...@google.com>
    Gerrit-Comment-Date: Mon, 21 Dec 2020 00:43:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Tal Pressman (Gerrit)

    unread,
    Dec 20, 2020, 7:44:18 PM12/20/20
    to dom...@chromium.org, Chromium LUCI CQ

    Tal Pressman uploaded patch set #3 to this change.

    View Change

    Update test expectations for fast/forms time-suggestion-picker-appearance on Win7.

    Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
    Bug: 1160594

    ---
    M third_party/blink/web_tests/TestExpectations
    1 file changed, 4 insertions(+), 0 deletions(-)

    To view, visit change 2596946. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: master
    Gerrit-Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
    Gerrit-Change-Number: 2596946
    Gerrit-PatchSet: 3
    Gerrit-Owner: Tal Pressman <ta...@google.com>
    Gerrit-Reviewer: Tal Pressman <ta...@google.com>
    Gerrit-MessageType: newpatchset

    Tal Pressman (Gerrit)

    unread,
    Dec 20, 2020, 8:00:05 PM12/20/20
    to dom...@chromium.org, Chromium LUCI CQ

    Tal Pressman uploaded patch set #4 to this change.

    View Change

    Update test expectations for fast/forms time-suggestion-picker-appearance on Win7.

    Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
    BUG: 1160594

    ---
    M third_party/blink/web_tests/TestExpectations
    1 file changed, 4 insertions(+), 0 deletions(-)

    To view, visit change 2596946. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: master
    Gerrit-Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
    Gerrit-Change-Number: 2596946
    Gerrit-PatchSet: 4

    Tal Pressman (Gerrit)

    unread,
    Dec 20, 2020, 8:55:34 PM12/20/20
    to dom...@chromium.org, Chromium LUCI CQ

    Patch set 4:Commit-Queue +2

    View Change

      To view, visit change 2596946. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: master
      Gerrit-Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
      Gerrit-Change-Number: 2596946
      Gerrit-PatchSet: 4
      Gerrit-Owner: Tal Pressman <ta...@google.com>
      Gerrit-Reviewer: Tal Pressman <ta...@google.com>
      Gerrit-Comment-Date: Mon, 21 Dec 2020 01:55:20 +0000

      Chromium LUCI CQ (Gerrit)

      unread,
      Dec 20, 2020, 8:55:36 PM12/20/20
      to Tal Pressman, dom...@chromium.org

      CL chromium-review.googlesource.com/2596946 must be approved before triggering CQ
      CL is missing the approving vote on Code-Review label.

      View Change

        To view, visit change 2596946. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: master
        Gerrit-Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
        Gerrit-Change-Number: 2596946
        Gerrit-PatchSet: 4
        Gerrit-Owner: Tal Pressman <ta...@google.com>
        Gerrit-Reviewer: Tal Pressman <ta...@google.com>
        Gerrit-Comment-Date: Mon, 21 Dec 2020 01:55:33 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: No
        Gerrit-MessageType: comment

        Tal Pressman (Gerrit)

        unread,
        Dec 20, 2020, 8:58:20 PM12/20/20
        to dom...@chromium.org, Chromium LUCI CQ

        Tal Pressman uploaded patch set #5 to this change.

        View Change

        Update test expectations for fast/forms time-suggestion-picker-appearance on Win7.

        Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
        Bug: 1160594

        ---
        M third_party/blink/web_tests/TestExpectations
        1 file changed, 4 insertions(+), 0 deletions(-)

        To view, visit change 2596946. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: master
        Gerrit-Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
        Gerrit-Change-Number: 2596946
        Gerrit-PatchSet: 5
        Gerrit-Owner: Tal Pressman <ta...@google.com>
        Gerrit-Reviewer: Tal Pressman <ta...@google.com>
        Gerrit-MessageType: newpatchset

        Tal Pressman (Gerrit)

        unread,
        Dec 20, 2020, 8:59:12 PM12/20/20
        to dom...@chromium.org, Chromium LUCI CQ

        Tal Pressman uploaded patch set #6 to this change.

        View Change

        Update test expectations for fast/forms time-suggestion-picker-appearance on Win7.

        Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
        Bug: 1160594
        Tbr: dom...@chromium.org

        ---
        M third_party/blink/web_tests/TestExpectations
        1 file changed, 4 insertions(+), 0 deletions(-)

        To view, visit change 2596946. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: master
        Gerrit-Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
        Gerrit-Change-Number: 2596946
        Gerrit-PatchSet: 6

        Tal Pressman (Gerrit)

        unread,
        Dec 20, 2020, 8:59:17 PM12/20/20
        to dom...@chromium.org, Chromium LUCI CQ

        Patch set 6:Code-Review +1

        View Change

          To view, visit change 2596946. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromium/src
          Gerrit-Branch: master
          Gerrit-Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
          Gerrit-Change-Number: 2596946
          Gerrit-PatchSet: 6
          Gerrit-Owner: Tal Pressman <ta...@google.com>
          Gerrit-Reviewer: Tal Pressman <ta...@google.com>
          Gerrit-Comment-Date: Mon, 21 Dec 2020 01:59:08 +0000

          Tal Pressman (Gerrit)

          unread,
          Dec 20, 2020, 8:59:25 PM12/20/20
          to dom...@chromium.org, Chromium LUCI CQ

          Patch set 6:Commit-Queue +2

          View Change

            To view, visit change 2596946. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromium/src
            Gerrit-Branch: master
            Gerrit-Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
            Gerrit-Change-Number: 2596946
            Gerrit-PatchSet: 6
            Gerrit-Owner: Tal Pressman <ta...@google.com>
            Gerrit-Reviewer: Tal Pressman <ta...@google.com>
            Gerrit-Comment-Date: Mon, 21 Dec 2020 01:59:14 +0000

            Chromium LUCI CQ (Gerrit)

            unread,
            Dec 20, 2020, 9:03:21 PM12/20/20
            to Tal Pressman, dom...@chromium.org

            Chromium LUCI CQ submitted this change.

            View Change

            Approvals: Tal Pressman: Looks good to me; Commit
            Update test expectations for fast/forms time-suggestion-picker-appearance on Win7.

            Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
            Bug: 1160594
            Tbr: dom...@chromium.org
            Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596946
            Reviewed-by: Tal Pressman <ta...@google.com>
            Commit-Queue: Tal Pressman <ta...@google.com>
            Cr-Commit-Position: refs/heads/master@{#838586}

            ---
            M third_party/blink/web_tests/TestExpectations
            1 file changed, 4 insertions(+), 0 deletions(-)

            diff --git a/third_party/blink/web_tests/TestExpectations b/third_party/blink/web_tests/TestExpectations
            index abf5507..ede3feeb 100644

            --- a/third_party/blink/web_tests/TestExpectations
            +++ b/third_party/blink/web_tests/TestExpectations
            @@ -5881,6 +5881,10 @@
            crbug.com/681468 fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom125.html [ Failure Pass ]
            crbug.com/681468 fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom200.html [ Failure Pass ]

            +# Other fast/forms/suggestion-picker/time-suggestion-picker-appearance.html
            +# failures on Win7 caused by focus appearing on the wrong element.
            +crbug.com/1160594 [ Win7 ] fast/forms/suggestion-picker/time-suggestion-picker-appearance.html [ Failure ]
            +
            # These tests will only run in the virtual test suite where the frequency
            # capping for overlay popup detection is disabled. This eliminates the need
            # for waitings in web tests to trigger a detection event.

            To view, visit change 2596946. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromium/src
            Gerrit-Branch: master
            Gerrit-Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
            Gerrit-Change-Number: 2596946
            Gerrit-PatchSet: 7
            Gerrit-Owner: Tal Pressman <ta...@google.com>
            Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-Reviewer: Tal Pressman <ta...@google.com>
            Gerrit-MessageType: merged

            Joey Arhar (Gerrit)

            unread,
            Dec 21, 2020, 1:13:18 PM12/21/20
            to Chromium LUCI CQ, Tal Pressman, dom...@chromium.org

            Patch set 7:Code-Review +1

            View Change

            1 comment:

            To view, visit change 2596946. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromium/src
            Gerrit-Branch: master
            Gerrit-Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2
            Gerrit-Change-Number: 2596946
            Gerrit-PatchSet: 7
            Gerrit-Owner: Tal Pressman <ta...@google.com>
            Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
            Gerrit-Reviewer: Tal Pressman <ta...@google.com>
            Gerrit-Comment-Date: Mon, 21 Dec 2020 18:13:02 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            Gerrit-MessageType: comment
            Reply all
            Reply to author
            Forward
            0 new messages