[InputVizard] Fix missing touch cancel in InputTransferHandlerAndroid using InputEventSource [chromium/src : main]

0 views
Skip to first unread message

Kartar Singh (Gerrit)

unread,
Dec 24, 2025, 3:00:23 AM (2 days ago) Dec 24
to Aman Verma, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, James Su, abigailbk...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, csharris...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, performance-m...@chromium.org, shuche...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Aman Verma

Kartar Singh added 1 comment

File content/public/browser/render_widget_host.h
Line 235, Patchset 4 (Latest): virtual void OnInputEvent(const RenderWidgetHost& host,
const blink::WebInputEvent& event,
const InputEventSource& source) {}
Kartar Singh . unresolved

I am wondering if this is the best approach here. Ideally I would like to avoid making changes to the content public API for this, since we would now be exposing input observer implementers of this extra detail.

Given the current scope, where InputTransferHandlerAndroid which is already owned by RenderWidgetHostViewAndroid, we can go with an alternate approach where InputTransferHandlerAndroid is directly notified about ResetGestureDetection.

WDYT?

Open in Gerrit

Related details

Attention is currently required from:
  • Aman Verma
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib37e3c6bcae80d988dfa8dfb0842385ccc0d5d0a
Gerrit-Change-Number: 7302368
Gerrit-PatchSet: 4
Gerrit-Owner: Aman Verma <ama...@google.com>
Gerrit-Reviewer: Aman Verma <ama...@google.com>
Gerrit-Reviewer: Kartar Singh <karta...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-Attention: Aman Verma <ama...@google.com>
Gerrit-Comment-Date: Wed, 24 Dec 2025 08:00:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Aman Verma (Gerrit)

unread,
Dec 24, 2025, 6:01:45 AM (2 days ago) Dec 24
to Kartar Singh, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, James Su, abigailbk...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, csharris...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, performance-m...@chromium.org, shuche...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Kartar Singh

Aman Verma added 1 comment

File content/public/browser/render_widget_host.h
Line 235, Patchset 4 (Latest): virtual void OnInputEvent(const RenderWidgetHost& host,
const blink::WebInputEvent& event,
const InputEventSource& source) {}
Kartar Singh . unresolved

I am wondering if this is the best approach here. Ideally I would like to avoid making changes to the content public API for this, since we would now be exposing input observer implementers of this extra detail.

Given the current scope, where InputTransferHandlerAndroid which is already owned by RenderWidgetHostViewAndroid, we can go with an alternate approach where InputTransferHandlerAndroid is directly notified about ResetGestureDetection.

WDYT?

Aman Verma

Some of the locations in the browser-side input pipeline where a kTouchCancel event is generated or dispatched, are as follows:

   1. [TouchEmulatorImpl::CancelTouch()](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/renderer_host/input/touch_emulator_impl.cc;l=487;drc=42c8b2a872d3c9322dba3eacbcc090618e923979)
   2. [TouchTimeoutHandler::ConfirmTouchEvent()](https://source.chromium.org/chromium/chromium/src/+/main:components/input/touch_timeout_handler.cc;l=104;drc=42c8b2a872d3c9322dba3eacbcc090618e923979)
   which calls [PassthroughTouchEventQueue::SendTouchCancelEventForTouchEvent()](https://source.chromium.org/chromium/chromium/src/+/main:components/input/passthrough_touch_event_queue.cc;l=87;drc=42c8b2a872d3c9322dba3eacbcc090618e923979)
   4. [AndroidInputHelper::ResetGestureDetection()](https://source.chromium.org/chromium/chromium/src/+/main:components/input/android_input_helper.cc;l=84;drc=42c8b2a872d3c9322dba3eacbcc090618e923979)
   5. [RenderWidgetHostViewIOS::OnTouchEvent()](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/renderer_host/render_widget_host_view_ios_uiview.mm;l=237;drc=42c8b2a872d3c9322dba3eacbcc090618e923979)
   6. [SyntheticGestureTargetAndroid::DispatchInputEvent()](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/renderer_host/input/synthetic_gesture_target_android.cc;l=111;drc=42c8b2a872d3c9322dba3eacbcc090618e923979)
   
Crucially, paths like TouchTimeoutHandler (which handles unresponsive renderers) do not trigger ResetGestureDetection. Thus simply notifying InputTransferHandlerAndroid about ResetGestureDetection might not be enough. In contrast, InputEventObserver is the centralized point for all input dispatch. By adding InputEventSource, we gain a robust consistent way to distinguish Browser vs. Viz events for
  all current and future observers, not just this one handler. The 'cost' of the API change buys us long-term reliability.
  
The existing OnInputEventAck method already includes a
  blink::mojom::InputEventResultSource parameter to indicate where the ack came from setting a precedent for this kind of distinction.
Open in Gerrit

Related details

Attention is currently required from:
  • Kartar Singh
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib37e3c6bcae80d988dfa8dfb0842385ccc0d5d0a
Gerrit-Change-Number: 7302368
Gerrit-PatchSet: 4
Gerrit-Owner: Aman Verma <ama...@google.com>
Gerrit-Reviewer: Aman Verma <ama...@google.com>
Gerrit-Reviewer: Kartar Singh <karta...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-Attention: Kartar Singh <karta...@google.com>
Gerrit-Comment-Date: Wed, 24 Dec 2025 11:01:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kartar Singh <karta...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Kartar Singh (Gerrit)

unread,
Dec 24, 2025, 6:51:18 AM (2 days ago) Dec 24
to Aman Verma, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, James Su, abigailbk...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, csharris...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, performance-m...@chromium.org, shuche...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Aman Verma

Kartar Singh added 1 comment

File content/public/browser/render_widget_host.h
Line 235, Patchset 4 (Latest): virtual void OnInputEvent(const RenderWidgetHost& host,
const blink::WebInputEvent& event,
const InputEventSource& source) {}
Kartar Singh . unresolved

I am wondering if this is the best approach here. Ideally I would like to avoid making changes to the content public API for this, since we would now be exposing input observer implementers of this extra detail.

Given the current scope, where InputTransferHandlerAndroid which is already owned by RenderWidgetHostViewAndroid, we can go with an alternate approach where InputTransferHandlerAndroid is directly notified about ResetGestureDetection.

WDYT?

Aman Verma

Some of the locations in the browser-side input pipeline where a kTouchCancel event is generated or dispatched, are as follows:

   1. [TouchEmulatorImpl::CancelTouch()](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/renderer_host/input/touch_emulator_impl.cc;l=487;drc=42c8b2a872d3c9322dba3eacbcc090618e923979)
   2. [TouchTimeoutHandler::ConfirmTouchEvent()](https://source.chromium.org/chromium/chromium/src/+/main:components/input/touch_timeout_handler.cc;l=104;drc=42c8b2a872d3c9322dba3eacbcc090618e923979)
   which calls [PassthroughTouchEventQueue::SendTouchCancelEventForTouchEvent()](https://source.chromium.org/chromium/chromium/src/+/main:components/input/passthrough_touch_event_queue.cc;l=87;drc=42c8b2a872d3c9322dba3eacbcc090618e923979)
   4. [AndroidInputHelper::ResetGestureDetection()](https://source.chromium.org/chromium/chromium/src/+/main:components/input/android_input_helper.cc;l=84;drc=42c8b2a872d3c9322dba3eacbcc090618e923979)
   5. [RenderWidgetHostViewIOS::OnTouchEvent()](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/renderer_host/render_widget_host_view_ios_uiview.mm;l=237;drc=42c8b2a872d3c9322dba3eacbcc090618e923979)
   6. [SyntheticGestureTargetAndroid::DispatchInputEvent()](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/renderer_host/input/synthetic_gesture_target_android.cc;l=111;drc=42c8b2a872d3c9322dba3eacbcc090618e923979)
   
Crucially, paths like TouchTimeoutHandler (which handles unresponsive renderers) do not trigger ResetGestureDetection. Thus simply notifying InputTransferHandlerAndroid about ResetGestureDetection might not be enough. In contrast, InputEventObserver is the centralized point for all input dispatch. By adding InputEventSource, we gain a robust consistent way to distinguish Browser vs. Viz events for
  all current and future observers, not just this one handler. The 'cost' of the API change buys us long-term reliability.
  
The existing OnInputEventAck method already includes a
  blink::mojom::InputEventResultSource parameter to indicate where the ack came from setting a precedent for this kind of distinction.
Kartar Singh
1. TouchEmulatorImpl::CancelTouch()
2. TouchTimeoutHandler::ConfirmTouchEvent()
    which calls PassthroughTouchEventQueue::SendTouchCancelEventForTouchEvent()
3. AndroidInputHelper::ResetGestureDetection()
4. RenderWidgetHostViewIOS::OnTouchEvent()
5. SyntheticGestureTargetAndroid::DispatchInputEvent()

Thanks for digging into this more, 1,4, 5 doesn't seem to be directly related to InputVizard(for Android) use case.

For 2: `PassthroughTouchEventQueue::SendTouchCancelEventForTouchEvent` do we want it to affect InputTransferHandlerAndroid? i.e. a touch cancel generated due to an unresponsive renderer(few seconds ago) shouldn't probably impact processing a new touch sequence later?

Stepping back, what's the reason we think all the cancels generated on Browser should cause InputTransferHandler to reset state?

Open in Gerrit

Related details

Attention is currently required from:
  • Aman Verma
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib37e3c6bcae80d988dfa8dfb0842385ccc0d5d0a
Gerrit-Change-Number: 7302368
Gerrit-PatchSet: 4
Gerrit-Owner: Aman Verma <ama...@google.com>
Gerrit-Reviewer: Aman Verma <ama...@google.com>
Gerrit-Reviewer: Kartar Singh <karta...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-Attention: Aman Verma <ama...@google.com>
Gerrit-Comment-Date: Wed, 24 Dec 2025 11:51:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aman Verma <ama...@google.com>
Comment-In-Reply-To: Kartar Singh <karta...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Kartar Singh (Gerrit)

unread,
Dec 24, 2025, 7:12:09 AM (2 days ago) Dec 24
to Aman Verma, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, James Su, abigailbk...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, csharris...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, performance-m...@chromium.org, shuche...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
File content/public/browser/render_widget_host.h
Kartar Singh

touch cancel generated due to an unresponsive renderer(few seconds ago) shouldn't probably impact processing a new touch sequence later?

This mostly comes from how we are planning to handle forwarding of touch events/sequences when we are `kConsumeUntilCancel` state in `InputTransferHandlerAndroid` as part of this bug: https://crbug.com/383307455

Gerrit-Comment-Date: Wed, 24 Dec 2025 12:11:51 +0000
satisfied_requirement
unsatisfied_requirement
open
diffy

Aman Verma (Gerrit)

unread,
Dec 24, 2025, 7:56:07 AM (2 days ago) Dec 24
to Kartar Singh, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, James Su, abigailbk...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, csharris...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, performance-m...@chromium.org, shuche...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Kartar Singh

Aman Verma added 1 comment

File content/public/browser/render_widget_host.h
Line 235, Patchset 4: virtual void OnInputEvent(const RenderWidgetHost& host,
Aman Verma

1,4, 5 doesn't seem to be directly related to InputVizard(for Android) use case.

This is correct, however InputEventObserver allows for a generic solution.

As discussed offline, I have added a condition in `InputTransferHandlerAndroid::InputObserver::OnInputEvent` to check if it's a relevant CANCEL event using
```
event.TimeStamp() >=
      transfer_handler_->cached_transferred_sequence_down_time_ms_
```
to call Reset. In general, I think with this condition, using InputEventObserver decouples the inner working of InputTransferHandlerAndroid from RenderWidgetHostViewAndroid/GestureProvider's implementation and future proofs this code of missing relevant CANCEL events.
Open in Gerrit

Related details

Attention is currently required from:
  • Kartar Singh
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib37e3c6bcae80d988dfa8dfb0842385ccc0d5d0a
Gerrit-Change-Number: 7302368
Gerrit-PatchSet: 5
Gerrit-Owner: Aman Verma <ama...@google.com>
Gerrit-Reviewer: Aman Verma <ama...@google.com>
Gerrit-Reviewer: Kartar Singh <karta...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-Attention: Kartar Singh <karta...@google.com>
Gerrit-Comment-Date: Wed, 24 Dec 2025 12:55:49 +0000
satisfied_requirement
unsatisfied_requirement
open
diffy

Kartar Singh (Gerrit)

unread,
Dec 24, 2025, 8:26:15 AM (2 days ago) Dec 24
to Aman Verma, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, James Su, abigailbk...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, csharris...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, performance-m...@chromium.org, shuche...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Aman Verma

Kartar Singh voted and added 4 comments

Votes added by Kartar Singh

Code-Review+1

4 comments

File components/input/input_event_source.h
Line 11, Patchset 5 (Latest):// browser process or from the Viz process.
Kartar Singh . unresolved

s/from/in/, seems a little in-consistent with `in` used earlier in the sentence.

File content/browser/renderer_host/input/input_transfer_handler_android_unittest.cc
Line 132, Patchset 5 (Latest):class InputTransferHandlerTest : public RenderViewHostTestHarness {
Kartar Singh . unresolved

Just wondering what is this required for?

File content/public/browser/render_widget_host.h
Line 237, Patchset 5 (Latest): const InputEventSource& source) {}
Kartar Singh . unresolved

We don't need to pass this by reference. We can just do `InputEventSource source`.

https://abseil.io/tips/234#pass-by-value:
```
Specifically, the types listed below should usually be passed by value:

Numeric and enumeration types (including protobuf enums).
```

Line 235, Patchset 4: virtual void OnInputEvent(const RenderWidgetHost& host,
const blink::WebInputEvent& event,
const InputEventSource& source) {}
Kartar Singh . resolved
Kartar Singh

Thanks, with updated timestamp check and precedence of informing observers about ack input event source, the change LGTM.

Open in Gerrit

Related details

Attention is currently required from:
  • Aman Verma
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib37e3c6bcae80d988dfa8dfb0842385ccc0d5d0a
    Gerrit-Change-Number: 7302368
    Gerrit-PatchSet: 5
    Gerrit-Owner: Aman Verma <ama...@google.com>
    Gerrit-Reviewer: Aman Verma <ama...@google.com>
    Gerrit-Reviewer: Kartar Singh <karta...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-Attention: Aman Verma <ama...@google.com>
    Gerrit-Comment-Date: Wed, 24 Dec 2025 13:25:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Aman Verma (Gerrit)

    unread,
    Dec 24, 2025, 10:45:16 AM (2 days ago) Dec 24
    to Kartar Singh, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, James Su, abigailbk...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, csharris...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, performance-m...@chromium.org, shuche...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org

    Aman Verma added 3 comments

    File components/input/input_event_source.h
    Line 11, Patchset 5:// browser process or from the Viz process.
    Kartar Singh . resolved

    s/from/in/, seems a little in-consistent with `in` used earlier in the sentence.

    Aman Verma

    Done

    File content/browser/renderer_host/input/input_transfer_handler_android_unittest.cc
    Line 132, Patchset 5:class InputTransferHandlerTest : public RenderViewHostTestHarness {
    Kartar Singh . resolved

    Just wondering what is this required for?

    Aman Verma

    This supports testing OnInputEvent which requires a RenderWidgetHost (obtained via rvh()->GetWidget()). This seemed to be the easiest way to satisfy the API's requirement for a valid reference without resorting to fragile hacks or the significant overhead of manually mocking a RenderWidgetHost.

    File content/public/browser/render_widget_host.h
    Line 237, Patchset 5: const InputEventSource& source) {}
    Kartar Singh . resolved

    We don't need to pass this by reference. We can just do `InputEventSource source`.

    https://abseil.io/tips/234#pass-by-value:
    ```
    Specifically, the types listed below should usually be passed by value:

    Numeric and enumeration types (including protobuf enums).
    ```

    Aman Verma

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib37e3c6bcae80d988dfa8dfb0842385ccc0d5d0a
      Gerrit-Change-Number: 7302368
      Gerrit-PatchSet: 6
      Gerrit-Owner: Aman Verma <ama...@google.com>
      Gerrit-Reviewer: Aman Verma <ama...@google.com>
      Gerrit-Reviewer: Kartar Singh <karta...@google.com>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: James Su <su...@chromium.org>
      Gerrit-Comment-Date: Wed, 24 Dec 2025 15:44:59 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Kartar Singh <karta...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Aman Verma (Gerrit)

      unread,
      Dec 24, 2025, 10:47:05 AM (2 days ago) Dec 24
      to Avi Drissman, Kartar Singh, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, James Su, abigailbk...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, csharris...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, performance-m...@chromium.org, shuche...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
      Attention needed from Avi Drissman

      Aman Verma voted Auto-Submit+1

      Auto-Submit+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Avi Drissman
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib37e3c6bcae80d988dfa8dfb0842385ccc0d5d0a
      Gerrit-Change-Number: 7302368
      Gerrit-PatchSet: 6
      Gerrit-Owner: Aman Verma <ama...@google.com>
      Gerrit-Reviewer: Aman Verma <ama...@google.com>
      Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Kartar Singh <karta...@google.com>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: James Su <su...@chromium.org>
      Gerrit-Attention: Avi Drissman <a...@chromium.org>
      Gerrit-Comment-Date: Wed, 24 Dec 2025 15:46:44 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Avi Drissman (Gerrit)

      unread,
      Dec 25, 2025, 10:48:50 PM (9 hours ago) Dec 25
      to Aman Verma, Avi Drissman, Jonathan Ross, Kartar Singh, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, James Su, abigailbk...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, csharris...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, performance-m...@chromium.org, shuche...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
      Attention needed from Aman Verma

      Avi Drissman voted and added 1 comment

      Votes added by Avi Drissman

      Code-Review+1

      1 comment

      File content/public/browser/render_widget_host.h
      Line 231, Patchset 6 (Latest): virtual ~InputEventObserver() {}
      Avi Drissman . unresolved

      Please fix this WARNING reported by ClangTidy: check: modernize-use-equals-default

      use '= default' to define a trivial destruc...

      check: modernize-use-equals-default

      use '= default' to define a trivial destructor (https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-default.html)

      (Note: You can add `Skip-Clang-Tidy-Checks: modernize-use-equals-default` footer to the CL description to skip the check)

      (Lint observed on `linux-clang-tidy-rel`, but not on `android-clang-tidy-rel`)

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Aman Verma
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ib37e3c6bcae80d988dfa8dfb0842385ccc0d5d0a
        Gerrit-Change-Number: 7302368
        Gerrit-PatchSet: 6
        Gerrit-Owner: Aman Verma <ama...@google.com>
        Gerrit-Reviewer: Aman Verma <ama...@google.com>
        Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
        Gerrit-Reviewer: Kartar Singh <karta...@google.com>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: James Su <su...@chromium.org>
        Gerrit-CC: Jonathan Ross <jon...@chromium.org>
        Gerrit-Attention: Aman Verma <ama...@google.com>
        Gerrit-Comment-Date: Fri, 26 Dec 2025 03:48:34 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages