Keep Developer Tools button active when disabled by policy. [chromium/src : main]

0 views
Skip to first unread message

gwsq (Gerrit)

unread,
Nov 3, 2025, 1:35:49 PM (yesterday) Nov 3
to Michał Kaczmarczyk, Enterprise Policy Reviews, Julian Pastarmov, Tom Lukaszewicz, Yang Guo, AyeAye, Chromium LUCI CQ, devtools...@chromium.org
Attention needed from Julian Pastarmov and Michał Kaczmarczyk

Message from gwsq

Reviewer source(s):
pasta...@chromium.org is from context(chrome/enterprise/gwsq/enterprise-policy-review.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Julian Pastarmov
  • Michał Kaczmarczyk
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5902e2a9039192afd5b1e80c3d8c0fee4faa35c9
Gerrit-Change-Number: 7112058
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Kaczmarczyk <mickacz...@google.com>
Gerrit-Reviewer: Julian Pastarmov <pasta...@chromium.org>
Gerrit-Reviewer: Michał Kaczmarczyk <mickacz...@google.com>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: Yang Guo <yan...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Michał Kaczmarczyk <mickacz...@google.com>
Gerrit-Attention: Julian Pastarmov <pasta...@chromium.org>
Gerrit-Comment-Date: Mon, 03 Nov 2025 18:35:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yang Guo (Gerrit)

unread,
4:06 AM (17 hours ago) 4:06 AM
to Michał Kaczmarczyk, Benedikt Meurer, Enterprise Policy Reviews, Julian Pastarmov, Tom Lukaszewicz, AyeAye, Chromium LUCI CQ, devtools...@chromium.org
Attention needed from Benedikt Meurer, Julian Pastarmov and Michał Kaczmarczyk

Yang Guo added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Yang Guo . resolved

Benedikt, please take a look. Thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Benedikt Meurer
  • Julian Pastarmov
  • Michał Kaczmarczyk
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5902e2a9039192afd5b1e80c3d8c0fee4faa35c9
Gerrit-Change-Number: 7112058
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Kaczmarczyk <mickacz...@google.com>
Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
Gerrit-Reviewer: Julian Pastarmov <pasta...@chromium.org>
Gerrit-Reviewer: Michał Kaczmarczyk <mickacz...@google.com>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: Yang Guo <yan...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Michał Kaczmarczyk <mickacz...@google.com>
Gerrit-Attention: Benedikt Meurer <bme...@chromium.org>
Gerrit-Attention: Julian Pastarmov <pasta...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Nov 2025 09:06:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Benedikt Meurer (Gerrit)

unread,
4:25 AM (17 hours ago) 4:25 AM
to Michał Kaczmarczyk, Enterprise Policy Reviews, Julian Pastarmov, Tom Lukaszewicz, Yang Guo, AyeAye, Chromium LUCI CQ, devtools...@chromium.org
Attention needed from Julian Pastarmov and Michał Kaczmarczyk

Benedikt Meurer voted and added 1 comment

Votes added by Benedikt Meurer

Code-Review+1

1 comment

File chrome/browser/ui/browser_command_controller.cc
Line 1931, Patchset 5 (Latest):void BrowserCommandController::UpdateCommandsForDevTools() {
Benedikt Meurer . unresolved

I think we can remove this method now, since the commands are always enabled and are never updated.

Open in Gerrit

Related details

Attention is currently required from:
  • Julian Pastarmov
  • Michał Kaczmarczyk
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5902e2a9039192afd5b1e80c3d8c0fee4faa35c9
    Gerrit-Change-Number: 7112058
    Gerrit-PatchSet: 5
    Gerrit-Owner: Michał Kaczmarczyk <mickacz...@google.com>
    Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
    Gerrit-Reviewer: Julian Pastarmov <pasta...@chromium.org>
    Gerrit-Reviewer: Michał Kaczmarczyk <mickacz...@google.com>
    Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Yang Guo <yan...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Michał Kaczmarczyk <mickacz...@google.com>
    Gerrit-Attention: Julian Pastarmov <pasta...@chromium.org>
    Gerrit-Comment-Date: Tue, 04 Nov 2025 09:24:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Michał Kaczmarczyk (Gerrit)

    unread,
    8:37 AM (13 hours ago) 8:37 AM
    to Dominique Fauteux-Chapleau, Benedikt Meurer, Enterprise Policy Reviews, Julian Pastarmov, Tom Lukaszewicz, Yang Guo, AyeAye, Chromium LUCI CQ, devtools...@chromium.org
    Attention needed from Benedikt Meurer, Dominique Fauteux-Chapleau and Julian Pastarmov

    Michał Kaczmarczyk added 1 comment

    File chrome/browser/ui/browser_command_controller.cc
    Line 1931, Patchset 5:void BrowserCommandController::UpdateCommandsForDevTools() {
    Benedikt Meurer . resolved

    I think we can remove this method now, since the commands are always enabled and are never updated.

    Michał Kaczmarczyk

    Removed

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Benedikt Meurer
    • Dominique Fauteux-Chapleau
    • Julian Pastarmov
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I5902e2a9039192afd5b1e80c3d8c0fee4faa35c9
      Gerrit-Change-Number: 7112058
      Gerrit-PatchSet: 6
      Gerrit-Owner: Michał Kaczmarczyk <mickacz...@google.com>
      Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
      Gerrit-Reviewer: Dominique Fauteux-Chapleau <do...@chromium.org>
      Gerrit-Reviewer: Julian Pastarmov <pasta...@chromium.org>
      Gerrit-Reviewer: Michał Kaczmarczyk <mickacz...@google.com>
      Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
      Gerrit-Reviewer: Yang Guo <yan...@chromium.org>
      Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Benedikt Meurer <bme...@chromium.org>
      Gerrit-Attention: Dominique Fauteux-Chapleau <do...@chromium.org>
      Gerrit-Attention: Julian Pastarmov <pasta...@chromium.org>
      Gerrit-Comment-Date: Tue, 04 Nov 2025 13:37:21 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Benedikt Meurer <bme...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Julian Pastarmov (Gerrit)

      unread,
      8:48 AM (13 hours ago) 8:48 AM
      to Michał Kaczmarczyk, Dominique Fauteux-Chapleau, Benedikt Meurer, Enterprise Policy Reviews, Tom Lukaszewicz, Yang Guo, AyeAye, Chromium LUCI CQ, devtools...@chromium.org
      Attention needed from Benedikt Meurer, Dominique Fauteux-Chapleau and Michał Kaczmarczyk

      Julian Pastarmov voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Benedikt Meurer
      • Dominique Fauteux-Chapleau
      • Michał Kaczmarczyk
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I5902e2a9039192afd5b1e80c3d8c0fee4faa35c9
        Gerrit-Change-Number: 7112058
        Gerrit-PatchSet: 6
        Gerrit-Owner: Michał Kaczmarczyk <mickacz...@google.com>
        Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
        Gerrit-Reviewer: Dominique Fauteux-Chapleau <do...@chromium.org>
        Gerrit-Reviewer: Julian Pastarmov <pasta...@chromium.org>
        Gerrit-Reviewer: Michał Kaczmarczyk <mickacz...@google.com>
        Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
        Gerrit-Reviewer: Yang Guo <yan...@chromium.org>
        Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
        Gerrit-CC: gwsq
        Gerrit-Attention: Michał Kaczmarczyk <mickacz...@google.com>
        Gerrit-Attention: Benedikt Meurer <bme...@chromium.org>
        Gerrit-Attention: Dominique Fauteux-Chapleau <do...@chromium.org>
        Gerrit-Comment-Date: Tue, 04 Nov 2025 13:48:15 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Dominique Fauteux-Chapleau (Gerrit)

        unread,
        9:24 AM (12 hours ago) 9:24 AM
        to Michał Kaczmarczyk, Julian Pastarmov, Benedikt Meurer, Enterprise Policy Reviews, Tom Lukaszewicz, Yang Guo, AyeAye, Chromium LUCI CQ, devtools...@chromium.org
        Attention needed from Benedikt Meurer, Michał Kaczmarczyk and Tom Lukaszewicz

        Dominique Fauteux-Chapleau voted and added 1 comment

        Votes added by Dominique Fauteux-Chapleau

        Code-Review+1

        1 comment

        Patchset-level comments
        File-level comment, Patchset 6 (Latest):
        Dominique Fauteux-Chapleau . unresolved

        LGTM from the enterprise perspective, but add a Finch flag as discussed offline.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Benedikt Meurer
        • Michał Kaczmarczyk
        • Tom Lukaszewicz
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I5902e2a9039192afd5b1e80c3d8c0fee4faa35c9
          Gerrit-Change-Number: 7112058
          Gerrit-PatchSet: 6
          Gerrit-Owner: Michał Kaczmarczyk <mickacz...@google.com>
          Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
          Gerrit-Reviewer: Dominique Fauteux-Chapleau <do...@chromium.org>
          Gerrit-Reviewer: Julian Pastarmov <pasta...@chromium.org>
          Gerrit-Reviewer: Michał Kaczmarczyk <mickacz...@google.com>
          Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
          Gerrit-Reviewer: Yang Guo <yan...@chromium.org>
          Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
          Gerrit-CC: gwsq
          Gerrit-Attention: Michał Kaczmarczyk <mickacz...@google.com>
          Gerrit-Attention: Benedikt Meurer <bme...@chromium.org>
          Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
          Gerrit-Comment-Date: Tue, 04 Nov 2025 14:24:00 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Benedikt Meurer (Gerrit)

          unread,
          12:15 PM (9 hours ago) 12:15 PM
          to Michał Kaczmarczyk, Dominique Fauteux-Chapleau, Julian Pastarmov, Enterprise Policy Reviews, Tom Lukaszewicz, Yang Guo, AyeAye, Chromium LUCI CQ, devtools...@chromium.org
          Attention needed from Michał Kaczmarczyk and Tom Lukaszewicz

          Benedikt Meurer voted Code-Review+1

          Code-Review+1
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Michał Kaczmarczyk
          • Tom Lukaszewicz
          Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
          Gerrit-Comment-Date: Tue, 04 Nov 2025 17:15:40 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Tom Lukaszewicz (Gerrit)

          unread,
          2:18 PM (7 hours ago) 2:18 PM
          to Michał Kaczmarczyk, Dominique Fauteux-Chapleau, Julian Pastarmov, Enterprise Policy Reviews, Yang Guo, AyeAye, Chromium LUCI CQ, devtools...@chromium.org
          Attention needed from Michał Kaczmarczyk

          Tom Lukaszewicz voted and added 2 comments

          Votes added by Tom Lukaszewicz

          Code-Review+1

          2 comments

          Patchset-level comments
          Tom Lukaszewicz . resolved

          lgtm

          Commit Message
          Line 9, Patchset 6 (Latest):Previously, the Developer Tools button would be greyed out if the feature was disabled by an enterprise policy. This visual state prevented users from clicking the button to see the dialog window that explains why it is unavailable.

          This change keeps the button active (not greyed out) so that users can click it to view the explanatory dialog.
          Tom Lukaszewicz . unresolved

          nit: Can we wrap the description to 72 cols?

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Michał Kaczmarczyk
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I5902e2a9039192afd5b1e80c3d8c0fee4faa35c9
          Gerrit-Change-Number: 7112058
          Gerrit-PatchSet: 6
          Gerrit-Owner: Michał Kaczmarczyk <mickacz...@google.com>
          Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
          Gerrit-Reviewer: Dominique Fauteux-Chapleau <do...@chromium.org>
          Gerrit-Reviewer: Julian Pastarmov <pasta...@chromium.org>
          Gerrit-Reviewer: Michał Kaczmarczyk <mickacz...@google.com>
          Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
          Gerrit-Reviewer: Yang Guo <yan...@chromium.org>
          Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
          Gerrit-CC: gwsq
          Gerrit-Attention: Michał Kaczmarczyk <mickacz...@google.com>
          Gerrit-Comment-Date: Tue, 04 Nov 2025 19:17:19 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy
          Reply all
          Reply to author
          Forward
          0 new messages