[console] Split 'createEditor' in 'ConsolePin' [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Simon Zünd (Gerrit)
2:23 AM (7 hours ago) 2:23 AM
to Devtools-frontend LUCI CQ, Kim-Anh Tran, devtools-rev...@chromium.org
Attention needed from Kim-Anh Tran
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Kim-Anh Tran
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kim-Anh Tran (Gerrit)
3:30 AM (6 hours ago) 3:30 AM
to Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Simon Zünd
Kim-Anh Tran voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simon Zünd (Gerrit)
3:41 AM (5 hours ago) 3:41 AM
to Kim-Anh Tran, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Simon Zünd voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
3:45 AM (5 hours ago) 3:45 AM
to Simon Zünd, Kim-Anh Tran, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[console] Split 'createEditor' in 'ConsolePin'
We'll probably pass the initial CodeMirror EditorState to the view
function so as a first step we isolate it into a separate function.
Drive-by: Mark functions as private that are not used by the parsent
Pane.
R=kim...@chromium.org
Bug: 407750444
Change-Id: I05f358d4789c987ea90c358041a2e49ff0a90d9b
Reviewed-by: Kim-Anh Tran <kim...@chromium.org>
Commit-Queue: Simon Zünd <szu...@chromium.org>
Files:
- M front_end/panels/console/ConsolePinPane.ts
Change size: S
Delta: 1 file changed, 9 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kim-Anh Tran
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages