[console] Split 'createEditor' in 'ConsolePin' [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Simon Zünd (Gerrit)

unread,
2:23 AM (7 hours ago) 2:23 AM
to Devtools-frontend LUCI CQ, Kim-Anh Tran, devtools-rev...@chromium.org
Attention needed from Kim-Anh Tran

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Kim-Anh Tran
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I05f358d4789c987ea90c358041a2e49ff0a90d9b
Gerrit-Change-Number: 7208994
Gerrit-PatchSet: 1
Gerrit-Owner: Simon Zünd <szu...@chromium.org>
Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Dec 2025 07:23:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kim-Anh Tran (Gerrit)

unread,
3:30 AM (6 hours ago) 3:30 AM
to Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Simon Zünd

Kim-Anh Tran voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Simon Zünd
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I05f358d4789c987ea90c358041a2e49ff0a90d9b
Gerrit-Change-Number: 7208994
Gerrit-PatchSet: 1
Gerrit-Owner: Simon Zünd <szu...@chromium.org>
Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Simon Zünd <szu...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Dec 2025 08:29:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Simon Zünd (Gerrit)

unread,
3:41 AM (5 hours ago) 3:41 AM
to Kim-Anh Tran, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Simon Zünd voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I05f358d4789c987ea90c358041a2e49ff0a90d9b
Gerrit-Change-Number: 7208994
Gerrit-PatchSet: 1
Gerrit-Owner: Simon Zünd <szu...@chromium.org>
Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 08:41:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
3:45 AM (5 hours ago) 3:45 AM
to Simon Zünd, Kim-Anh Tran, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
[console] Split 'createEditor' in 'ConsolePin'

We'll probably pass the initial CodeMirror EditorState to the view
function so as a first step we isolate it into a separate function.

Drive-by: Mark functions as private that are not used by the parsent
Pane.

R=kim...@chromium.org
Bug: 407750444
Change-Id: I05f358d4789c987ea90c358041a2e49ff0a90d9b
Reviewed-by: Kim-Anh Tran <kim...@chromium.org>
Commit-Queue: Simon Zünd <szu...@chromium.org>
Files:
  • M front_end/panels/console/ConsolePinPane.ts
Change size: S
Delta: 1 file changed, 9 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kim-Anh Tran
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I05f358d4789c987ea90c358041a2e49ff0a90d9b
Gerrit-Change-Number: 7208994
Gerrit-PatchSet: 2
Gerrit-Owner: Simon Zünd <szu...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages