[css-anchor-position] Rename position-try-options to *fallbacks [chromium/src : main]

0 views
Skip to first unread message

Rune Lillesveen (Gerrit)

unread,
Jul 2, 2024, 10:50:52 AMJul 2
to Rune Lillesveen, Anders Hartvoll Ruud, Olga Gerchikov, Daniel Cheng, AyeAye, Alexis Menard, David Bokan, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Attention needed from Anders Hartvoll Ruud

Rune Lillesveen added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Rune Lillesveen . resolved

ptal

Open in Gerrit

Related details

Attention is currently required from:
  • Anders Hartvoll Ruud
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9886c8f592e283f2b72be21153d376f1d848e0a4
Gerrit-Change-Number: 5667406
Gerrit-PatchSet: 7
Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jul 2024 14:50:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Anders Hartvoll Ruud (Gerrit)

unread,
Jul 2, 2024, 1:56:23 PMJul 2
to Rune Lillesveen, Olga Gerchikov, Daniel Cheng, AyeAye, Alexis Menard, David Bokan, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Attention needed from Rune Lillesveen

Anders Hartvoll Ruud added 2 comments

File third_party/blink/renderer/platform/runtime_enabled_features.json5
Line 980, Patchset 7 (Latest): {
// position-try-options has been renamed to position-try-fallbacks. Will
// be removed, but kept as a surrogate for now.
name: "CSSPositionTryOptions",
depends_on: ["CSSAnchorPositioning"],
status: "stable",
},
Anders Hartvoll Ruud . unresolved

Can we not just keep using `CSSAnchorPositioning` for `position-try-options`?

File third_party/blink/web_tests/virtual/stable/webexposed/css-property-listing-expected.txt
Line 738, Patchset 7 (Parent): position-try-options
Anders Hartvoll Ruud . unresolved

This change is not expected, I think we need do an alternative `position-try` shorthand. (See `alternative_of`).

Open in Gerrit

Related details

Attention is currently required from:
  • Rune Lillesveen
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9886c8f592e283f2b72be21153d376f1d848e0a4
    Gerrit-Change-Number: 5667406
    Gerrit-PatchSet: 7
    Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Comment-Date: Tue, 02 Jul 2024 17:56:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rune Lillesveen (Gerrit)

    unread,
    Jul 4, 2024, 6:40:12 AMJul 4
    to Rune Lillesveen, Anders Hartvoll Ruud, Olga Gerchikov, Daniel Cheng, AyeAye, Alexis Menard, David Bokan, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
    Attention needed from Anders Hartvoll Ruud

    Rune Lillesveen added 2 comments

    File third_party/blink/renderer/platform/runtime_enabled_features.json5

    // position-try-options has been renamed to position-try-fallbacks. Will
    // be removed, but kept as a surrogate for now.
    name: "CSSPositionTryOptions",
    depends_on: ["CSSAnchorPositioning"],
    status: "stable",
    },
    Anders Hartvoll Ruud . resolved

    Can we not just keep using `CSSAnchorPositioning` for `position-try-options`?

    Rune Lillesveen

    It's for disabling position-try-options later. We need a separate flag for that.

    EDIT: as agreed off-line, I'll do that in a separate CL.

    File third_party/blink/web_tests/virtual/stable/webexposed/css-property-listing-expected.txt
    Line 738, Patchset 7 (Parent): position-try-options
    Anders Hartvoll Ruud . resolved

    This change is not expected, I think we need do an alternative `position-try` shorthand. (See `alternative_of`).

    Rune Lillesveen

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Anders Hartvoll Ruud
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9886c8f592e283f2b72be21153d376f1d848e0a4
    Gerrit-Change-Number: 5667406
    Gerrit-PatchSet: 8
    Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Comment-Date: Thu, 04 Jul 2024 10:40:00 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Anders Hartvoll Ruud <and...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rune Lillesveen (Gerrit)

    unread,
    Jul 4, 2024, 6:42:08 AMJul 4
    to Rune Lillesveen, Alex Rudenko, Anders Hartvoll Ruud, Olga Gerchikov, Daniel Cheng, AyeAye, Alexis Menard, David Bokan, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
    Attention needed from Alex Rudenko and Anders Hartvoll Ruud

    Rune Lillesveen added 1 comment

    Patchset-level comments
    File-level comment, Patchset 8 (Latest):
    Rune Lillesveen . resolved

    alexrudenko@ for browser_protocol.pdl comment.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Rudenko
    • Anders Hartvoll Ruud
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9886c8f592e283f2b72be21153d376f1d848e0a4
    Gerrit-Change-Number: 5667406
    Gerrit-PatchSet: 8
    Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Comment-Date: Thu, 04 Jul 2024 10:41:59 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Anders Hartvoll Ruud (Gerrit)

    unread,
    Jul 4, 2024, 7:04:49 AMJul 4
    to Rune Lillesveen, Alex Rudenko, Olga Gerchikov, Daniel Cheng, AyeAye, Alexis Menard, David Bokan, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
    Attention needed from Alex Rudenko and Rune Lillesveen

    Anders Hartvoll Ruud voted and added 2 comments

    Votes added by Anders Hartvoll Ruud

    Code-Review+1

    2 comments

    File third_party/blink/renderer/core/css/css_properties.json5
    Line 8164, Patchset 8 (Latest): // animation-timeline and animation-range-* longhands.
    Anders Hartvoll Ruud . unresolved

    Nope.

    File third_party/blink/renderer/core/css/properties/shorthands/shorthands_custom.cc
    Line 3029, Patchset 8 (Latest): RuntimeEnabledFeatures::CSSPositionTryFallbacksEnabled()
    Anders Hartvoll Ruud . unresolved

    We should AFAIK not reach this function with the flag enabled.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Rudenko
    • Rune Lillesveen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9886c8f592e283f2b72be21153d376f1d848e0a4
    Gerrit-Change-Number: 5667406
    Gerrit-PatchSet: 8
    Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Comment-Date: Thu, 04 Jul 2024 11:04:40 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rune Lillesveen (Gerrit)

    unread,
    Jul 4, 2024, 7:39:50 AMJul 4
    to Rune Lillesveen, Anders Hartvoll Ruud, Alex Rudenko, Olga Gerchikov, Daniel Cheng, AyeAye, Alexis Menard, David Bokan, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
    Attention needed from Alex Rudenko

    Rune Lillesveen added 2 comments

    File third_party/blink/renderer/core/css/css_properties.json5
    Line 8164, Patchset 8: // animation-timeline and animation-range-* longhands.
    Anders Hartvoll Ruud . resolved

    Nope.

    Rune Lillesveen

    Done

    File third_party/blink/renderer/core/css/properties/shorthands/shorthands_custom.cc
    Line 3029, Patchset 8: RuntimeEnabledFeatures::CSSPositionTryFallbacksEnabled()
    Anders Hartvoll Ruud . resolved

    We should AFAIK not reach this function with the flag enabled.

    Rune Lillesveen

    Right. Fixed.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Rudenko
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9886c8f592e283f2b72be21153d376f1d848e0a4
    Gerrit-Change-Number: 5667406
    Gerrit-PatchSet: 9
    Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Comment-Date: Thu, 04 Jul 2024 11:39:40 +0000
    Gerrit-HasComments: Yes
    satisfied_requirement
    open
    diffy

    Rune Lillesveen (Gerrit)

    unread,
    Jul 4, 2024, 8:54:16 AMJul 4
    to Rune Lillesveen, Chromium LUCI CQ, Anders Hartvoll Ruud, Alex Rudenko, Olga Gerchikov, Daniel Cheng, AyeAye, Alexis Menard, David Bokan, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
    Attention needed from Alex Rudenko

    Rune Lillesveen voted Auto-Submit+1

    Auto-Submit+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Rudenko
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9886c8f592e283f2b72be21153d376f1d848e0a4
    Gerrit-Change-Number: 5667406
    Gerrit-PatchSet: 10
    Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Comment-Date: Thu, 04 Jul 2024 12:54:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Philip Jägenstedt (Gerrit)

    unread,
    Jul 4, 2024, 9:17:50 AMJul 4
    to Rune Lillesveen, Chromium LUCI CQ, Anders Hartvoll Ruud, Alex Rudenko, Olga Gerchikov, Daniel Cheng, AyeAye, Alexis Menard, David Bokan, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
    Attention needed from Alex Rudenko and Rune Lillesveen

    Philip Jägenstedt voted and added 1 comment

    Votes added by Philip Jägenstedt

    Code-Review+1
    Commit-Queue+2

    1 comment

    Patchset-level comments
    File-level comment, Patchset 10 (Latest):
    Philip Jägenstedt . resolved

    third_party/blink/public/devtools_protocol/browser_protocol.pdl LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Rudenko
    • Rune Lillesveen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9886c8f592e283f2b72be21153d376f1d848e0a4
    Gerrit-Change-Number: 5667406
    Gerrit-PatchSet: 10
    Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Comment-Date: Thu, 04 Jul 2024 13:17:39 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 4, 2024, 9:22:13 AMJul 4
    to Rune Lillesveen, Philip Jägenstedt, Anders Hartvoll Ruud, Alex Rudenko, Olga Gerchikov, Daniel Cheng, AyeAye, Alexis Menard, David Bokan, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [css-anchor-position] Rename position-try-options to *fallbacks

    The position-try-options property was renamed in the specification. The
    values are still the same.

    The position-try-options name will still be an alternative one until it
    is unshipped.
    Bug: 349600667
    Change-Id: I9886c8f592e283f2b72be21153d376f1d848e0a4
    Commit-Queue: Philip Jägenstedt <foo...@chromium.org>
    Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
    Reviewed-by: Philip Jägenstedt <foo...@chromium.org>
    Auto-Submit: Rune Lillesveen <fut...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1323315}
    Files:
    • M third_party/blink/public/devtools_protocol/browser_protocol.pdl
    • M third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
    • M third_party/blink/renderer/core/css/build.gni
    • M third_party/blink/renderer/core/css/css_flip_revert_value.h
    • M third_party/blink/renderer/core/css/css_properties.json5
    • M third_party/blink/renderer/core/css/css_property_equality.cc
    • M third_party/blink/renderer/core/css/css_value_keywords.json5
    • M third_party/blink/renderer/core/css/out_of_flow_data.cc
    • M third_party/blink/renderer/core/css/out_of_flow_data.h
    • M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
    • M third_party/blink/renderer/core/css/properties/computed_style_utils.h
    • M third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
    • M third_party/blink/renderer/core/css/properties/css_parsing_utils.h
    • M third_party/blink/renderer/core/css/properties/css_parsing_utils_test.cc
    • M third_party/blink/renderer/core/css/properties/css_property_test.cc
    • M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
    • M third_party/blink/renderer/core/css/properties/shorthands/shorthands_custom.cc
    • M third_party/blink/renderer/core/css/resolver/match_result.h
    • M third_party/blink/renderer/core/css/resolver/style_resolver.cc
    • M third_party/blink/renderer/core/css/resolver/style_resolver_test.cc
    • M third_party/blink/renderer/core/css/style_engine.cc
    • M third_party/blink/renderer/core/css/style_engine.h
    • M third_party/blink/renderer/core/css/style_property_serializer.cc
    • M third_party/blink/renderer/core/css/style_property_serializer.h
    • M third_party/blink/renderer/core/css/style_recalc_context.h
    • A third_party/blink/renderer/core/css/successful_position_fallback.cc
    • A third_party/blink/renderer/core/css/successful_position_fallback.h
    • D third_party/blink/renderer/core/css/successful_position_option.cc
    • D third_party/blink/renderer/core/css/successful_position_option.h
    • M third_party/blink/renderer/core/css/try_tactic_transform.h
    • M third_party/blink/renderer/core/css/try_value_flips.h
    • M third_party/blink/renderer/core/dom/element.cc
    • M third_party/blink/renderer/core/frame/local_frame_view.cc
    • M third_party/blink/renderer/core/frame/local_frame_view.h
    • M third_party/blink/renderer/core/html/resources/selectlist.css
    • M third_party/blink/renderer/core/html/resources/stylable_select.css
    • M third_party/blink/renderer/core/inspector/inspector_css_agent.cc
    • M third_party/blink/renderer/core/layout/layout_object.cc
    • M third_party/blink/renderer/core/layout/layout_object.h
    • M third_party/blink/renderer/core/layout/out_of_flow_layout_part.cc
    • M third_party/blink/renderer/core/layout/out_of_flow_layout_part.h
    • M third_party/blink/renderer/core/style/build.gni
    • M third_party/blink/renderer/core/style/computed_style.cc
    • M third_party/blink/renderer/core/style/computed_style_constants.h
    • A third_party/blink/renderer/core/style/position_try_fallbacks.cc
    • R third_party/blink/renderer/core/style/position_try_fallbacks.h
    • D third_party/blink/renderer/core/style/position_try_options.cc
    • M third_party/blink/renderer/platform/runtime_enabled_features.json5
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-getComputedStyle-003.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-invalid-fallback.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-chained-fallback.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-001.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-002.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-003.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-004.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-005.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-007.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-008.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-009.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-010.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-011.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-012.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-013.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/anchor-scroll-position-try-014.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/at-position-try-cssom.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/at-position-try-invalidation-shadow-dom.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/at-position-try-invalidation.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/base-style-invalidation.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/chrome-1512373-2-crash.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/chrome-40286059-crash.html
    • R third_party/blink/web_tests/external/wpt/css/css-anchor-position/inline-grid-try-fallbacks-crash.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/inset-area-in-position-try.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/inset-area-value.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/last-successful-basic.html
    • R third_party/blink/web_tests/external/wpt/css/css-anchor-position/last-successful-change-fallbacks.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/last-successful-change-try-rule.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/last-successful-intermediate-ignored.html
    • A third_party/blink/web_tests/external/wpt/css/css-anchor-position/parsing/position-try-fallbacks-computed.html
    • A third_party/blink/web_tests/external/wpt/css/css-anchor-position/parsing/position-try-fallbacks-parsing.html
    • D third_party/blink/web_tests/external/wpt/css/css-anchor-position/parsing/position-try-options-computed.html
    • D third_party/blink/web_tests/external/wpt/css/css-anchor-position/parsing/position-try-options-parsing.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/parsing/position-try-parsing.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-anchor-001.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-anchor-002.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-001.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-002.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-003.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-004.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-backdrop.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-cascade-layer-reorder.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-cascade.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-container-query.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-custom-property.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-dynamic.html
    • R third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-fallbacks-limit.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-grid-001.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-initial-transition.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-invalid-anchor-crash.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-order-basic.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-order-inset-area.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-position-anchor.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-pseudo-element.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-switch-from-fixed-anchor.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-switch-to-fixed-anchor.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-transition-basic.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-transition-flip.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-tree-scoped.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-try-typed-om.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/property-interpolations-expected.txt
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/property-interpolations.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/try-tactic-alignment.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/try-tactic-anchor.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/try-tactic-back-to-base.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/try-tactic-base.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/try-tactic-basic.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/try-tactic-inset-area.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/try-tactic-margin.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/try-tactic-percentage.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/try-tactic-sizing.html
    • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/try-tactic-wm.html
    • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
    • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
    • M third_party/blink/web_tests/inspector-protocol/css/css-get-position-try.js
    • M third_party/blink/web_tests/inspector-protocol/css/css-set-position-try-rule-style-text-expected.txt
    • M third_party/blink/web_tests/inspector-protocol/css/resources/set-position-try-rule-style-text.css
    • M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
    • M third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
    • M third_party/blink/web_tests/webexposed/css-property-listing-expected.txt
    • M tools/metrics/histograms/enums.xml
    Change size: XL
    Delta: 129 files changed, 818 insertions(+), 699 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Philip Jägenstedt, +1 by Anders Hartvoll Ruud
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9886c8f592e283f2b72be21153d376f1d848e0a4
    Gerrit-Change-Number: 5667406
    Gerrit-PatchSet: 11
    Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    open
    diffy
    satisfied_requirement

    Blink W3C Test Autoroller (Gerrit)

    unread,
    Jul 4, 2024, 10:14:04 AMJul 4
    to Rune Lillesveen, Chromium LUCI CQ, Philip Jägenstedt, Anders Hartvoll Ruud, Alex Rudenko, Olga Gerchikov, Daniel Cheng, AyeAye, Alexis Menard, David Bokan, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

    Message from Blink W3C Test Autoroller

    The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/47003

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9886c8f592e283f2b72be21153d376f1d848e0a4
    Gerrit-Change-Number: 5667406
    Gerrit-PatchSet: 11
    Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Comment-Date: Thu, 04 Jul 2024 14:13:53 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages