Collect screenshots from successful results too [devtools/devtools-frontend : main]

[Nikolay Vitkov (Gerrit)]

Attention needed from Liviu Rau

Nikolay Vitkov voted and added 1 comment

Votes added by Nikolay Vitkov

Code-Review

+1

1 comment

File scripts/eslint_rules/lib/no-capture-screenshot.ts

Line 27, Patchset 2 (Latest): description: 'Disallow usage of captureScreenshot, which is a debugging tool.',

Nikolay Vitkov . unresolved

Nit: devToolsPage.captureScreenshot

Open in Gerrit

Related details

Attention is currently required from:

• Liviu Rau

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: devtools/devtools-frontend

Gerrit-Branch: main

Gerrit-Change-Id: I108266c4769941fd7371f32323a68c032672851c

Gerrit-Change-Number: 6976247

Gerrit-PatchSet: 2

Gerrit-Owner: Liviu Rau <livi...@chromium.org>

Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>

Gerrit-Attention: Liviu Rau <livi...@chromium.org>

Gerrit-Comment-Date: Tue, 23 Sep 2025 14:57:20 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Liviu Rau (Gerrit)]

Liviu Rau voted and added 1 comment

Votes added by Liviu Rau

Commit-Queue

+2

1 comment

File scripts/eslint_rules/lib/no-capture-screenshot.ts

Line 27, Patchset 2 (Latest): description: 'Disallow usage of captureScreenshot, which is a debugging tool.',

Nikolay Vitkov . resolved

Nit: devToolsPage.captureScreenshot

Liviu Rau

Fix applied.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: devtools/devtools-frontend

Gerrit-Branch: main

Gerrit-Change-Id: I108266c4769941fd7371f32323a68c032672851c

Gerrit-Change-Number: 6976247

Gerrit-PatchSet: 2

Gerrit-Owner: Liviu Rau <livi...@chromium.org>

Gerrit-Reviewer: Liviu Rau <livi...@chromium.org>

Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>

Gerrit-Comment-Date: Tue, 23 Sep 2025 15:08:50 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Nikolay Vitkov <nvi...@chromium.org>

[Devtools-frontend LUCI CQ (Gerrit)]

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:

Collect screenshots from successful results too

Bug: none

Change-Id: I108266c4769941fd7371f32323a68c032672851c

Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6976247

Reviewed-by: Nikolay Vitkov <nvi...@chromium.org>

Commit-Queue: Liviu Rau <livi...@chromium.org>

Files:

• M eslint.config.mjs
• A scripts/eslint_rules/lib/no-capture-screenshot.ts
• A scripts/eslint_rules/tests/no-capture-screenshot.test.ts
• M test/conductor/screenshot-error.ts
• M test/shared/mocha-resultsdb-reporter.ts

Change size: M

Delta: 5 files changed, 98 insertions(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Nikolay Vitkov

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: devtools/devtools-frontend

Gerrit-Branch: main

Gerrit-Change-Id: I108266c4769941fd7371f32323a68c032672851c

Gerrit-Change-Number: 6976247

Gerrit-PatchSet: 3

Gerrit-Owner: Liviu Rau <livi...@chromium.org>

Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>