[cleanup] Extract props for different widgets in AIAssistancePanel [devtools/devtools-frontend : main]
Nikolay Vitkov (Gerrit)
Nikolay Vitkov voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
- Ergün Erdoğmuş
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ergün Erdoğmuş (Gerrit)
Ergün Erdoğmuş voted and added 4 comments![]( "Open in Gerrit")
Votes added by Ergün Erdoğmuş
| Code-Review | +1 |
4 comments
type PanelViewProps = {(nit): Just for consistency with `ToolbarViewInput`, WDYT of naming this `PanelViewInput`?
async #getPanelViewStateWithProps(): Promise<PanelViewProps> {(nit): We can call this `getPanelViewInput`, and also create a separate one `getToolbarViewInput` and then in the `performUpdate` method, we can combine them as:
```
{
...this.#getToolbarViewInput(),
...await this.#getPanelViewInput(),
}
```
Otherwise, I find it a bit trickier to understand why we still have `isLoading` etc. in the `performUpdate` method and realized that they are for the `ToolbarViewInput`.
'has-conversation': true,(nit): Now that we only render this footer when there is a conversation, we don't need the `has-conversation` modifier and we can directly add the hiding/showing logic from `.has-conversation` CSS rule to the `chat-view-footer`.
conversationType?: AiAssistanceModel.AiHistoryStorage.ConversationType,We can mark this as non optional now as well.
Related details
- Nikolay Vitkov
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
Nikolay Vitkov added 4 comments![]( "Open in Gerrit")
type PanelViewProps = {(nit): Just for consistency with `ToolbarViewInput`, WDYT of naming this `PanelViewInput`?
Done
async #getPanelViewStateWithProps(): Promise<PanelViewProps> {(nit): We can call this `getPanelViewInput`, and also create a separate one `getToolbarViewInput` and then in the `performUpdate` method, we can combine them as:
```
{
...this.#getToolbarViewInput(),
...await this.#getPanelViewInput(),
}
```Otherwise, I find it a bit trickier to understand why we still have `isLoading` etc. in the `performUpdate` method and realized that they are for the `ToolbarViewInput`.
Done
'has-conversation': true,(nit): Now that we only render this footer when there is a conversation, we don't need the `has-conversation` modifier and we can directly add the hiding/showing logic from `.has-conversation` CSS rule to the `chat-view-footer`.
Done
conversationType?: AiAssistanceModel.AiHistoryStorage.ConversationType,We can mark this as non optional now as well.
No we can just remove it :P
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |