For AI suggestions, do not accept suggestion on stop characters [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Samiya Caur (Gerrit)
7:20 AM (8 hours ago) 7:20 AM
to Alex Rudenko, devtools-rev...@chromium.org
Attention needed from Alex Rudenko
Samiya Caur voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
7:24 AM (8 hours ago) 7:24 AM
to Samiya Caur, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Samiya Caur
Alex Rudenko added 1 comment![]( "Open in Gerrit")
File front_end/panels/elements/StylePropertyTreeElement.ts
Line 3640, Patchset 1 (Latest):
this.prompt.applySuggestion({text: activeAiSuggestion.name, isAiCodeCompletion: true}, true);Alex Rudenko . unresolved
can we name this `acceptSuggestionOnStopCharacters: false` instead of isAiCodeCompletion because I do not think UI layer should know about AI vs non-AI suggestions?
Related details
Attention is currently required from:
- Samiya Caur
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samiya Caur (Gerrit)
7:33 AM (8 hours ago) 7:33 AM
to devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, Alex Rudenko, devtools-rev...@chromium.org
Attention needed from Alex Rudenko
Samiya Caur voted and added 1 comment![]( "Open in Gerrit")
Votes added by Samiya Caur
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
File front_end/panels/elements/StylePropertyTreeElement.ts
Line 3640, Patchset 1:
this.prompt.applySuggestion({text: activeAiSuggestion.name, isAiCodeCompletion: true}, true);Alex Rudenko . resolved
can we name this `acceptSuggestionOnStopCharacters: false` instead of isAiCodeCompletion because I do not think UI layer should know about AI vs non-AI suggestions?
Samiya Caur
Named it `disableAcceptSuggestionOnStopCharacters` so that it can be false by default
Related details
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
7:45 AM (8 hours ago) 7:45 AM
to Samiya Caur, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Samiya Caur
Alex Rudenko voted![]( "Open in Gerrit")
Attention is currently required from:
- Samiya Caur
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
8:35 AM (7 hours ago) 8:35 AM
to Samiya Caur, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Samiya Caur
Alex Rudenko voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Samiya Caur
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
9:10 AM (7 hours ago) 9:10 AM
to Samiya Caur, Alex Rudenko, devtools-rev...@chromium.org
devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
For AI suggestions, do not accept suggestion on stop characters
Fixed: 508153374
Change-Id: I505119eb1a86458273b32f19be58e7a595b48023
Auto-Submit: Samiya Caur <sam...@chromium.org>
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Commit-Queue: Alex Rudenko <alexr...@chromium.org>
Commit-Queue: Samiya Caur <sam...@chromium.org>
Files:
- M front_end/panels/elements/StylePropertyTreeElement.test.ts
- M front_end/panels/elements/StylePropertyTreeElement.ts
- M front_end/panels/elements/StylesSidebarPane.ts
- M front_end/ui/legacy/SuggestBox.ts
- M front_end/ui/legacy/TextPrompt.ts
Change size: S
Delta: 5 files changed, 10 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Rudenko
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages