[GreenDev] Let agent execute JS in console and apply a fix to sources [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Alina Varkki (Gerrit)
10:02 AM (5 hours ago) 10:02 AM
to Jack Franklin, devtools-rev...@chromium.org
Attention needed from Jack Franklin
Alina Varkki voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alina Varkki
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
12:49 PM (2 hours ago) 12:49 PM
to Alina Varkki, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alina Varkki
Jack Franklin voted and added 2 comments![]( "Open in Gerrit")
Votes added by Jack Franklin
| Code-Review | +1 |
2 comments
Patchset-level comments
Jack Franklin . resolved
lgtm with one Q
File front_end/models/ai_assistance/agents/BreakpointDebuggerAgent.ts
Line 365, Patchset 1 (Latest):
this.declareFunction('testFixInConsole', {Jack Franklin . unresolved
just checking: this has to ask the user for permission right?
Related details
Attention is currently required from:
- Alina Varkki
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alina Varkki (Gerrit)
12:56 PM (2 hours ago) 12:56 PM
to Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Jack Franklin
Alina Varkki added 1 comment![]( "Open in Gerrit")
File front_end/models/ai_assistance/agents/BreakpointDebuggerAgent.ts
Line 365, Patchset 1 (Latest):
this.declareFunction('testFixInConsole', {Jack Franklin . unresolved
just checking: this has to ask the user for permission right?
Alina Varkki
yes! `options` contains the approval. The other agents suggesting changes have it the same way
Related details
Attention is currently required from:
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alina Varkki (Gerrit)
12:56 PM (2 hours ago) 12:56 PM
to Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Jack Franklin
Alina Varkki added 1 comment![]( "Open in Gerrit")
File front_end/models/ai_assistance/agents/BreakpointDebuggerAgent.ts
Line 365, Patchset 1 (Latest):
this.declareFunction('testFixInConsole', {Jack Franklin . resolved
Alina Varkkijust checking: this has to ask the user for permission right?
yes! `options` contains the approval. The other agents suggesting changes have it the same way
Alina Varkki
Done
Related details
Attention is currently required from:
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
12:57 PM (2 hours ago) 12:57 PM
to Alina Varkki, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alina Varkki
Jack Franklin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Alina Varkki
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
12:58 PM (2 hours ago) 12:58 PM
to Alina Varkki, Jack Franklin, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[GreenDev] Let agent execute JS in console and apply a fix to sources
Give the agent an ability to run JS to overwrite functions and make sure a potential fix is correct and if it is, apply it to the file
Bug: 480779816
Change-Id: Ia51ea28c8f905c66b45b91389ecef82a83026f8b
Reviewed-by: Jack Franklin <jacktf...@chromium.org>
Commit-Queue: Alina Varkki <alina...@chromium.org>
Auto-Submit: Alina Varkki <alina...@chromium.org>
Files:
- M front_end/models/ai_assistance/agents/BreakpointDebuggerAgent.ts
Change size: L
Delta: 1 file changed, 264 insertions(+), 19 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jack Franklin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages