[autosizer] Fix text-size-adjust regression on Android [chromium/src : main]
0 views
Skip to first unread message
David Grogan (Gerrit)
May 2, 2026, 8:01:52 PM (2 days ago) May 2
to David Grogan, Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, James Su, android-bu...@system.gserviceaccount.com, shuche...@chromium.org, nona+...@chromium.org, yhanad...@chromium.org, tranbaod...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, blink-...@chromium.org, alexmo...@chromium.org, devtools-re...@chromium.org
Attention needed from Ian Kilpatrick
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Grogan (Gerrit)
May 2, 2026, 8:04:26 PM (2 days ago) May 2
to David Grogan, Charlie Reis, Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, James Su, android-bu...@system.gserviceaccount.com, shuche...@chromium.org, nona+...@chromium.org, yhanad...@chromium.org, tranbaod...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, blink-...@chromium.org, alexmo...@chromium.org, devtools-re...@chromium.org
Attention needed from Charlie Reis and Ian Kilpatrick
David Grogan added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
David Grogan . resolved
+creis for content/browser/renderer_host/render_widget_host_view_android_browsertest.cc
Related details
Attention is currently required from:
- Charlie Reis
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
May 2, 2026, 9:39:31 PM (2 days ago) May 2
to David Grogan, Charlie Reis, Chromium LUCI CQ, chromium...@chromium.org, James Su, android-bu...@system.gserviceaccount.com, shuche...@chromium.org, nona+...@chromium.org, yhanad...@chromium.org, tranbaod...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, blink-...@chromium.org, alexmo...@chromium.org, devtools-re...@chromium.org
Attention needed from Charlie Reis and David Grogan
Ian Kilpatrick voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Charlie Reis
- David Grogan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Charlie Reis (Gerrit)
12:05 PM (4 hours ago) 12:05 PM
to David Grogan, Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, James Su, android-bu...@system.gserviceaccount.com, shuche...@chromium.org, nona+...@chromium.org, yhanad...@chromium.org, tranbaod...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, blink-...@chromium.org, alexmo...@chromium.org, devtools-re...@chromium.org
Charlie Reis voted and added 2 comments![]( "Open in Gerrit")
Votes added by Charlie Reis
| Code-Review | +1 |
2 comments
Patchset-level comments
Charlie Reis . resolved
Thanks for adding the test. content/ LGTM, given Ian's review.
Commit Message
Line 23, Patchset 4 (Latest):
Change-Id: I89674c7ac9b971e72a84cad7405d0ccda3cd6d9dCharlie Reis . unresolved
Can you include a Bug number, either 391990606 or one for the regression described? That helps with preserving context. Thanks!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Grogan (Gerrit)
1:04 PM (3 hours ago) 1:04 PM
to David Grogan, Charlie Reis, Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, James Su, android-bu...@system.gserviceaccount.com, shuche...@chromium.org, nona+...@chromium.org, yhanad...@chromium.org, tranbaod...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, blink-...@chromium.org, alexmo...@chromium.org, devtools-re...@chromium.org
David Grogan voted and added 1 comment![]( "Open in Gerrit")
Votes added by David Grogan
| Commit-Queue | +2 |
1 comment
Commit Message
Can you include a Bug number, either 391990606 or one for the regression described? That helps with preserving context. Thanks!
David Grogan
Yes, done.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:16 PM (2 hours ago) 1:16 PM
to David Grogan, Charlie Reis, Ian Kilpatrick, chromium...@chromium.org, James Su, android-bu...@system.gserviceaccount.com, shuche...@chromium.org, nona+...@chromium.org, yhanad...@chromium.org, tranbaod...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, blink-...@chromium.org, alexmo...@chromium.org, devtools-re...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[autosizer] Fix text-size-adjust regression on Android
https://crrev.com/01e8022225d introduced the text_size_adjust_enabled
WebPreference but failed to wire it up in WebView::ApplyWebPreferences.
Because this preference never propagated to Blink's WebSettings, the
text-size-adjust property stopped working on Android.
This CL fixes that regression in web_view_impl.cc. Because this is the
second time I've regressed this in the last year, I'm including an
Android-specific content browser test to verify the default settings.
Additionally, this CL updates DevToolsEmulator to enable text-size-
adjust when mobile emulation is turned on. A new inspector-protocol test
is included to verify.
Cq-Do-Not-Cancel-Tryjobs: true
Bug: 391990606
Change-Id: I89674c7ac9b971e72a84cad7405d0ccda3cd6d9d
Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
Reviewed-by: Charlie Reis <cr...@chromium.org>
Commit-Queue: David Grogan <dgr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1624784}
Files:
- M content/browser/renderer_host/render_widget_host_view_android_browsertest.cc
- M third_party/blink/renderer/core/exported/web_view_impl.cc
- M third_party/blink/renderer/core/inspector/dev_tools_emulator.cc
- M third_party/blink/renderer/core/inspector/dev_tools_emulator.h
- A third_party/blink/web_tests/inspector-protocol/emulation/device-emulation-text-size-adjust-expected.txt
- A third_party/blink/web_tests/inspector-protocol/emulation/device-emulation-text-size-adjust.js
Change size: M
Delta: 6 files changed, 74 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Charlie Reis, +1 by Ian Kilpatrick
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages