[RPP]: Make one row Interactions and Animations tracks non expandable [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Paul Irish (Gerrit)
Feb 9, 2026, 12:34:45 PMFeb 9
to Jack Franklin, devtools-rev...@chromium.org
Attention needed from Jack Franklin
Paul Irish voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
Feb 10, 2026, 4:14:13 AMFeb 10
to Paul Irish, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Paul Irish
Jack Franklin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jack Franklin
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Paul Irish
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
Feb 10, 2026, 12:07:25 PMFeb 10
to Paul Irish, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Paul Irish
Jack Franklin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jack Franklin
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Paul Irish
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Irish (Gerrit)
Feb 10, 2026, 1:50:03 PMFeb 10
to Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Paul Irish voted![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Feb 11, 2026, 2:11:02 AMFeb 11
to Paul Irish, Jack Franklin, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[RPP]: Make one row Interactions and Animations tracks non expandable
This CL updates the Interactions and Animations tracks to use
GroupCollapsibleState.IF_MULTI_ROW. This ensures that the
expand/collapse arrow is hidden if the track content fits within a
single row, reducing visual noise and aligning behavior with the
Timings and Custom tracks.
Bug: 481076667, 443216198
Fixed: 481076667
Change-Id: I69bc2fb8a45e8a7cdeed88ab263721a337507b38
Reviewed-by: Jack Franklin <jacktf...@chromium.org>
Auto-Submit: Paul Irish <paul...@chromium.org>
Commit-Queue: Paul Irish <paul...@chromium.org>
Files:
- M front_end/panels/timeline/AnimationsTrackAppender.ts
- M front_end/panels/timeline/InteractionsTrackAppender.ts
- M test/goldens/linux/timeline/animations_track.png
- M test/goldens/linux/timeline/flamechart_view_network_collapsed.png
- M test/goldens/linux/timeline/flamechart_view_network_expanded.png
- M test/goldens/linux/timeline/interactions_track.png
- M test/goldens/linux/timeline/interactions_track_candystripe.png
- M test/goldens/linux/timeline/timeline_with_main_thread_selection.png
- M test/goldens/linux/timeline/timeline_with_network_selection.png
Change size: XS
Delta: 9 files changed, 5 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jack Franklin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages