Refactor ElementsTreeElement to be more declarative [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Alex Rudenko (Gerrit)

unread,
Nov 3, 2025, 9:18:25 AM (yesterday) Nov 3
to Philip Pfaffe, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe

Alex Rudenko added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Alex Rudenko . resolved

@pfa...@chromium.org PTAL Do you think this would regress update performance in any situations?

Open in Gerrit

Related details

Attention is currently required from:
  • Philip Pfaffe
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I2640ba1028121df46f88efc190e9bfa4b1bbd476
Gerrit-Change-Number: 7107210
Gerrit-PatchSet: 7
Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Comment-Date: Mon, 03 Nov 2025 14:18:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Pfaffe (Gerrit)

unread,
Nov 3, 2025, 1:04:31 PM (yesterday) Nov 3
to Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko

Philip Pfaffe voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Rudenko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I2640ba1028121df46f88efc190e9bfa4b1bbd476
Gerrit-Change-Number: 7107210
Gerrit-PatchSet: 7
Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
Gerrit-Comment-Date: Mon, 03 Nov 2025 18:04:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alex Rudenko (Gerrit)

unread,
4:22 AM (17 hours ago) 4:22 AM
to Philip Pfaffe, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Alex Rudenko voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I2640ba1028121df46f88efc190e9bfa4b1bbd476
Gerrit-Change-Number: 7107210
Gerrit-PatchSet: 7
Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Comment-Date: Tue, 04 Nov 2025 09:22:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
4:25 AM (17 hours ago) 4:25 AM
to Alex Rudenko, Philip Pfaffe, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
Refactor ElementsTreeElement to be more declarative

Includes the layout + some parts of adorners. Will follow-up on making
adorners more declarative declarative and moving other things to the template.
Bug: 407751414
Change-Id: I2640ba1028121df46f88efc190e9bfa4b1bbd476
Commit-Queue: Alex Rudenko <alexr...@chromium.org>
Reviewed-by: Philip Pfaffe <pfa...@chromium.org>
Files:
  • M front_end/panels/elements/ElementsTreeElement.test.ts
  • M front_end/panels/elements/ElementsTreeElement.ts
  • M front_end/panels/elements/ElementsTreeOutline.ts
  • M front_end/testing/SettingsHelpers.ts
Change size: M
Delta: 4 files changed, 130 insertions(+), 98 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Philip Pfaffe
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I2640ba1028121df46f88efc190e9bfa4b1bbd476
Gerrit-Change-Number: 7107210
Gerrit-PatchSet: 8
Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages