Refactor ElementsTreeElement to be more declarative [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Alex Rudenko (Gerrit)
Nov 3, 2025, 9:18:25 AM (yesterday) Nov 3
to Philip Pfaffe, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe
Alex Rudenko added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Alex Rudenko . resolved
@pfa...@chromium.org PTAL Do you think this would regress update performance in any situations?
Related details
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
Nov 3, 2025, 1:04:31 PM (yesterday) Nov 3
to Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko
Philip Pfaffe voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
4:22 AM (17 hours ago) 4:22 AM
to Philip Pfaffe, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Alex Rudenko voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
4:25 AM (17 hours ago) 4:25 AM
to Alex Rudenko, Philip Pfaffe, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Refactor ElementsTreeElement to be more declarative
Includes the layout + some parts of adorners. Will follow-up on making
adorners more declarative declarative and moving other things to the template.
Bug: 407751414
Change-Id: I2640ba1028121df46f88efc190e9bfa4b1bbd476
Commit-Queue: Alex Rudenko <alexr...@chromium.org>
Reviewed-by: Philip Pfaffe <pfa...@chromium.org>
Files:
- M front_end/panels/elements/ElementsTreeElement.test.ts
- M front_end/panels/elements/ElementsTreeElement.ts
- M front_end/panels/elements/ElementsTreeOutline.ts
- M front_end/testing/SettingsHelpers.ts
Change size: M
Delta: 4 files changed, 130 insertions(+), 98 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Philip Pfaffe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages