Enhance luminosity for keybinds editing and hover states in High Contrast themes. [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Kim-Anh Tran (Gerrit)

unread,
Mar 18, 2026, 1:15:30 AM (6 days ago) Mar 18
to Sylvester Elorm Coch, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Sylvester Elorm Coch

Kim-Anh Tran added 2 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Kim-Anh Tran . resolved

Hi Elorm, thanks for the patch! Generally LGTM, one question!

File front_end/panels/settings/keybindsSettingsTab.css
Line 38, Patchset 3 (Latest):@media (forced-colors: none) {
Kim-Anh Tran . unresolved

Why is it necessary to introduce the `forced-colors:none` case here?

Open in Gerrit

Related details

Attention is currently required from:
  • Sylvester Elorm Coch
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Icf7fb7fb2be9664ff05c4b25c66ecb190a357dc0
Gerrit-Change-Number: 7676859
Gerrit-PatchSet: 3
Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Reviewer: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Comment-Date: Wed, 18 Mar 2026 05:15:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Sylvester Elorm Coch (Gerrit)

unread,
Mar 18, 2026, 12:40:16 PM (6 days ago) Mar 18
to Devtools-frontend LUCI CQ, Kim-Anh Tran, devtools-rev...@chromium.org
Attention needed from Kim-Anh Tran

Sylvester Elorm Coch added 1 comment

File front_end/panels/settings/keybindsSettingsTab.css
Line 38, Patchset 3 (Latest):@media (forced-colors: none) {
Kim-Anh Tran . unresolved

Why is it necessary to introduce the `forced-colors:none` case here?

Sylvester Elorm Coch

The `@media (forced-colors: none)` wrapper ensures these styles are only applied when high contrast mode is not active. Without it, these rules would also apply in forced-colors mode and conflict with the `@media (forced-colors: active)` block at the bottom of the file

Open in Gerrit

Related details

Attention is currently required from:
  • Kim-Anh Tran
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Icf7fb7fb2be9664ff05c4b25c66ecb190a357dc0
Gerrit-Change-Number: 7676859
Gerrit-PatchSet: 3
Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Reviewer: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Comment-Date: Wed, 18 Mar 2026 16:40:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kim-Anh Tran <kim...@chromium.org>
unsatisfied_requirement
open
diffy

Kim-Anh Tran (Gerrit)

unread,
Mar 23, 2026, 3:40:45 AM (yesterday) Mar 23
to Sylvester Elorm Coch, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Sylvester Elorm Coch

Kim-Anh Tran added 2 comments

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Kim-Anh Tran . resolved

Sorry for my late answer here, I had it as a draft but forgot to send it out!

File front_end/panels/settings/keybindsSettingsTab.css
Line 38, Patchset 3:@media (forced-colors: none) {
Kim-Anh Tran . unresolved

Why is it necessary to introduce the `forced-colors:none` case here?

Sylvester Elorm Coch

The `@media (forced-colors: none)` wrapper ensures these styles are only applied when high contrast mode is not active. Without it, these rules would also apply in forced-colors mode and conflict with the `@media (forced-colors: active)` block at the bottom of the file

Kim-Anh Tran

It's the same for the whole file though (i.e. everything is applying unless it is overridden, no?). I think my question is: instead of adding the (forced-colors:none) case can we overwrite the rules in the `forced-colors` case?

Open in Gerrit

Related details

Attention is currently required from:
  • Sylvester Elorm Coch
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Icf7fb7fb2be9664ff05c4b25c66ecb190a357dc0
Gerrit-Change-Number: 7676859
Gerrit-PatchSet: 4
Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Reviewer: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Comment-Date: Mon, 23 Mar 2026 07:40:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kim-Anh Tran <kim...@chromium.org>
Comment-In-Reply-To: Sylvester Elorm Coch <elor...@microsoft.com>
unsatisfied_requirement
open
diffy

Sylvester Elorm Coch (Gerrit)

unread,
Mar 23, 2026, 1:45:43 PM (16 hours ago) Mar 23
to Devtools-frontend LUCI CQ, Kim-Anh Tran, devtools-rev...@chromium.org
Attention needed from Kim-Anh Tran

Sylvester Elorm Coch added 1 comment

File front_end/panels/settings/keybindsSettingsTab.css
Line 38, Patchset 3:@media (forced-colors: none) {
Kim-Anh Tran . resolved

Why is it necessary to introduce the `forced-colors:none` case here?

Sylvester Elorm Coch

The `@media (forced-colors: none)` wrapper ensures these styles are only applied when high contrast mode is not active. Without it, these rules would also apply in forced-colors mode and conflict with the `@media (forced-colors: active)` block at the bottom of the file

Kim-Anh Tran

It's the same for the whole file though (i.e. everything is applying unless it is overridden, no?). I think my question is: instead of adding the (forced-colors:none) case can we overwrite the rules in the `forced-colors` case?

Sylvester Elorm Coch

Thanks. I've updated this. The main reason was `.keybinds-list-item.keybinds-editing` in non-forced-colors mode will get repainted over the wrapper even with a more specific override.

So this newest patch structures things a bit different so we just target at the wrapper level instead.

Open in Gerrit

Related details

Attention is currently required from:
  • Kim-Anh Tran
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: Icf7fb7fb2be9664ff05c4b25c66ecb190a357dc0
    Gerrit-Change-Number: 7676859
    Gerrit-PatchSet: 5
    Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
    Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
    Gerrit-Reviewer: Sylvester Elorm Coch <elor...@microsoft.com>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Kim-Anh Tran <kim...@chromium.org>
    Gerrit-Comment-Date: Mon, 23 Mar 2026 17:45:41 +0000
    unsatisfied_requirement
    open
    diffy

    Kim-Anh Tran (Gerrit)

    unread,
    1:18 AM (4 hours ago) 1:18 AM
    to Sylvester Elorm Coch, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
    Attention needed from Sylvester Elorm Coch

    Kim-Anh Tran voted and added 1 comment

    Votes added by Kim-Anh Tran

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 6 (Latest):
    Kim-Anh Tran . resolved

    Perfect, thanks 😊

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Sylvester Elorm Coch
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: Icf7fb7fb2be9664ff05c4b25c66ecb190a357dc0
    Gerrit-Change-Number: 7676859
    Gerrit-PatchSet: 6
    Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
    Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
    Gerrit-Reviewer: Sylvester Elorm Coch <elor...@microsoft.com>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Sylvester Elorm Coch <elor...@microsoft.com>
    Gerrit-Comment-Date: Tue, 24 Mar 2026 05:18:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages