[api] Prepare for deprecation of v8::PropertyCallbackInfo<T>::This() [v8/v8 : main]

0 views
Skip to first unread message

Igor Sheludko (Gerrit)

unread,
6:13 AM (11 hours ago) 6:13 AM
to Toon Verwaest, V8 LUCI CQ, AyeAye, cbruni...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Toon Verwaest

Igor Sheludko voted and added 2 comments

Votes added by Igor Sheludko

Commit-Queue+1

2 comments

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Igor Sheludko . resolved

PTAL

File src/builtins/accessors.cc
Line 89, Patchset 6 (Parent): DirectHandle<JSAny> receiver,
Igor Sheludko . unresolved

Reconfiguration of data property in holder must not involve/touch receiver.

Open in Gerrit

Related details

Attention is currently required from:
  • Toon Verwaest
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ic5d8ba8896e30d8781d1af18960c1cde6ba163f7
Gerrit-Change-Number: 7093356
Gerrit-PatchSet: 6
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Attention: Toon Verwaest <verw...@chromium.org>
Gerrit-Comment-Date: Wed, 05 Nov 2025 11:13:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages