Enable screen.orientation.lock() during DevTools device emulation [chromium/src : main]

[Helmut Januschka (Gerrit)]

Attention needed from Alex Rudenko and Nasko Oskov

Helmut Januschka added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Helmut Januschka . resolved

hello reviewers, thanks in advance for your time, this is the backend part for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7580093

see bug: https://issues.chromium.org/issues/40807290#comment19 for a video of the feature.

please let me know if you want me to address anything!

Open in Gerrit

Related details

Attention is currently required from:

• Alex Rudenko
• Nasko Oskov

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id0fb8f61cb82ca9ee4ec7925440ea5b431951de0

Gerrit-Change-Number: 7580113

Gerrit-PatchSet: 1

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Attention: Nasko Oskov <na...@chromium.org>

Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>

Gerrit-Comment-Date: Mon, 16 Feb 2026 08:00:15 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Alex Rudenko (Gerrit)]

Attention needed from Helmut Januschka, Nasko Oskov and Yang Guo

Alex Rudenko added 2 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Alex Rudenko . unresolved

@yan...@chromium.org does it match the behavior you intended via comments on the issue?

File content/browser/devtools/protocol/emulation_handler.cc

Line 814, Patchset 1 (Latest): UpdateScreenOrientationEmulation(true);

Alex Rudenko . unresolved

I do not think we should enable this by default. We either need a new param on the device emulation or a separate method. How does it work with Emulation.setIdleOverride?

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka
• Nasko Oskov
• Yang Guo

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id0fb8f61cb82ca9ee4ec7925440ea5b431951de0

Gerrit-Change-Number: 7580113

Gerrit-PatchSet: 1

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>

Gerrit-Reviewer: Yang Guo <yan...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Attention: Helmut Januschka <hel...@januschka.com>

Gerrit-Attention: Nasko Oskov <na...@chromium.org>

Gerrit-Attention: Yang Guo <yan...@chromium.org>

Gerrit-Comment-Date: Mon, 16 Feb 2026 09:39:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Yang Guo (Gerrit)]

Attention needed from Helmut Januschka and Nasko Oskov

Yang Guo added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Alex Rudenko . unresolved

@yan...@chromium.org does it match the behavior you intended via comments on the issue?

Yang Guo

Yes. The recorded video (https://g-issues.chromium.org/issues/40807290#comment19) of the implementation is the behavior that I intended.

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka
• Nasko Oskov

Gerrit-Comment-Date: Mon, 16 Feb 2026 10:00:29 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Alex Rudenko <alexr...@chromium.org>

[Alex Rudenko (Gerrit)]

Attention needed from Helmut Januschka and Nasko Oskov

Alex Rudenko added 1 comment

File content/browser/devtools/protocol/emulation_handler.cc

Line 814, Patchset 1 (Latest): UpdateScreenOrientationEmulation(true);

Alex Rudenko . unresolved

I do not think we should enable this by default. We either need a new param on the device emulation or a separate method. How does it work with Emulation.setIdleOverride?

Alex Rudenko

I think also the responsive mode for desktop devices should have this on? as the lock is not supported there.

Gerrit-Comment-Date: Mon, 16 Feb 2026 10:02:20 +0000

[Alex Rudenko (Gerrit)]

Attention needed from Helmut Januschka, Nasko Oskov and Yang Guo

Alex Rudenko added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Alex Rudenko . resolved

@yan...@chromium.org does it match the behavior you intended via comments on the issue?

Yang Guo

Yes. The recorded video (https://g-issues.chromium.org/issues/40807290#comment19) of the implementation is the behavior that I intended.

Alex Rudenko

Ack, thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka
• Nasko Oskov
• Yang Guo

Gerrit-Attention: Yang Guo <yan...@chromium.org>

Gerrit-Comment-Date: Mon, 16 Feb 2026 10:02:43 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Yang Guo <yan...@chromium.org>

Comment-In-Reply-To: Alex Rudenko <alexr...@chromium.org>

[Nasko Oskov (Gerrit)]

Attention needed from Helmut Januschka and Yang Guo

Nasko Oskov added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Nasko Oskov . resolved

I am not DevTools expert, but happy to stamp the web_contents_impl.h change once the DevTools folks are happy with the CL.

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka
• Yang Guo

Gerrit-Attention: Yang Guo <yan...@chromium.org>

Gerrit-Comment-Date: Tue, 17 Feb 2026 17:18:48 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Alex Rudenko (Gerrit)]

Attention needed from Helmut Januschka and Yang Guo

Alex Rudenko added 1 comment

File content/browser/devtools/protocol/emulation_handler.h

Line 217, Patchset 1 (Latest): void OnOrientationLockChanged(

Alex Rudenko . unresolved

Could you please also add the inspector-protocol test for the emulation events and the eventual event opt-in mechanism?

Gerrit-Comment-Date: Wed, 18 Feb 2026 09:33:32 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Helmut Januschka (Gerrit)]

Attention needed from Alex Rudenko and Yang Guo

Helmut Januschka added 2 comments

File content/browser/devtools/protocol/emulation_handler.h

Line 217, Patchset 1: void OnOrientationLockChanged(

Alex Rudenko . resolved

Could you please also add the inspector-protocol test for the emulation events and the eventual event opt-in mechanism?

Helmut Januschka

Done

File content/browser/devtools/protocol/emulation_handler.cc

Line 814, Patchset 1: UpdateScreenOrientationEmulation(true);

Alex Rudenko . resolved

I do not think we should enable this by default. We either need a new param on the device emulation or a separate method. How does it work with Emulation.setIdleOverride?

Alex Rudenko

I think also the responsive mode for desktop devices should have this on? as the lock is not supported there.

Helmut Januschka

Done

Open in Gerrit

Related details

Attention is currently required from:

• Alex Rudenko
• Yang Guo

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id0fb8f61cb82ca9ee4ec7925440ea5b431951de0

Gerrit-Change-Number: 7580113

Gerrit-PatchSet: 2

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>

Gerrit-Reviewer: Yang Guo <yan...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Attention: Yang Guo <yan...@chromium.org>

Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>

Gerrit-Comment-Date: Wed, 18 Feb 2026 22:39:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Alex Rudenko <alexr...@chromium.org>

[Alex Rudenko (Gerrit)]

Attention needed from Helmut Januschka and Yang Guo

Alex Rudenko added 1 comment

File content/browser/devtools/protocol/emulation_handler.h

Line 217, Patchset 1: void OnOrientationLockChanged(

Alex Rudenko . unresolved

Could you please also add the inspector-protocol test for the emulation events and the eventual event opt-in mechanism?

Helmut Januschka

Done

Alex Rudenko

I do not find an inspector-protocol test?

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka
• Yang Guo

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id0fb8f61cb82ca9ee4ec7925440ea5b431951de0

Gerrit-Change-Number: 7580113

Gerrit-PatchSet: 2

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>

Gerrit-Reviewer: Yang Guo <yan...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Attention: Helmut Januschka <hel...@januschka.com>

Gerrit-Attention: Yang Guo <yan...@chromium.org>

Gerrit-Comment-Date: Thu, 19 Feb 2026 09:48:02 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Helmut Januschka <hel...@januschka.com>

Comment-In-Reply-To: Alex Rudenko <alexr...@chromium.org>

[Helmut Januschka (Gerrit)]

Attention needed from Alex Rudenko and Yang Guo

Helmut Januschka added 1 comment

File content/browser/devtools/protocol/emulation_handler.h

Line 217, Patchset 1: void OnOrientationLockChanged(

Alex Rudenko . resolved

Could you please also add the inspector-protocol test for the emulation events and the eventual event opt-in mechanism?

Helmut Januschka

Done

Alex Rudenko

I do not find an inspector-protocol test?

Helmut Januschka

ohh missed to stage!

Open in Gerrit

Related details

Attention is currently required from:

• Alex Rudenko
• Yang Guo

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id0fb8f61cb82ca9ee4ec7925440ea5b431951de0

Gerrit-Change-Number: 7580113

Gerrit-PatchSet: 3

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>

Gerrit-Reviewer: Yang Guo <yan...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Attention: Yang Guo <yan...@chromium.org>

Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>

Gerrit-Comment-Date: Thu, 19 Feb 2026 21:05:47 +0000

[Alex Rudenko (Gerrit)]

Attention needed from Helmut Januschka and Yang Guo

Alex Rudenko added 1 comment

File content/browser/devtools/protocol/emulation_handler.h

Line 217, Patchset 1: void OnOrientationLockChanged(

Alex Rudenko . unresolved

Could you please also add the inspector-protocol test for the emulation events and the eventual event opt-in mechanism?

Helmut Januschka

Done

Alex Rudenko

I do not find an inspector-protocol test?

Helmut Januschka

ohh missed to stage!

Alex Rudenko

I still do not see an inspector-protocol test. We prefer inspector-protocol tests over the C++ browser tests. See https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/inspector-protocol/emulation/

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka
• Yang Guo

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id0fb8f61cb82ca9ee4ec7925440ea5b431951de0

Gerrit-Change-Number: 7580113

Gerrit-PatchSet: 3

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>

Gerrit-Reviewer: Yang Guo <yan...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Attention: Helmut Januschka <hel...@januschka.com>

Gerrit-Attention: Yang Guo <yan...@chromium.org>

Gerrit-Comment-Date: Fri, 20 Feb 2026 07:27:09 +0000

[Helmut Januschka (Gerrit)]

Attention needed from Alex Rudenko and Yang Guo

Helmut Januschka added 1 comment

File content/browser/devtools/protocol/emulation_handler.h

Line 217, Patchset 1: void OnOrientationLockChanged(

Alex Rudenko . resolved

Could you please also add the inspector-protocol test for the emulation events and the eventual event opt-in mechanism?

Helmut Januschka

Done

Alex Rudenko

I do not find an inspector-protocol test?

Helmut Januschka

ohh missed to stage!

Alex Rudenko

I still do not see an inspector-protocol test. We prefer inspector-protocol tests over the C++ browser tests. See https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/inspector-protocol/emulation/

Helmut Januschka

that was suprisingly harder than i hoped 😊

Open in Gerrit

Related details

Attention is currently required from:

• Alex Rudenko
• Yang Guo

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id0fb8f61cb82ca9ee4ec7925440ea5b431951de0

Gerrit-Change-Number: 7580113

Gerrit-PatchSet: 4

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>

Gerrit-Reviewer: Yang Guo <yan...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Attention: Yang Guo <yan...@chromium.org>

Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>

Gerrit-Comment-Date: Fri, 20 Feb 2026 23:54:23 +0000

[Alex Rudenko (Gerrit)]

Attention needed from Helmut Januschka and Yang Guo

Alex Rudenko voted and added 1 comment

Votes added by Alex Rudenko

Code-Review

+1

1 comment

File content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Line 1423, Patchset 4 (Latest):IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest,

Alex Rudenko . unresolved

I believe we can remove this test?

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka
• Yang Guo

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id0fb8f61cb82ca9ee4ec7925440ea5b431951de0

Gerrit-Change-Number: 7580113

Gerrit-PatchSet: 4

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>

Gerrit-Reviewer: Yang Guo <yan...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Attention: Helmut Januschka <hel...@januschka.com>

Gerrit-Attention: Yang Guo <yan...@chromium.org>

Gerrit-Comment-Date: Mon, 23 Feb 2026 10:18:14 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Helmut Januschka (Gerrit)]

Attention needed from Yang Guo

Helmut Januschka added 1 comment

File content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Line 1423, Patchset 4:IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest,

Alex Rudenko . resolved

I believe we can remove this test?

Helmut Januschka

Done

Open in Gerrit

Related details

Attention is currently required from:

• Yang Guo

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id0fb8f61cb82ca9ee4ec7925440ea5b431951de0

Gerrit-Change-Number: 7580113

Gerrit-PatchSet: 5

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>

Gerrit-Reviewer: Yang Guo <yan...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Attention: Yang Guo <yan...@chromium.org>

Gerrit-Comment-Date: Mon, 23 Feb 2026 21:48:41 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Alex Rudenko <alexr...@chromium.org>

[Helmut Januschka (Gerrit)]

Attention needed from Nasko Oskov and Yang Guo

Helmut Januschka added 1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Helmut Januschka . resolved

@na...@chromium.org devtools part is CR+1'd and also the corresponding devtool CL is CR+1, could you stamp/review?

Open in Gerrit

Related details

Attention is currently required from:

• Nasko Oskov
• Yang Guo

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id0fb8f61cb82ca9ee4ec7925440ea5b431951de0

Gerrit-Change-Number: 7580113

Gerrit-PatchSet: 6

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>

Gerrit-Reviewer: Yang Guo <yan...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Attention: Nasko Oskov <na...@chromium.org>

Gerrit-Attention: Yang Guo <yan...@chromium.org>

Gerrit-Comment-Date: Mon, 02 Mar 2026 07:31:47 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Nasko Oskov (Gerrit)]

Attention needed from Helmut Januschka and Yang Guo

Nasko Oskov voted and added 1 comment

Votes added by Nasko Oskov

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Nasko Oskov . resolved

web_contents_impl.h and mojom changes LGTM.

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka
• Yang Guo

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id0fb8f61cb82ca9ee4ec7925440ea5b431951de0

Gerrit-Change-Number: 7580113

Gerrit-PatchSet: 6

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>

Gerrit-Reviewer: Yang Guo <yan...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Attention: Helmut Januschka <hel...@januschka.com>

Gerrit-Attention: Yang Guo <yan...@chromium.org>

Gerrit-Comment-Date: Tue, 03 Mar 2026 04:42:56 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Helmut Januschka (Gerrit)]

Attention needed from Yang Guo

Helmut Januschka voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• Yang Guo

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id0fb8f61cb82ca9ee4ec7925440ea5b431951de0

Gerrit-Change-Number: 7580113

Gerrit-PatchSet: 6

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>

Gerrit-Reviewer: Yang Guo <yan...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Attention: Yang Guo <yan...@chromium.org>

Gerrit-Comment-Date: Tue, 03 Mar 2026 16:34:08 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Enable screen.orientation.lock() during DevTools device emulation

Allow ScreenOrientationProvider to succeed without a platform delegate when
DevTools emulation is active, and fire a new CDP event
screenOrientationLockChanged so the frontend can react to lock/unlock calls.

Bug: 40807290

Change-Id: Id0fb8f61cb82ca9ee4ec7925440ea5b431951de0

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7580113

Reviewed-by: Nasko Oskov <na...@chromium.org>

Reviewed-by: Alex Rudenko <alexr...@chromium.org>

Commit-Queue: Helmut Januschka <hel...@januschka.com>

Cr-Commit-Position: refs/heads/main@{#1593327}

Files:

• M content/browser/devtools/protocol/devtools_protocol_browsertest.cc
• M content/browser/devtools/protocol/emulation_handler.cc
• M content/browser/devtools/protocol/emulation_handler.h
• M content/browser/screen_orientation/screen_orientation_provider.cc
• M content/browser/screen_orientation/screen_orientation_provider.h
• M content/browser/screen_orientation/screen_orientation_provider_unittest.cc
• M content/browser/web_contents/web_contents_impl.h
• M content/web_test/browser/web_test_control_host.cc
• M content/web_test/browser/web_test_control_host.h
• M content/web_test/common/web_test.mojom
• M content/web_test/renderer/test_runner.cc
• M third_party/blink/public/devtools_protocol/domains/Emulation.pdl
• M third_party/blink/renderer/core/inspector/inspector_emulation_agent.cc
• M third_party/blink/renderer/core/inspector/inspector_emulation_agent.h
• A third_party/blink/web_tests/inspector-protocol/emulation/screen-orientation-lock-emulation-event-opt-in-expected.txt
• A third_party/blink/web_tests/inspector-protocol/emulation/screen-orientation-lock-emulation-event-opt-in.js

Change size: L

Delta: 16 files changed, 491 insertions(+), 5 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Alex Rudenko, +1 by Nasko Oskov

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id0fb8f61cb82ca9ee4ec7925440ea5b431951de0

Gerrit-Change-Number: 7580113

Gerrit-PatchSet: 7

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>

Gerrit-Reviewer: Yang Guo <yan...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org