[AI] Correctly ignore errors in AgentFocus.lookupEvent [devtools/devtools-frontend : main]

0 views

Skip to first unread message

Connor Clark (Gerrit)

unread,

Sep 23, 2025, 5:55:06 PM (2 days ago) Sep 23

to Paul Irish, devtools-rev...@chromium.org

Attention needed from Paul Irish

Connor Clark voted Auto-Submit+1

Auto-Submit

Open in Gerrit

Related details

Attention is currently required from:

Paul Irish

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Paul Irish (Gerrit)

unread,

Sep 23, 2025, 5:56:01 PM (2 days ago) Sep 23

to Connor Clark, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Attention needed from Connor Clark

Paul Irish voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Connor Clark

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,

Sep 23, 2025, 6:41:11 PM (2 days ago) Sep 23

to Connor Clark, Paul Irish, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:

[AI] Correctly ignore errors in AgentFocus.lookupEvent

This function is meant to ignore unknown keys, which typically throws
an error. But it missed some error cases.

Bug: 425270067

Change-Id: I0153ffc6914e6356b35c618d43937d0d77c54f6a

Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6976319

Commit-Queue: Connor Clark <cja...@chromium.org>

Commit-Queue: Paul Irish <paul...@chromium.org>

Auto-Submit: Connor Clark <cja...@chromium.org>

Reviewed-by: Paul Irish <paul...@chromium.org>

Files:

M front_end/models/ai_assistance/performance/AIContext.ts
M front_end/models/trace/EventsSerializer.ts

Change size: XS

Delta: 2 files changed, 5 insertions(+), 4 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Paul Irish

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages