Add filtering ids to browser protocol [chromium/src : main]
0 views
Skip to first unread message
Anthony Garant (Gerrit)
Jul 2, 2024, 12:30:30 PMJul 2
to Andrew Paseltiner, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Andrew Paseltiner
Anthony Garant voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Andrew Paseltiner
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Paseltiner (Gerrit)
Jul 2, 2024, 12:36:55 PMJul 2
to Anthony Garant, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Anthony Garant
Andrew Paseltiner added 1 comment![]( "Open in Gerrit")
File third_party/blink/public/devtools_protocol/browser_protocol.pdl
Line 10540, Patchset 3 (Latest):
number filteringIdAndrew Paseltiner . unresolved
IMO we should add a test case that exercises a large value, as I'm skeptical that `number` works here. See, for example, the use of `UnsignedInt64AsBase10 data` field below.
Related details
Attention is currently required from:
- Anthony Garant
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anthony Garant (Gerrit)
Jul 2, 2024, 1:43:11 PMJul 2
to Andrew Paseltiner, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Andrew Paseltiner
Anthony Garant voted and added 1 comment![]( "Open in Gerrit")
Votes added by Anthony Garant
| Commit-Queue | +1 |
1 comment
File third_party/blink/public/devtools_protocol/browser_protocol.pdl
Line 10540, Patchset 3:
number filteringIdAndrew Paseltiner . unresolved
IMO we should add a test case that exercises a large value, as I'm skeptical that `number` works here. See, for example, the use of `UnsignedInt64AsBase10 data` field below.
Anthony Garant
By setting the biggest uint64
18446744073709551615
I get
18446744073709552000
I updated to a string to avoid this. I think that it makes sense given that the value is specified with a string in the header.
Related details
Attention is currently required from:
- Andrew Paseltiner
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Paseltiner (Gerrit)
Jul 2, 2024, 1:45:18 PMJul 2
to Anthony Garant, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Anthony Garant
Andrew Paseltiner added 2 comments![]( "Open in Gerrit")
File third_party/blink/public/devtools_protocol/browser_protocol.pdl
Line 10540, Patchset 3:
number filteringIdAndrew Paseltiner . resolved
Anthony GarantIMO we should add a test case that exercises a large value, as I'm skeptical that `number` works here. See, for example, the use of `UnsignedInt64AsBase10 data` field below.
By setting the biggest uint64
18446744073709551615I get
18446744073709552000I updated to a string to avoid this. I think that it makes sense given that the value is specified with a string in the header.
Andrew Paseltiner
Acknowledged
Line 10538, Patchset 4 (Latest):
# string instead of integer or number because not all uint64 can be
# represented by an integer or a number.
string filteringIdAndrew Paseltiner . unresolved
```suggestion
UnsignedInt64AsBase10 filteringId
```
Related details
Attention is currently required from:
- Anthony Garant
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anthony Garant (Gerrit)
Jul 2, 2024, 2:24:32 PMJul 2
to Andrew Paseltiner, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Andrew Paseltiner
Anthony Garant voted and added 1 comment![]( "Open in Gerrit")
Votes added by Anthony Garant
| Commit-Queue | +1 |
1 comment
File third_party/blink/public/devtools_protocol/browser_protocol.pdl
Line 10538, Patchset 4:
# string instead of integer or number because not all uint64 can be
# represented by an integer or a number.
string filteringIdAndrew Paseltiner . resolved
Anthony Garant```suggestion
UnsignedInt64AsBase10 filteringId
```
Done
Related details
Attention is currently required from:
- Andrew Paseltiner
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Paseltiner (Gerrit)
Jul 2, 2024, 2:25:06 PMJul 2
to Anthony Garant, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Anthony Garant
Andrew Paseltiner voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Anthony Garant
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anthony Garant (Gerrit)
Jul 8, 2024, 4:56:21 PM (14 days ago) Jul 8
to Kent Tamura, Andrey Kosyakov, Andrew Paseltiner, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Andrey Kosyakov
Anthony Garant removed Kent Tamura from this change![]( "Open in Gerrit")
Attention is currently required from:
- Andrey Kosyakov
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Jul 8, 2024, 4:59:26 PM (14 days ago) Jul 8
to Anthony Garant, Andrew Paseltiner, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Anthony Garant
Andrey Kosyakov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andrey Kosyakov
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Anthony Garant
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anthony Garant (Gerrit)
Jul 8, 2024, 4:59:59 PM (14 days ago) Jul 8
to Andrey Kosyakov, Andrew Paseltiner, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Anthony Garant voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 8, 2024, 5:54:54 PM (14 days ago) Jul 8
to Anthony Garant, Andrey Kosyakov, Andrew Paseltiner, chromium...@chromium.org, devtools...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add filtering ids to browser protocol
The information is reported even when filtering IDs is not enabled.
In that situation, the default values (0 for filtering id and 1 for
max bytes) are used.
Bug: 345274918
Change-Id: I8098a7d28f3a8ea34ba23727a57f6b186cd4c708
Reviewed-by: Andrew Paseltiner <apase...@chromium.org>
Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
Commit-Queue: Anthony Garant <anthon...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1324518}
Files:
- M content/browser/devtools/protocol/storage_handler.cc
- M third_party/blink/public/devtools_protocol/browser_protocol.pdl
- M third_party/blink/web_tests/http/tests/inspector-protocol/attribution-reporting/trigger-registered-expected.txt
Change size: S
Delta: 3 files changed, 10 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andrey Kosyakov, +1 by Andrew Paseltiner
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages