[TabBottomSheet] Shift inactive placeholder setup to the provider [chromium/src : main]

[Fiaz Muhammad (Gerrit)]

Attention needed from Fiaz Muhammad, Hailey Wang and Wenyu Fu

Message from Fiaz Muhammad

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:

• Fiaz Muhammad
• Hailey Wang
• Wenyu Fu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ieaeb51be52e832fc88be365b704c2a94db538261

Gerrit-Change-Number: 7926540

Gerrit-PatchSet: 15

Gerrit-Owner: Fiaz Muhammad <mf...@google.com>

Gerrit-Reviewer: Fiaz Muhammad <mf...@google.com>

Gerrit-Reviewer: Hailey Wang <haile...@google.com>

Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-Attention: Hailey Wang <haile...@google.com>

Gerrit-Attention: Fiaz Muhammad <mf...@google.com>

Gerrit-Attention: Wenyu Fu <wen...@chromium.org>

Gerrit-Comment-Date: Fri, 12 Jun 2026 19:42:32 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Hailey Wang (Gerrit)]

Attention needed from Fiaz Muhammad and Wenyu Fu

Hailey Wang voted and added 3 comments

Votes added by Hailey Wang

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 18 (Latest):

Hailey Wang . resolved

LGTM thanks!

File chrome/browser/context_sharing/tab_bottom_sheet/android/java/src/org/chromium/chrome/browser/tab_bottom_sheet/CoBrowseViews.java

Line 250, Patchset 18 (Latest): assert placeholder instanceof TextViewWithCompoundDrawables;

Hailey Wang . unresolved

Nit: I think this assert suffice and cover the null case above as well.

File chrome/browser/context_sharing/tab_bottom_sheet/public/android/java/src/org/chromium/chrome/browser/tab_bottom_sheet/TabBottomSheetContent.java

Line 66, Patchset 18 (Parent): NullUtil.assertNonNull(mContentView.findViewById(mEmptyPlaceholderContainerId));

Hailey Wang . unresolved

Is mEmptyPlaceholderContainerId still used after this removal?

Open in Gerrit

Related details

Attention is currently required from:

• Fiaz Muhammad
• Wenyu Fu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ieaeb51be52e832fc88be365b704c2a94db538261

Gerrit-Change-Number: 7926540

Gerrit-PatchSet: 18

Gerrit-Owner: Fiaz Muhammad <mf...@google.com>

Gerrit-Reviewer: Fiaz Muhammad <mf...@google.com>

Gerrit-Reviewer: Hailey Wang <haile...@google.com>

Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-Attention: Fiaz Muhammad <mf...@google.com>

Gerrit-Attention: Wenyu Fu <wen...@chromium.org>

Gerrit-Comment-Date: Sat, 13 Jun 2026 00:08:53 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Hailey Wang (Gerrit)]

Attention needed from Fiaz Muhammad and Wenyu Fu

Hailey Wang added 1 comment

File chrome/browser/context_sharing/tab_bottom_sheet/android/java/src/org/chromium/chrome/browser/tab_bottom_sheet/TabBottomSheetCoordinator.java

Line 729, Patchset 18 (Latest): View placeholder = mContentView.findViewById(R.id.empty_placeholder_container);

Hailey Wang . unresolved

Optional: Altho I wonder if, now that you make the cobrowseViews setup the empty view.... maybe you should also make the CoBrowseViews responsible for updating its visibility?

It's a little weird that the TBSC still need to reach into this view to update the visibility.

Gerrit-Comment-Date: Sat, 13 Jun 2026 00:13:11 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No