Dmitry Gozman (Gerrit)

unread,

Apr 9, 2026, 1:46:22 AM (6 days ago) Apr 9

to Andrey Kosyakov, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org

Attention needed from Andrey Kosyakov

Dmitry Gozman added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Dmitry Gozman . resolved

Andrey, could you please take a look?

Open in Gerrit

Related details

Attention is currently required from:

Andrey Kosyakov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Andrey Kosyakov (Gerrit)

unread,

Apr 10, 2026, 12:52:05 PM (5 days ago) Apr 10

to Dmitry Gozman, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org

Attention needed from Dmitry Gozman

Andrey Kosyakov voted and added 5 comments

Votes added by Andrey Kosyakov

Code-Review

+1

5 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Andrey Kosyakov . resolved

lgtm with comments

Commit Message

Line 7, Patchset 2 (Latest):[CDP] Expose TargetInfo.parentFrameId for worker targets

Andrey Kosyakov . unresolved

Please update [the comment here](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/devtools_protocol/domains/Target.pdl;l=30) accordingly.

File content/browser/devtools/dedicated_worker_devtools_agent_host.h

Line 68, Patchset 2 (Latest): std::string parent_frame_id_;

Andrey Kosyakov . unresolved

const?

File content/browser/devtools/dedicated_worker_devtools_agent_host.cc

Line 41, Patchset 2 (Latest): std::string(),

Andrey Kosyakov . unresolved

Would it make sense to actually plumb the parent as well? Looks like we do so for worklets.

File third_party/blink/web_tests/inspector-protocol/worker/worker-parent-frame-id.js

File-level comment, Patchset 2 (Latest):

Andrey Kosyakov . unresolved

What about worker started by a worker? ;-)

Open in Gerrit

Related details

Attention is currently required from:

Dmitry Gozman

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dmitry Gozman (Gerrit)

unread,

Apr 13, 2026, 10:38:20 AM (2 days ago) Apr 13

to android-bu...@system.gserviceaccount.com, Andrey Kosyakov, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org

Attention needed from Andrey Kosyakov

Dmitry Gozman added 4 comments

Commit Message

Line 7, Patchset 2:[CDP] Expose TargetInfo.parentFrameId for worker targets

Andrey Kosyakov . resolved

Please update [the comment here](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/devtools_protocol/domains/Target.pdl;l=30) accordingly.

Dmitry Gozman

Done

File content/browser/devtools/dedicated_worker_devtools_agent_host.h

Line 68, Patchset 2: std::string parent_frame_id_;

Andrey Kosyakov . resolved

const?

Dmitry Gozman

Done

File content/browser/devtools/dedicated_worker_devtools_agent_host.cc

Line 41, Patchset 2: std::string(),

Andrey Kosyakov . resolved

Would it make sense to actually plumb the parent as well? Looks like we do so for worklets.

Dmitry Gozman

Yeah, I will follow up with that.

File third_party/blink/web_tests/inspector-protocol/worker/worker-parent-frame-id.js

File-level comment, Patchset 2:

Andrey Kosyakov . resolved

What about worker started by a worker? ;-)

Dmitry Gozman

I'll include this case in the follow up where we also report the parent id.

Open in Gerrit

Related details

Attention is currently required from:

Andrey Kosyakov

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Andrey Kosyakov (Gerrit)

unread,

Apr 13, 2026, 12:27:38 PM (2 days ago) Apr 13

to Dmitry Gozman, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org

Attention needed from Dmitry Gozman

Andrey Kosyakov voted and added 1 comment

Votes added by Andrey Kosyakov

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Andrey Kosyakov . resolved

re-stamping

Open in Gerrit

Related details

Attention is currently required from:

Dmitry Gozman

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Dmitry Gozman (Gerrit)

unread,

Apr 13, 2026, 12:28:30 PM (2 days ago) Apr 13

to Andrey Kosyakov, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org

Dmitry Gozman voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

Apr 13, 2026, 1:01:22 PM (2 days ago) Apr 13

to Dmitry Gozman, Andrey Kosyakov, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org

chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

[CDP] Expose TargetInfo.parentFrameId for worker targets

Currently, there is no way to attribute worker to the owning frame,
which is a missing bit in reconstructing targets tree.

Bug: none

Change-Id: I3820ed98b8f5aae4b51d9750e1013681ab2afd2d

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7739241

Reviewed-by: Andrey Kosyakov <ca...@chromium.org>

Commit-Queue: Dmitry Gozman <dgo...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1613803}

Files:

M content/browser/devtools/dedicated_worker_devtools_agent_host.cc
M content/browser/devtools/dedicated_worker_devtools_agent_host.h
M content/browser/devtools/worker_devtools_manager.cc
M third_party/blink/public/devtools_protocol/domains/Target.pdl
M third_party/blink/web_tests/http/tests/inspector-protocol/target/auto-attach-wait-for-debugger-2-sessions-worker-expected.txt
M third_party/blink/web_tests/http/tests/inspector-protocol/target/get-target-info-worker-expected.txt
M third_party/blink/web_tests/http/tests/inspector-protocol/target/getTargets-worker-expected.txt
A third_party/blink/web_tests/inspector-protocol/worker/worker-parent-frame-id-expected.txt
A third_party/blink/web_tests/inspector-protocol/worker/worker-parent-frame-id.js

Change size: M

Delta: 9 files changed, 81 insertions(+), 6 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Andrey Kosyakov

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[CDP] Expose TargetInfo.parentFrameId for worker targets [chromium/src : main]

Dmitry Gozman (Gerrit)

Dmitry Gozman added 1 comment

Related details

Andrey Kosyakov (Gerrit)

Andrey Kosyakov voted and added 5 comments

Votes added by Andrey Kosyakov

5 comments

Related details

Dmitry Gozman (Gerrit)

Dmitry Gozman added 4 comments

Related details

Andrey Kosyakov (Gerrit)

Andrey Kosyakov voted and added 1 comment

Votes added by Andrey Kosyakov

1 comment

Related details

Dmitry Gozman (Gerrit)

Dmitry Gozman voted Commit-Queue+2

Related details

chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information