headless: assume Inspector.targetCrashed may come without enabling [chromium/src : master]

Dmitry Gozman (Gerrit)

unread,

Feb 20, 2018, 1:30:53 PM2/20/18

to Alex Clarke, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Alex, mind taking a look? This was exposed by Nasko's patch :)

Dmitry

Patch set 1:Commit-Queue +1

View Change

To view, visit change 927011. To unsubscribe, or for help writing mail filters, visit settings.

Alex Clarke (Gerrit)

unread,

Feb 21, 2018, 3:43:07 AM2/21/18

to Dmitry Gozman, Commit Bot, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Thanks!

Patch set 1:Code-Review +1Commit-Queue +2

View Change

To view, visit change 927011. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Feb 21, 2018, 4:15:36 AM2/21/18

to Dmitry Gozman, Alex Clarke, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Commit Bot merged this change by Dmitry Gozman.

View Change

Approvals:
  Alex Clarke: Looks good to me; Commit

headless: assume Inspector.targetCrashed may come without enabling

Historically, Inspector domain sends notifications even if not enabled.
This is not correct, but multiple clients rely on this behavior.

This patch makes headless client to expect stray Inspector.targetCrashed
notification.

Bug: none
Change-Id: Ie59d360cb9f93ec0c44a8369a1e9e1e9e6b5ec98
Reviewed-on: https://chromium-review.googlesource.com/927011
Commit-Queue: Alex Clarke <alexc...@chromium.org>
Reviewed-by: Alex Clarke <alexc...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538046}
---
M headless/lib/browser/headless_devtools_client_impl.cc
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/headless/lib/browser/headless_devtools_client_impl.cc b/headless/lib/browser/headless_devtools_client_impl.cc
index 4811cd8..fe015b4 100644
--- a/headless/lib/browser/headless_devtools_client_impl.cc
+++ b/headless/lib/browser/headless_devtools_client_impl.cc
@@ -200,7 +200,8 @@
     renderer_crashed_ = true;
   EventHandlerMap::const_iterator it = event_handlers_.find(method);
   if (it == event_handlers_.end()) {
-    NOTREACHED() << "Unknown event: " << method;
+    if (method != "Inspector.targetCrashed")
+      NOTREACHED() << "Unknown event: " << method;
     return false;
   }
   if (!it->second.is_null()) {

To view, visit change 927011. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward