[GreenDev]: Add feature flag for the project. [chromium/src : main]
0 views
Skip to first unread message
Finnur Thorarinsson (Gerrit)
Oct 9, 2025, 12:32:17 PM (5 days ago) Oct 9
to Alex Rudenko, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org
Attention needed from Alex Rudenko
Finnur Thorarinsson added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Finnur Thorarinsson (Gerrit)
Oct 9, 2025, 12:36:03 PM (5 days ago) Oct 9
to Camille Lamy, Alex Rudenko, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org
Attention needed from Alex Rudenko and Camille Lamy
Finnur Thorarinsson added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Finnur Thorarinsson . resolved
Camille, would you mind taking a look at the two files in content/*?
Related details
Attention is currently required from:
- Alex Rudenko
- Camille Lamy
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Finnur Thorarinsson (Gerrit)
Oct 9, 2025, 7:43:30 PM (4 days ago) Oct 9
to Camille Lamy, Alex Rudenko, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org
Attention needed from Alex Rudenko and Camille Lamy
Finnur Thorarinsson voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Alex Rudenko
- Camille Lamy
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Oct 10, 2025, 2:01:50 AM (4 days ago) Oct 10
to Finnur Thorarinsson, Camille Lamy, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org
Attention needed from Camille Lamy and Finnur Thorarinsson
Alex Rudenko added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Camille Lamy
- Finnur Thorarinsson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Camille Lamy (Gerrit)
Oct 10, 2025, 5:46:42 AM (4 days ago) Oct 10
to Finnur Thorarinsson, Alex Rudenko, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org
Attention needed from Finnur Thorarinsson
Camille Lamy added 1 comment![]( "Open in Gerrit")
File content/public/common/content_features.h
Line 99, Patchset 2 (Latest):
CONTENT_EXPORT BASE_DECLARE_FEATURE(kDevToolsGreenDevUi);Camille Lamy . unresolved
Should this be in content/? It seems to only be used in chrome/ so far.
Related details
Attention is currently required from:
- Finnur Thorarinsson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Finnur Thorarinsson (Gerrit)
Oct 13, 2025, 7:21:25 AM (19 hours ago) Oct 13
to Sylvain Defresne, Alex Rudenko, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org
Attention needed from Sylvain Defresne
Finnur Thorarinsson voted and added 2 comments![]( "Open in Gerrit")
Votes added by Finnur Thorarinsson
| Auto-Submit | +1 |
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Finnur Thorarinsson . resolved
Switching reviewers (code moved between files, owner needed for new files, but no longer for old files)
File content/public/common/content_features.h
Line 99, Patchset 2:
CONTENT_EXPORT BASE_DECLARE_FEATURE(kDevToolsGreenDevUi);Camille Lamy . resolved
Should this be in content/? It seems to only be used in chrome/ so far.
Finnur Thorarinsson
You are correct. This does not need to be in content/
Related details
Attention is currently required from:
- Sylvain Defresne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Finnur Thorarinsson (Gerrit)
Oct 13, 2025, 7:21:58 AM (19 hours ago) Oct 13
to Sylvain Defresne, Alex Rudenko, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org
Attention needed from Alex Rudenko and Sylvain Defresne
Finnur Thorarinsson added 1 comment![]( "Open in Gerrit")
Commit Message
could you please link an issue?
Attention is currently required from:
- Alex Rudenko
- Sylvain Defresne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Oct 13, 2025, 7:24:41 AM (19 hours ago) Oct 13
to Finnur Thorarinsson, Sylvain Defresne, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org
Attention needed from Finnur Thorarinsson and Sylvain Defresne
Alex Rudenko added 1 comment![]( "Open in Gerrit")
File components/ui_devtools/ui_devtools_features.h
Line 16, Patchset 4 (Latest):
BASE_DECLARE_FEATURE(kDevToolsGreenDevUi);Alex Rudenko . unresolved
does it need to be in the ui_devtools? it sounds like it should not be defined here
Related details
Attention is currently required from:
- Finnur Thorarinsson
- Sylvain Defresne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Finnur Thorarinsson (Gerrit)
Oct 13, 2025, 9:29:01 AM (17 hours ago) Oct 13
to Alex Rudenko, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org
Attention needed from Alex Rudenko
Finnur Thorarinsson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Finnur Thorarinsson
| Auto-Submit | +1 |
1 comment
File components/ui_devtools/ui_devtools_features.h
does it need to be in the ui_devtools? it sounds like it should not be defined here
Finnur Thorarinsson
Ah, my bad. I forgot to remove this file from the CL.
And that also means Sylvain is off the hook, and this probably is the cause of the weird error..
Related details
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Oct 13, 2025, 9:32:26 AM (17 hours ago) Oct 13
to Finnur Thorarinsson, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org
Attention needed from Finnur Thorarinsson
Alex Rudenko voted![]( "Open in Gerrit")
Attention is currently required from:
- Finnur Thorarinsson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 13, 2025, 10:30:06 AM (16 hours ago) Oct 13
to Finnur Thorarinsson, Alex Rudenko, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[GreenDev]: Add feature flag for the project.
... and pass it down into DevTools.
Bug: 451523531
Change-Id: Ib3835bd9fe2967a0fc20d832d67beb504f75ed3f
Commit-Queue: Alex Rudenko <alexr...@chromium.org>
Commit-Queue: Finnur Thorarinsson <fin...@chromium.org>
Auto-Submit: Finnur Thorarinsson <fin...@chromium.org>
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528897}
Files:
- M chrome/browser/about_flags.cc
- M chrome/browser/devtools/devtools_ui_bindings.cc
- M chrome/browser/devtools/features.cc
- M chrome/browser/devtools/features.h
- M chrome/browser/flag-metadata.json
- M chrome/browser/flag_descriptions.cc
- M chrome/browser/flag_descriptions.h
- M tools/metrics/histograms/enums.xml
Change size: S
Delta: 8 files changed, 28 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Rudenko
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages