Add a Pre-Paint devtools timeline event (devtools side) [devtools/devtools-frontend : main]
Philip Rogers (Gerrit)
Attention is currently required from: Yang Guo.
Philip Rogers would like Yang Guo to review this change.
Add a Pre-Paint devtools timeline event (devtools side)
The performance panel no longer matches the RenderingNG architecture [1]
and there are gaps and inaccuracies. This patch adds a "PrePaint" step
which will replace the "UpdateLayerTree" step. "PrePaint" matches the
current code and the architecture described in the RenderingNG Blogpost.
[1] https://developer.chrome.com/blog/renderingng-architecture/
Bug: 1191032
Change-Id: I9741f60ab4e0ecb6e190350c89856d2702cd7527
---
M front_end/core/i18n/locales/en-US.json
M front_end/core/i18n/locales/en-XL.json
M front_end/models/timeline_model/TimelineModel.ts
M front_end/panels/timeline/TimelineUIUtils.ts
4 files changed, 31 insertions(+), 0 deletions(-)
To view, visit change 3519245. To unsubscribe, or for help writing mail filters, visit settings.
Philip Rogers (Gerrit)
Attention is currently required from: Yang Guo.
1 comment:
Patchset:
Hi Yang Guo,
Can you suggest a reviewer for patches in this area? This is the first of a few patches to fill in missing pieces of the performance panel timeline. The blink-side patch for this is https://chromium-review.googlesource.com/c/chromium/src/+/3519012.
To view, visit change 3519245. To unsubscribe, or for help writing mail filters, visit settings.
Yang Guo (Gerrit)
Attention is currently required from: Victor Porof, Philip Rogers.
Yang Guo would like Victor Porof to review this change authored by Philip Rogers.
Add a Pre-Paint devtools timeline event (devtools side)
The performance panel no longer matches the RenderingNG architecture [1]
and there are gaps and inaccuracies. This patch adds a "PrePaint" step
which will replace the "UpdateLayerTree" step. "PrePaint" matches the
current code and the architecture described in the RenderingNG Blogpost.
[1] https://developer.chrome.com/blog/renderingng-architecture/
Bug: 1191032
Change-Id: I9741f60ab4e0ecb6e190350c89856d2702cd7527
---
M front_end/core/i18n/locales/en-US.json
M front_end/core/i18n/locales/en-XL.json
M front_end/models/timeline_model/TimelineModel.ts
M front_end/panels/timeline/TimelineUIUtils.ts
4 files changed, 31 insertions(+), 0 deletions(-)
To view, visit change 3519245. To unsubscribe, or for help writing mail filters, visit settings.
Yang Guo (Gerrit)
Attention is currently required from: Victor Porof, Philip Rogers.
1 comment:
Patchset:
Sorry for the late reply. I was OOO. I think Victor might be a good reviewer.
To view, visit change 3519245. To unsubscribe, or for help writing mail filters, visit settings.
Victor Porof (Gerrit)
Attention is currently required from: Philip Rogers.
Patch set 1:Code-Review +1
Philip Rogers (Gerrit)
Patch set 1:Commit-Queue +2
Philip Rogers (Gerrit)
Attention is currently required from: Simon Zünd.
Philip Rogers would like Simon Zünd to review this change.
Add a Pre-Paint devtools timeline event (devtools side)
The performance panel no longer matches the RenderingNG architecture [1]
and there are gaps and inaccuracies. This patch adds a "PrePaint" step
which will replace the "UpdateLayerTree" step. "PrePaint" matches the
current code and the architecture described in the RenderingNG Blogpost.
[1] https://developer.chrome.com/blog/renderingng-architecture/
Bug: 1191032
Change-Id: I9741f60ab4e0ecb6e190350c89856d2702cd7527
---
M front_end/core/i18n/locales/en-US.json
M front_end/core/i18n/locales/en-XL.json
M front_end/models/timeline_model/TimelineModel.ts
M front_end/panels/timeline/TimelineUIUtils.ts
4 files changed, 31 insertions(+), 0 deletions(-)
To view, visit change 3519245. To unsubscribe, or for help writing mail filters, visit settings.
Philip Rogers (Gerrit)
Attention is currently required from: Simon Zünd.
Patch set 1:Auto-Submit +1Commit-Queue +1
1 comment:
Patchset:
Simon, can you review front_end/models/?
To view, visit change 3519245. To unsubscribe, or for help writing mail filters, visit settings.
Simon Zünd (Gerrit)
Attention is currently required from: Philip Rogers.
Patch set 1:Code-Review +1Commit-Queue +2
1 comment:
Patchset:
lgtm, thanks for the detailed @description for translators!
To view, visit change 3519245. To unsubscribe, or for help writing mail filters, visit settings.
Devtools-frontend LUCI CQ (Gerrit)
Devtools-frontend LUCI CQ submitted this change.
Add a Pre-Paint devtools timeline event (devtools side)
The performance panel no longer matches the RenderingNG architecture [1]
and there are gaps and inaccuracies. This patch adds a "PrePaint" step
which will replace the "UpdateLayerTree" step. "PrePaint" matches the
current code and the architecture described in the RenderingNG Blogpost.
[1] https://developer.chrome.com/blog/renderingng-architecture/
Bug: 1191032
Change-Id: I9741f60ab4e0ecb6e190350c89856d2702cd7527
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3519245
Reviewed-by: Victor Porof <victo...@chromium.org>
Auto-Submit: Philip Rogers <p...@chromium.org>
Reviewed-by: Simon Zünd <szu...@chromium.org>
Commit-Queue: Simon Zünd <szu...@chromium.org>
---
M front_end/core/i18n/locales/en-US.json
M front_end/core/i18n/locales/en-XL.json
M front_end/models/timeline_model/TimelineModel.ts
M front_end/panels/timeline/TimelineUIUtils.ts
4 files changed, 36 insertions(+), 0 deletions(-)